Re: [PATCH] image-postproc-extension: empty mechine-id

["Su, Bao Cheng" <baocheng.su@siemens.com>]

On 7/10/2019 7:44 PM, Schild, Henning (CT RDA IOT SES-DE) wrote:
> Am Wed, 10 Jul 2019 10:48:31 +0200
> schrieb Baurzhan Ismagulov <ibr@radix50.net>:
> 
>> Hello Bao Cheng,
>>
>> On Mon, Jul 08, 2019 at 10:57:36AM +0000, Su, Bao Cheng wrote:
>>> According to manpage of debian machine-id @
>>> https://manpages.debian.org/buster/systemd/machine-id.5.en.html,
>>> /etc/machine-id should be empty instead of removing.
>>>
>>> Also according to above manpage, the dbus machine-id is copied to
>>> /etc/machine-id if systemd machine-id is empty. However, the dbus
>>> machine-id is also created during isar building, which stays the
>>> same for every machine using the same image.
>>>
>>> So here instead of removing, empty this file, and the mechine id
>>> will be regenerated at the first boot. Also remove the dbus
>>> machine-id to prevent copying.
>>
>> Thanks, applied to next.
> 
> Mhh the commit message looks pretty ugly. Probably because v2 was not
> actually done with git format-patch.
> 
> I would suggest to clean that up and force-push next.
> 
yeah I saw the ugly message from the github.com. Do I have the 
permissions to force-push the next branch? or do I need re-send the
patch to mailing list?

> Henning
> 
>> I couldn't observe your original
>> "sys-subsystem-net-devices-multi-user.device timeouts" problem. Is it
>> reproducible with stock Isar? Which architecture?
>>
>> Also, at least for amd64, the machine id is only generated
>> temporarily. The file is not replaced since /etc is read-only at that
>> moment. So we have to revisit Claudius's rw patch. This works for arm
>> since it is already rw.
>>
>> With kind regards,
>> Baurzhan.
>>
>