Re: [PATCH 3/3] meta/classes: add cpiogz-img

[Gylstorff Quirin <quirin.gylstorff@siemens.com>]

On 3/27/20 8:01 PM, Henning Schild wrote:
> On Fri, 27 Mar 2020 14:28:01 +0100
> "[ext] Q. Gylstorff" <Quirin.Gylstorff@siemens.com> wrote:
> 
>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>
>> to create a initramfs like filesystem.
>>
>> Signed-off-by:  Michael Adler <michael.adler@siemens.com>
>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>> ---
>>   meta/classes/cpiogz-img.bbclass | 19 +++++++++++++++++++
>>   1 file changed, 19 insertions(+)
>>   create mode 100644 meta/classes/cpiogz-img.bbclass
>>
>> diff --git a/meta/classes/cpiogz-img.bbclass
>> b/meta/classes/cpiogz-img.bbclass new file mode 100644
>> index 0000000..f665bcd
>> --- /dev/null
>> +++ b/meta/classes/cpiogz-img.bbclass
>> @@ -0,0 +1,19 @@
>> +# This software is a part of ISAR.
>> +# Copyright (C) 2020 Siemens AG
>> +#
>> +# SPDX-License-Identifier: MIT
>> +
>> +CPIOGZ_FNAME ?= "${IMAGE_FULLNAME}.cpio.gz"
>> +CPIOGZ_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${CPIOGZ_FNAME}"
>> +IMAGER_INSTALL += "cpio"
>> +
>> +do_cpiogz_image() {
>> +    sudo rm -f ${CPIOGZ_IMAGE_FILE}
> 
> "${DEPLOY_DIR_IMAGE}/${CPIOGZ_FNAME}" and drop the variable
> 
>> +    image_do_mounts
>> +    sudo chroot --userspec=$(id -u):$(id -g) ${BUILDCHROOT_DIR} \
> 
> I am not sure we really need to use the tools from the buildchroot
> here, but that is fair. The targz image does not go that far but cpio
> does not seem to be an essential package so might not be available.
> 
> But you are going in as regular user, so you will fail to read
> root-owned content, and probably mess up permissions.
> 
>> +                sh -c "cd ${PP_ROOTFS}; /usr/bin/find . | \
>> +                       /usr/bin/cpio -H newc -o | /usr/bin/gzip -9 >
>> \
>> +                       ${PP_DEPLOY}/${CPIOGZ_FNAME}"
> 
> Say you drop the userspec, you will need the chown seen in targz because
> the file in DEPLOY should be owned by who is building.
> 
> Henning
> 
>> +}
>> +
>> +addtask cpiogz_image before do_image after do_image_tools
> 

Will do a v2 with your comments.

-- 
Quirin