Re: [PATCH 07/10] image: add CUSTOM_IMAGE_EXTENSIONS for user layers/machines to use

[Cedric Hombourger <cedric_hombourger@mentor.com>]

On 11/6/2019 5:08 PM, Jan Kiszka wrote:
> On 24.10.19 20:09, [ext] Henning Schild wrote:
>> Very smelly and hacky ;). There is no such way since there is a strict
>> policy to try and solve everything with packages ... except for where
>> this is not possible ...
>>
>> I am strongly against that, it will be abused. If you need to inherit
>> image.bbclass in your own funny-image.bbclass and add the hack in a
>> layer.
> Ack, specifically while we do not know the actual use case. Can you
> explain it, Cedric?

that kludge was removed in the linux-custom patch series I sent yesterday

> And if you want to hack, nothing prevent you from defining a custom
> image /recipe/ that inherits "CUSTOM_IMAGE_EXTENSION" directly.
that's a good hint - thanks!
> Jan
>
>> Henning
>>
>> Am Thu, 24 Oct 2019 11:02:21 +0200
>> schrieb Cedric Hombourger <Cedric_Hombourger@mentor.com>:
>>
>>> Some machines may require additional post-processing on the image
>>> before the actual file-system image is created. The image extension
>>> mechanism was designed for this purpose but does not seem to provide
>>> any way for user layers/machines to use. Add a
>>> CUSTOM_IMAGE_EXTENSIONS variable to fill this gap.
>>>
>>> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
>>> ---
>>>   meta/classes/image.bbclass | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
>>> index 7690bc5..633b514 100644
>>> --- a/meta/classes/image.bbclass
>>> +++ b/meta/classes/image.bbclass
>>> @@ -30,6 +30,9 @@ BUILDROOT_DEPLOY = "${BUILDCHROOT_DIR}${PP_DEPLOY}"
>>>   BUILDROOT_ROOTFS = "${BUILDCHROOT_DIR}${PP_ROOTFS}"
>>>   BUILDROOT_WORK = "${BUILDCHROOT_DIR}${PP_WORK}"
>>>   
>>> +# Default to no custom image extensions
>>> +CUSTOM_IMAGE_EXTENSIONS ?= ""
>>> +
>>>   python(){
>>>       if (d.getVar('IMAGE_TRANSIENT_PACKAGES')):
>>>           bb.warn("IMAGE_TRANSIENT_PACKAGES is set and no longer
>>> supported") @@ -71,6 +74,7 @@ inherit image-tools-extension
>>>   inherit image-postproc-extension
>>>   inherit image-locales-extension
>>>   inherit image-account-extension
>>> +inherit ${CUSTOM_IMAGE_EXTENSIONS}
>>>   
>>>   # Extra space for rootfs in MB
>>>   ROOTFS_EXTRA ?= "64"
>