From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6751292434813026304 X-Received: by 2002:a2e:161b:: with SMTP id w27mr2577873ljd.183.1573056718181; Wed, 06 Nov 2019 08:11:58 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:651c:c4:: with SMTP id 4ls995088ljr.6.gmail; Wed, 06 Nov 2019 08:11:57 -0800 (PST) X-Google-Smtp-Source: APXvYqwkD7diAWoPIFLX1mHStFKZ9qQgkyq2QSUd2Uv4HUFWrCFoNynwqHdbYgyXXPpW1/mE/KzU X-Received: by 2002:a2e:2c14:: with SMTP id s20mr2542707ljs.210.1573056717634; Wed, 06 Nov 2019 08:11:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573056717; cv=none; d=google.com; s=arc-20160816; b=qSXsGWM5dIF6jCJZcdKQhSxysNNCuLXT6uhJuUoaGrpVGJijKTgLZXWm42B3Nrteoz wyWAXK5tAvLF7v4YBha47YhETDlYL/MwiBi9OjgDz5fC2nDZ1ceGhv942SfOUL4AiHTy moBiIBeQvvo8zjq5cFwSWyl8aWUYdNeNFbPxN8LRNVw+d66T7FQaRXwV78wuaVtVml29 LJJVDb5bxDF20I9Tarq79lK5GLD7axghGhM0pCk4A2e4bWGMCB07CsddL9uMPSYRzxpg qSCkcNAuwVr2YElv+ugg/kKmfNSQ0P4PLGkhT2uWlfhvVmsPO5H+APgjdnwEXM8s1iqH Av8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :ironport-sdr:ironport-sdr; bh=cjK8EBncTdK1t1Ej67A5Z+GCIO2s04eMq17zrh1uht4=; b=evBakdXazwq6u0P+aeVRIcKo1rOraA0uX3iGEcDrsvSIdmDf4DtAkbBlyyMxSA8P9j xbhBONlOnQYAGtr90tPtwqSzSGe/Rapu7LBIcC9lYfT10qie8RlXBsKPZSXHmIY3nlRU SJH58ubZfE+GyjGUJTBG34fuqlVzAIXevYbbW9knoBE5MdH8uQNZFi8NuUObLIUVANiE /F+dXs1mjt20jmSy4L6NCty8ORAWSORP9RxeCyg+fn5nW3GCLuCkdKXUo0nXTZcTD7Tm KIuBqNcoPdVqURIQ3Z/XpaOCqDTRfHxZuuAETJPiKSZZxjLPxJuLysav3DEOdCfD4Gdc /SCQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of cedric_hombourger@mentor.com designates 68.232.137.252 as permitted sender) smtp.mailfrom=Cedric_Hombourger@mentor.com Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com. [68.232.137.252]) by gmr-mx.google.com with ESMTPS id z18si1045595lfh.1.2019.11.06.08.11.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Nov 2019 08:11:57 -0800 (PST) Received-SPF: pass (google.com: domain of cedric_hombourger@mentor.com designates 68.232.137.252 as permitted sender) client-ip=68.232.137.252; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of cedric_hombourger@mentor.com designates 68.232.137.252 as permitted sender) smtp.mailfrom=Cedric_Hombourger@mentor.com IronPort-SDR: jBxERoaXryI5L8ThhI7Ox2kDx9Pd0bt7fmln40ghCT3GvWUQgKnT11If7AV+AXNityj8pZx0cv q898kl719ValFrHqcQ6RqpMdkWCr5CH5NWXrCwkkhr5E4nQap7P3klDRgDtoVZW74vgmduWS2g ah0zu3UkhA/EFhhY545Ai7GhmUB1lZYhgwFh6d1mg9Ka1U85McfuoYkvyA7K7Gz6hWFSPgUrtv AOlvzMfHgYl9g5fYJTyDKuCVXiaccBmUazCTfAfG6QjV/NSNkwjk3qymIJygfNMKt5jLSx0Sqi WkI= X-IronPort-AV: E=Sophos;i="5.68,275,1569312000"; d="scan'208";a="42960202" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 06 Nov 2019 08:11:42 -0800 IronPort-SDR: tMm2HXnGI7ryXLWo6rq/E5mUu4UNpUhcDIMNuObhkqQ2FBSbYtL4a2xs3OHqsMY/T8WOd4xla3 dyLX81pymBVREd312gQxXk8htLsk6sboHUICxo5R1krb3DSTN5TZctZ4U9ZnIJPTMk342bcIMB Wjy+zH7GE7MLxg4V40gymBhDMc9oRuaAEzsBPFICrsKGpvZt6GQNDlc6bhTKx5aRrpzKtsMKmB rpfCrYRYQAm6lqannksml6FGVDF0pKFJPf/vEUB1/tNn3NgKTJDb4qMeUi0s/j1OWsUjrCh1aE Iwc= Subject: Re: [PATCH 07/10] image: add CUSTOM_IMAGE_EXTENSIONS for user layers/machines to use To: Jan Kiszka , "[ext] Henning Schild" CC: References: <1571907744-1121-1-git-send-email-Cedric_Hombourger@mentor.com> <1571907744-1121-8-git-send-email-Cedric_Hombourger@mentor.com> <20191024200903.6743650a@md1za8fc.ad001.siemens.net> <8efb826c-2021-0646-ba4e-daa14d05e534@siemens.com> From: Cedric Hombourger Message-ID: <11a42ae2-ed23-bb4a-308b-d075e1be14b2@mentor.com> Date: Wed, 6 Nov 2019 17:11:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <8efb826c-2021-0646-ba4e-daa14d05e534@siemens.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Return-Path: cedric_hombourger@mentor.com X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) X-TUID: ZkX0xOUalGyQ On 11/6/2019 5:08 PM, Jan Kiszka wrote: > On 24.10.19 20:09, [ext] Henning Schild wrote: >> Very smelly and hacky ;). There is no such way since there is a strict >> policy to try and solve everything with packages ... except for where >> this is not possible ... >> >> I am strongly against that, it will be abused. If you need to inherit >> image.bbclass in your own funny-image.bbclass and add the hack in a >> layer. > Ack, specifically while we do not know the actual use case. Can you > explain it, Cedric? that kludge was removed in the linux-custom patch series I sent yesterday > And if you want to hack, nothing prevent you from defining a custom > image /recipe/ that inherits "CUSTOM_IMAGE_EXTENSION" directly. that's a good hint - thanks! > Jan > >> Henning >> >> Am Thu, 24 Oct 2019 11:02:21 +0200 >> schrieb Cedric Hombourger : >> >>> Some machines may require additional post-processing on the image >>> before the actual file-system image is created. The image extension >>> mechanism was designed for this purpose but does not seem to provide >>> any way for user layers/machines to use. Add a >>> CUSTOM_IMAGE_EXTENSIONS variable to fill this gap. >>> >>> Signed-off-by: Cedric Hombourger >>> --- >>> meta/classes/image.bbclass | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass >>> index 7690bc5..633b514 100644 >>> --- a/meta/classes/image.bbclass >>> +++ b/meta/classes/image.bbclass >>> @@ -30,6 +30,9 @@ BUILDROOT_DEPLOY = "${BUILDCHROOT_DIR}${PP_DEPLOY}" >>> BUILDROOT_ROOTFS = "${BUILDCHROOT_DIR}${PP_ROOTFS}" >>> BUILDROOT_WORK = "${BUILDCHROOT_DIR}${PP_WORK}" >>> >>> +# Default to no custom image extensions >>> +CUSTOM_IMAGE_EXTENSIONS ?= "" >>> + >>> python(){ >>> if (d.getVar('IMAGE_TRANSIENT_PACKAGES')): >>> bb.warn("IMAGE_TRANSIENT_PACKAGES is set and no longer >>> supported") @@ -71,6 +74,7 @@ inherit image-tools-extension >>> inherit image-postproc-extension >>> inherit image-locales-extension >>> inherit image-account-extension >>> +inherit ${CUSTOM_IMAGE_EXTENSIONS} >>> >>> # Extra space for rootfs in MB >>> ROOTFS_EXTRA ?= "64" >