Re: [PATCH] isar-bootstrap: Fix and cleanup bind mounting

[Jan Kiszka <jan.kiszka@siemens.com>]

On 04.12.18 18:10, Jan Kiszka wrote:
> On 04.12.18 17:59, Maxim Yu. Osipov wrote:
>> Hi Jan, Cedric,
>>
>> Another question:
>>
>> Which debian/kernel do you use inside your VM/docker?
> 
> Container is kasproject/kas-isar:latest here, kernel is $random-host.
> 
>>
>> Is it also stretch?
> 
> Yes.
> 
>>
>> The problem is reproducible at the the same point on stretch systems (with 
>> kernel SMP Debian 4.9.110-3+deb9u6 (2018-10-08) x86_64 GNU/Linux)
>>
>> when commands are launched by hand:
> 
> What was your Isar baseline for that? I tested with this branch:
> 
> https://github.com/siemens/isar/commit/03e394b2aa58b5b1404fde76881774baf4a541bc
> 
>>
>> Command 1)
>> bitbake  -c cache_base_repo multiconfig:qemuarm-stretch:isar-image-base 
>> multiconfig:qemuarm64-stretch:isar-image-base multiconfig:qemuamd64-
>> stretch:isar-image-base
> 
> Did you check if everything was unmounted at this point already?
> 
>>
>> Command 2)
>> sudo rm -rf tmp
>>
>> Command 3)
>> sed -i -e 's/#ISAR_USE_CACHED_BASE_REPO ?= "1"/ISAR_USE_CACHED_BASE_REPO ?= 
>> "1"/g' conf/local.conf
>>
>> No problems detected at this point - the same mounts etc.
>>
>> The next command hungs on the last task (according strace bitbake tries to 
>> unmount /sys /dev)
> 
> And who is holding back that mounts (lsof)? How does pstree -apl look like?
> 
> BTW, can you recover the build system for this stage? As I said, one of the 
> symptoms or side-effect is removal of device nodes on those side when /dev is 
> mounted at the wrong time.
> 

It's also worth trying if any of these hunks help:

diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass
index b3ce434..b2607b6 100644
--- a/meta/classes/isar-events.bbclass
+++ b/meta/classes/isar-events.bbclass
@@ -18,7 +18,7 @@ python isar_handler () {
         with open('/proc/mounts', 'rU') as f:
             for line in f:
                 if basepath in line:
-                    if subprocess.call('sudo umount ' + line.split()[1],
+                    if subprocess.call('sudo umount -l ' + line.split()[1],
                                        stdout=devnull, stderr=devnull,
                                        shell=True) != 0:
                         result = False
diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
index 20b77b7..aae9084 100755
--- a/scripts/ci_build.sh
+++ b/scripts/ci_build.sh
@@ -92,6 +92,7 @@ if [ -n "$FAST_BUILD" ]; then
         multiconfig:qemuarm-stretch:isar-image-base \
         multiconfig:qemuarm64-stretch:isar-image-base \
         multiconfig:qemuamd64-stretch:isar-image-base
+    while [ -e bitbake.sock ]; do sleep 1; done
     sudo rm -rf tmp
     sed -i -e 's/#ISAR_USE_CACHED_BASE_REPO ?= "1"/ISAR_USE_CACHED_BASE_REPO ?= "1"/g' conf/local.conf
     bitbake $BB_ARGS \


Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux