From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6729358150130991104 X-Received: by 2002:a17:906:a03:: with SMTP id w3mr15092094ejf.218.1566800791518; Sun, 25 Aug 2019 23:26:31 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:7f95:: with SMTP id f21ls5108783ejr.3.gmail; Sun, 25 Aug 2019 23:26:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqxPxEm+rf+A1RK8k2nPIP2uJ6tA3kYllOa12Ks+IrhEIbAofKcWgTHqAWinWtyAKlzqUR0H X-Received: by 2002:a17:906:6448:: with SMTP id l8mr15347074ejn.233.1566800790944; Sun, 25 Aug 2019 23:26:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566800790; cv=none; d=google.com; s=arc-20160816; b=e71nNqnfa/HN82oZeouFHoxwXV2oH26LN7FjE6BN8cKZbbP1i0PoSGsPFMvBvDkaTL 1UnptthG1X2VcvxVbbJzeIYblWh4XWi8z5J569/4ff1A+ibBwGWGuSxBOS+rTqFyu1Nv wYK7aWk9u2QXM2BmfyCeomq8Y4jQ0Pbfgcpt2giNNEyqXn64FfhPH0bB24OrivSLNiZV s/3bk0Wl2yI7cugTdAYYtluRGDtpqOphd0qc9MyUCWFLti+N8TOfj9Zukz+GZkL8t+V6 BY1auEzkTW2P4QRSD0mqXveMCMIfJEi/eRvF5UdUbr7TU2RtPdPqS32uRAWEpOD9ghR4 RSJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:references:in-reply-to:message-id:date :subject:to:from; bh=3/WbVSNob0svBKYTnnGn8ojp1L7f3yxUIQnqYGH9pmM=; b=xinkk+6XqncGGjGnle2lqvxuRDeXOCytJy6MOj+21Qsm1hPuFTzUOqXDoumn4QiWXV 6MBzxtCUl8Yiw2YtuIkkG6M3gKxuOr6LvqWyItbbGcjFJf71H6kCqTyoy9i6clhQr8tQ QVTOsixqROa6hz5tWWNcwyyYhr1RzVPO6DIt5Tq6PTn+mAcyF7zzppjigCCyY3D8BcWc 9R0nPl0RabVI6VoPj8YhqG9RpcYkty3fs2FxbX9n1cP9btWKCzZvJ5xcqnmaYf9OFdWe 7rg2SkNR1Osw/ueAwey4bGa2A+xl+HyzYteZXPMYH8uPLeF4VWgBxqssBbqkWb1bSOZc PZcg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id l17si558292ejg.1.2019.08.25.23.26.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Aug 2019 23:26:30 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x7Q6QU2Q029691 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 26 Aug 2019 08:26:30 +0200 Received: from md1f2u6c.ad001.siemens.net ([139.22.35.99]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x7Q6QRH2015165 for ; Mon, 26 Aug 2019 08:26:29 +0200 From: Jan Kiszka To: isar-users Subject: [PATCH 08/26] isar-events: Do not start cleanup early Date: Mon, 26 Aug 2019 08:26:09 +0200 Message-Id: <123c8be5be356979437e799b9f0bfedc2922e28f.1566800787.git.jan.kiszka@siemens.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: References: In-Reply-To: References: X-TUID: jsH2oyV6/tRz From: Jan Kiszka Umounting already on runQueueExitWait just pulls the carpet under the feet of still running builds, causing follow-up errors when just one recipe failed. Even worse, terminating builds with ctrl-c does not allow to finish most of the running tasks because they will stumble over disappearing mounts. While at it, give the handler a clearer name, namely that of its trigger. Signed-off-by: Jan Kiszka --- meta/classes/isar-events.bbclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass index 7dd1ed5..62eb25d 100644 --- a/meta/classes/isar-events.bbclass +++ b/meta/classes/isar-events.bbclass @@ -4,9 +4,9 @@ # Copyright (C) 2015-2017 ilbers GmbH # Copyright (c) Siemens AG, 2018 -addhandler isar_handler +addhandler build_completed -python isar_handler() { +python build_completed() { import subprocess tmpdir = d.getVar('TMPDIR', True) @@ -25,4 +25,4 @@ python isar_handler() { ) } -isar_handler[eventmask] = "bb.runqueue.runQueueExitWait bb.event.BuildCompleted" +build_completed[eventmask] = "bb.event.BuildCompleted" -- 2.16.4