From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Moessbauer,
Felix (CT RDA IOT SES-DE)" <felix.moessbauer@siemens.com>,
"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: Re: [PATCH v2 1/1] Add support for apt sources which use an absolute Suite Component
Date: Mon, 27 Jul 2020 11:42:39 +0200 [thread overview]
Message-ID: <12773061-88f3-9d3c-53fa-01a17868f1fc@siemens.com> (raw)
In-Reply-To: <AM0PR10MB193933486648F67F80C5B16489720@AM0PR10MB1939.EURPRD10.PROD.OUTLOOK.COM>
On 27.07.20 11:22, Moessbauer, Felix (CT RDA IOT SES-DE) wrote:
> Hi,
>
> What's the status of this patch?
> Are there any open points / reviews before it can be merged?
>
It's fine from my POV. I suppose our maintainer is on vacation.
Jan
> Best regards,
> Felix
>
>> -----Original Message-----
>> From: Felix Moessbauer <felix.moessbauer@siemens.com>
>> Sent: Wednesday, July 1, 2020 2:20 PM
>> To: isar-users@googlegroups.com
>> Cc: Moessbauer, Felix (CT RDA IOT SES-DE) <felix.moessbauer@siemens.com>
>> Subject: [PATCH v2 1/1] Add support for apt sources which use an absolute Suite
>> Component
>>
>> From: Felix Mößbauer <felix.moessbauer@siemens.com>
>>
>> This patch adds support to add apt sources in the format of deb http://url /
>> which is also known as absolute Suite Component format.
>> The current isar version fails on parsing this format.
>>
>> A potential use case is to add packages from opensuse.
>>
>> Signed-off-by: Felix Mößbauer <felix.moessbauer@siemens.com>
>> ---
>> meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-
>> core/isar-bootstrap/isar-bootstrap.inc
>> index da0d436..f530d7d 100644
>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
>> @@ -86,7 +86,10 @@ def parse_aptsources_list_line(source_list_line):
>>
>> source, s = re.split("\s+", s, maxsplit=1)
>>
>> - suite, s = re.split("\s+", s, maxsplit=1)
>> + if s.startswith("/"):
>> + suite = ""
>> + else:
>> + suite, s = re.split("\s+", s, maxsplit=1)
>>
>> components = " ".join(s.split())
>>
>> --
>> 2.20.1
>
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2020-07-27 9:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 11:24 [PATCH 0/1] Add support for Suite Component format sources Felix Mößbauer
2020-07-01 11:24 ` [PATCH 1/1] Add support for apt sources which use an absolute Suite Component Felix Mößbauer
2020-07-01 11:27 ` [PATCH 0/1] Add support for Suite Component format sources Jan Kiszka
2020-07-01 12:19 ` [PATCH v2 " Felix Moessbauer
2020-07-01 12:19 ` [PATCH v2 1/1] Add support for apt sources which use an absolute Suite Component Felix Moessbauer
2020-07-27 9:22 ` Moessbauer, Felix
2020-07-27 9:42 ` Jan Kiszka [this message]
2020-10-13 10:24 ` Jan Kiszka
2020-11-18 19:17 ` Baurzhan Ismagulov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12773061-88f3-9d3c-53fa-01a17868f1fc@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=felix.moessbauer@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox