From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6631131420328722432 X-Received: by 2002:a50:a5f1:: with SMTP id b46mr4753979edc.12.1544015043818; Wed, 05 Dec 2018 05:04:03 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:97b6:: with SMTP id e51ls5832226edb.6.gmail; Wed, 05 Dec 2018 05:04:03 -0800 (PST) X-Google-Smtp-Source: AFSGD/W2p3VDXjBMk+UPLwnrIGE632aeb/8wjN2riOXGvT6r/QMIJkB+ZPiFcRtEJHP7VW64BLzv X-Received: by 2002:aa7:c393:: with SMTP id k19mr4755821edq.6.1544015043430; Wed, 05 Dec 2018 05:04:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544015043; cv=none; d=google.com; s=arc-20160816; b=Pdhk0oe5owAx5u2Sk9ECBTu3jrYc6r+TEUGZ6VlFclfTaJAjLk+hTzRff/ZmRjUwBr j0xd4LjUtvV7izd2uOtC/5bLlXOvSYxuefj0Nkunt2j6iC2dhST9049IPFstRv1Pgxm1 ymOCfjN8MR0V0pP2wUQTk8BHrqi65zWnM4OVVivHxgl8txh4TWLB1TvUluNGvvXJ7p2o rEkaQMxmQCGngbozBzuKedlV+8Qw8BDEYu3YjA+V1fMHm+7c51KjLCyDA4kDt5AzGn/w DW34PUB4IPSWI7jCwVB8ziVDAPVQ2ZZoAjmu1CQ72/V8Ipf/caYYf+NI+OkMUZHlhVPV lXHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=C5I14p4tUn7cV1qlB1j2lF5KWs1lj8K+kostWrN1gbc=; b=kmqt1dU1H++1WTgzCDVTk97tuEkwpU8uV/X4qnq4xVw6CjGSqE9riluXh8jT/tXcFm 4ElVTDz4nXlEf7GTjEeZZJh5j0enaa0lm7AjZgkUFDRTWT/CRf38oEYOPGjRflvp+bRU LqUHcBYNakWs4+ZFyFNw1+yRMOLBgojwFPHWIfxEZdDP+AEcvK7josTyNfQfmLttjbhz l9ykogle5P7m0wwtoG1ane6d36UemwM4GgPRB0jGd8a54+JAX8dqhpQ8TQ3QF5EC70Zc uF5C3viqQLtnrI1IUXKetM7+STB/8HhJFDBZJVB75OdI5ETruEMc792+1sO/j0q+beye nKqQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id l31si839532edb.5.2018.12.05.05.04.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 05:04:03 -0800 (PST) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id wB5D422N030387 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 Dec 2018 14:04:02 +0100 Received: from [139.25.69.181] (linux-ses-ext02.ppmd.siemens.net [139.25.69.181]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wB5D42M3014769; Wed, 5 Dec 2018 14:04:02 +0100 Subject: Re: [PATCH] isar-bootstrap: debootstrap --include flag to support https:// sources To: Jan Kiszka , =?UTF-8?B?VG9sZ2EgSG/Fn2fDtnI=?= Cc: isar-users@googlegroups.com References: <20181204133544.50621-1-tolga.hosgor@siemens.com> <45323f2d-7dac-9b9d-6382-013b9ae1242c@siemens.com> <66336a00-2604-0915-c341-464aad285715@siemens.com> <636386f3-7eca-10bd-1ea1-1d5286ce15a9@siemens.com> From: Claudius Heine Message-ID: <127b3b98-7288-9356-7fad-4fe1b4bad9a3@siemens.com> Date: Wed, 5 Dec 2018 14:04:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <636386f3-7eca-10bd-1ea1-1d5286ce15a9@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 0RIEzI32Vn7F Hi Jan, On 05/12/2018 13.58, Jan Kiszka wrote: > On 05.12.18 13:55, Claudius Heine wrote: >> On 05/12/2018 13.27, [ext] Claudius Heine wrote: >>>> >>>> Now I am completely lost. I suppose there is no need to create the >>>> logic to to differentiate HTTP and HTTPS in ISAR if distro conf will >>>> set the packages. Distro configuration knows whether if it is using >>>> HTTP or HTTPS (or in theory something else) and it should be enough to >>>> define/extend _one_ variable accordingly. >>> >>> I would suggest calling those variables like this: >>> >>> DISTRO_BOOTSTRAP_BASE_PACKAGES = "locales" >>> DISTRO_BOOTSTRAP_BASE_PACKAGES_append_https-support = " >>> apt-transport-https ca-certificates" >>> >>> # OVERRIDE = "...:https-support:..." # when you detect that https is >>> needed. >>> >>> or similar. And then use those variables in isar-bootstrap with your >>> logic. >> >> Maybe I should be a bit more explicit here. >> >> The distro config does *not* know if somewhere else (some other >> configuration, file potentially from another layer) adds an additional >> repository that uses https. Since isar-bootstrap already does some >> parsing of the source lists and calls debootstrap, it would be the >> right point to handle that. > > Do we really need to model that with overrides? It brings some > complexity of its own when changing that dynamically. Of course we don't *need* to. I just don't like introducing new variables all the time. At some point converging to some small set of variables is desirable. (IMO we have to many of them in isar as is) IMO that is a trade-off and there is no right solution here. I just wanted to point that out that this might be possible and then let the person writing the patch decides. Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de