public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Felix Moessbauer <felix.moessbauer@siemens.com>,
	isar-users@googlegroups.com
Cc: henning.schild@siemens.com, adriaan.schmidt@siemens.com
Subject: Re: [PATCH v1 1/1] Fix permissions when splitting rootfs folders across partitions.
Date: Wed, 3 Nov 2021 14:26:05 +0100	[thread overview]
Message-ID: <127b5e2e-617f-5934-e9d6-54a88664bf6c@siemens.com> (raw)
In-Reply-To: <20211103125305.3021016-1-felix.moessbauer@siemens.com>

On 03.11.21 13:53, Felix Moessbauer wrote:
> This patches ensures that the file database containing the file and
> folder usernames and permissions is always located relative to the
> source and not to the appended rootfs-dir.
> 
> Prior to this patch, the database was not found when using
> -rootfs-dir in the WIC script, leading to erronous file
> permissions and ownership.
> 
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  scripts/lib/wic/plugins/source/rootfs.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/lib/wic/plugins/source/rootfs.py b/scripts/lib/wic/plugins/source/rootfs.py
> index 96d940a..5ab771e 100644
> --- a/scripts/lib/wic/plugins/source/rootfs.py
> +++ b/scripts/lib/wic/plugins/source/rootfs.py
> @@ -95,7 +95,7 @@ class RootfsPlugin(SourcePlugin):
>  
>          part.rootfs_dir = cls.__get_rootfs_dir(rootfs_dir)
>          part.has_fstab = os.path.exists(os.path.join(part.rootfs_dir, "etc/fstab"))
> -        pseudo_dir = os.path.join(part.rootfs_dir, "../pseudo")
> +        pseudo_dir = os.path.join(krootfs_dir['ROOTFS_DIR'], "../pseudo")
>          if not os.path.lexists(pseudo_dir):
>              logger.warn("%s folder does not exist. "
>                          "Usernames and permissions will be invalid " % pseudo_dir)
> 

Upstream first: first OE, then Isar. At least submit to OE first. If
it's urgent, we can still decide to apply here earlier.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

  reply	other threads:[~2021-11-03 13:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 12:53 Felix Moessbauer
2021-11-03 13:26 ` Jan Kiszka [this message]
2022-04-21 14:42   ` Jan Kiszka
2022-04-21 16:09     ` Moessbauer, Felix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=127b5e2e-617f-5934-e9d6-54a88664bf6c@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=adriaan.schmidt@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox