From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7026325955122561024 X-Received: by 2002:a05:6000:10cb:: with SMTP id b11mr44134768wrx.71.1635945967670; Wed, 03 Nov 2021 06:26:07 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:ed0e:: with SMTP id l14ls980496wmh.0.gmail; Wed, 03 Nov 2021 06:26:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz215lazDrB6erexkf0ayIE3dJ3zHdJx62VlGKq1sLS/lca5LvR9owgFKggRQ6pdaPKPNwV X-Received: by 2002:a1c:a984:: with SMTP id s126mr15064386wme.156.1635945966687; Wed, 03 Nov 2021 06:26:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635945966; cv=none; d=google.com; s=arc-20160816; b=szIHA9mOxLzE3dnllz9F1WoyBEawbAK33VLymZdcT0ydlkqXORWlhna6whogNZjive Vebu514ejmiNH516TgdOQPsJaRbYWOcUCuRJXcHRnV6UHE0555KLiP/kCFER08hWUog7 roGgNinfFsAzv3HmVqmG5MGO06crb5DZKfBFZ8fcmwDcm9s8ler24uxeL3BqEc8IlMW/ UPToL/LY1rqvioWDLkkTh3M7juJ7dATp5so7iAMFblDec937L1lyO1Qg06PkboqasjtZ y0qmoFxn0PhSyvPD2sjXnWtCQzZAh3XOqi88WbPcRENCcS6bjoyBuavRsUY4HtjV1Hco 2W5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=Wxly14ZKQ6Z0H8zKYafi0anZ0JJr502VocyOoAn1eEU=; b=HgxJxfyjj4LDhnYK09n44aIO2HYI+TfG0pJr9jpu6f+HyTxB8rubrcq6EFMrgVNbwL WmtDbodUZF1HM542xyYtU3Snq31GuEF2TatmqoHiKFErsl8QWRqwugoMGL4MzIBqcvA9 6WaGx+OeBslDs/o2yT4+ak/gaWuAUL3c+5hvv4M0emTzBSbEIx8ZW/TJ05X0nT9rOcL0 hAYZYQ8DqcV8vYYpWFmppu7f6AM5zN1lkKLQkj9BK8OCQYuVHjOdtToyDpczLmUYIdm9 z2k9BWW5g4BZTT2cNbD+Brlry+moAiz8GCHJ1JobvmAy8LDLWrUs6npKvk+qv7pFsqA0 sVBA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id q74si457725wme.0.2021.11.03.06.26.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Nov 2021 06:26:06 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 1A3DQ6Aw020007 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 3 Nov 2021 14:26:06 +0100 Received: from [167.87.72.48] ([167.87.72.48]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 1A3DQ5Am022140; Wed, 3 Nov 2021 14:26:06 +0100 Subject: Re: [PATCH v1 1/1] Fix permissions when splitting rootfs folders across partitions. To: Felix Moessbauer , isar-users@googlegroups.com Cc: henning.schild@siemens.com, adriaan.schmidt@siemens.com References: <20211103125305.3021016-1-felix.moessbauer@siemens.com> From: Jan Kiszka Message-ID: <127b5e2e-617f-5934-e9d6-54a88664bf6c@siemens.com> Date: Wed, 3 Nov 2021 14:26:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211103125305.3021016-1-felix.moessbauer@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: v7+7t0xDeC3R On 03.11.21 13:53, Felix Moessbauer wrote: > This patches ensures that the file database containing the file and > folder usernames and permissions is always located relative to the > source and not to the appended rootfs-dir. > > Prior to this patch, the database was not found when using > -rootfs-dir in the WIC script, leading to erronous file > permissions and ownership. > > Signed-off-by: Felix Moessbauer > --- > scripts/lib/wic/plugins/source/rootfs.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/lib/wic/plugins/source/rootfs.py b/scripts/lib/wic/plugins/source/rootfs.py > index 96d940a..5ab771e 100644 > --- a/scripts/lib/wic/plugins/source/rootfs.py > +++ b/scripts/lib/wic/plugins/source/rootfs.py > @@ -95,7 +95,7 @@ class RootfsPlugin(SourcePlugin): > > part.rootfs_dir = cls.__get_rootfs_dir(rootfs_dir) > part.has_fstab = os.path.exists(os.path.join(part.rootfs_dir, "etc/fstab")) > - pseudo_dir = os.path.join(part.rootfs_dir, "../pseudo") > + pseudo_dir = os.path.join(krootfs_dir['ROOTFS_DIR'], "../pseudo") > if not os.path.lexists(pseudo_dir): > logger.warn("%s folder does not exist. " > "Usernames and permissions will be invalid " % pseudo_dir) > Upstream first: first OE, then Isar. At least submit to OE first. If it's urgent, we can still decide to apply here earlier. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux