Re: [PATCH v7 08/17] use bitbake function to generate mounting scripts

["'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>]

On Thu, 2026-06-25 at 17:36 +0200, Felix Moessbauer wrote:
> By introducing a bitbake python function (a code generator) to
> generate the mount shell code, we make it reusable within here
> documents where external shell functions cannot be called.
> 
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>  meta/classes-global/base.bbclass   | 18 +++++++++++
>  meta/classes-recipe/rootfs.bbclass | 49 ++++++++----------------------
>  2 files changed, 30 insertions(+), 37 deletions(-)
> 
> diff --git a/meta/classes-global/base.bbclass b/meta/classes-global/base.bbclass
> index d4dbbc3a..90e4525e 100644
> --- a/meta/classes-global/base.bbclass
> +++ b/meta/classes-global/base.bbclass
> @@ -379,6 +379,24 @@ def deb_list_beautify(d, varname):
>  # Helpers for privileged execution. Only the non-underscore functions
>  # shall be used outside of this class.
>  
> +def insert_isar_mounts(d, rootfs, mounts):
> +    lines = []
> +    for m in mounts.split():
> +        host, inner = m.split(':') if ':' in m else (m, m)
> +        inner_full = os.path.join(rootfs, inner[1:])
> +        lines.append('mkdir -p {}'.format(inner_full))
> +        lines.append('mount -o bind,private {} {}'.format(host, inner_full))
> +    return '\n'.join(lines)
> +
> +def insert_isar_umounts(d, rootfs, mounts):
> +    lines = []
> +    for m in mounts.split():
> +        host, inner = m.split(':') if ':' in m else (m, m)
> +        mp = '{}/{}'.format(rootfs, inner)
> +        lines.append('mountpoint -q {} && umount {}'.format(mp, mp))
> +        lines.append('[ -d {} ] && rmdir --ignore-fail-on-non-empty {}'.format(mp, mp))
> +    return '\n'.join(lines)
> +
>  def run_privileged_cmd(d):
>      cmd = 'sudo -E'
>      bb.debug(1, "privileged cmd: %s" % cmd)
> diff --git a/meta/classes-recipe/rootfs.bbclass b/meta/classes-recipe/rootfs.bbclass
> index 81f4d7b2..411df93f 100644
> --- a/meta/classes-recipe/rootfs.bbclass
> +++ b/meta/classes-recipe/rootfs.bbclass
> @@ -49,6 +49,16 @@ ROOTFS_PACKAGE_SUFFIX ?= "${PN}-${DISTRO}-${DISTRO_ARCH}"
>  # path to deploy stubbed versions of initrd update scripts during do_rootfs_install
>  ROOTFS_STUBS_DIR = "/usr/local/isar-sbin"
>  
> +# list of <outer>:<inner> or <outer> mount entries
> +ROOTFS_MOUNTS ??= "${REPO_ISAR_DIR}/${DISTRO}:/isar-apt ${WORKDIR}:/isar-work"
> +
> +python () {
> +    mounts = d.getVar('ROOTFS_MOUNTS', False)
> +    if d.getVar('ISAR_USE_CACHED_BASE_REPO') and not ':/base-apt' in mounts:
          ^
This always evaluates to true, as "0" is true.
Will be fixed on next iteration.

Felix


-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/12b83c4d1a9bcf27a29cfec446c41efdbe10dc4a.camel%40siemens.com.