From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Wed, 22 Apr 2026 12:28:30 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-wm1-f59.google.com (mail-wm1-f59.google.com [209.85.128.59]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 63MASSwQ001497 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 22 Apr 2026 12:28:28 +0200 Received: by mail-wm1-f59.google.com with SMTP id 5b1f17b1804b1-48a5952c635sf8269795e9.2 for ; Wed, 22 Apr 2026 03:28:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1776853703; cv=pass; d=google.com; s=arc-20240605; b=dvoE8Pwcxy9cEHbFJ8Q7CQ1fKyo5MCPZHlNRMSuk8HJVnKdiT56UQUxOnHPqaX4j2D qgMtWY3DhKN0nwYapXV/IjxLfwjgkUet2XiJHJ66mczIPOwtQPAh7EGSKZbEX40IWxoa uoklMXD2olHbMGhUXFSlT5aWFHoy5EHM8lP9y7tDtegKkh7xW53hE2mXL7VnvD0Iaymd AcDKLBWhYiTsw3byomLED5Y0/NXbKc37lk0UH4lqBER5YFSfk9zWMK3G1qGem1UZNk6c BIUjsdQkS386rIr9C4ihXN4WRzxMAof0sAjNA5CQrKWmMcc8AaU/21oN35r3oU6zBJ2/ utcQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:dkim-signature; bh=F47zjI7MT7DEiMngzdVHe2F3iQ151AcmAQAlJ8asieU=; fh=YfkE5TlprRJe60ypc9wj6eYVyU4Bb3SOe7ClAw4ZVsQ=; b=BCg8+hEz0igMJ1/T6orDQPl0twkhszFGfMHZQYB1uiKnzo+ondNfkAkDTo/Bw615HZ +LNX7NK7v3imOm6utkth5fos8+J0mujMBWr2u97RzM4Xr2OD/hcQL/uEnZ2+n9XLvMe5 kZZLs6wbQlYh6EbjBddOH/dqAckgSAORg0gM9mhb7pW7ELk+fJ483DT95ENTvuMTG7N1 FJ8rrkB8ftl3N21+e+zQtIXN1r+qv6fudqLCfVpciKDXOgGUjhLkg7t+t6AeyhBRyVl1 Esezgy49L/Oe2Twz0gYMEW3B97Yr8e5g3oOHNS8r/4xXlJZHesY4FnQWJWg3sPT/QKec 62+Q==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20251104; t=1776853703; x=1777458503; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:in-reply-to:from:content-language:references:to :subject:user-agent:mime-version:date:message-id:sender:from:to:cc :subject:date:message-id:reply-to; bh=F47zjI7MT7DEiMngzdVHe2F3iQ151AcmAQAlJ8asieU=; b=xUszW93+FR0I7G/9U03LWEdmcuG7WwoyUTLrmSu97R+fwxSFjwVgE+QSq77ePkzVqC EfRnFTWPGrGCV3MzwYRTWbpr097kLcKs8cbmb5DCGWX3LR2+rgAR2ldUSEUj7QT7pi8D tfWyV9uXhkcdcgexfwCk9e7vw3gmKwRjmgwkk2DbnihLkOpvDRaX+tN1LMdj1am1Wi+u IyQoVeaALE54ImyypjF23aF4QS+yyECCA5LhoRBXj/jVlmKqDgZpbzjWmaMyPSu7EAZp b6VI9XgmWJt5S05LwRjF2bb0A+mvCUGtoFkZZIDa3HKCi4WVOCduab+AAFrasYHEMEBu y81w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776853703; x=1777458503; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:in-reply-to :from:content-language:references:to:subject:user-agent:mime-version :date:message-id:x-beenthere:x-gm-message-state:sender:from:to:cc :subject:date:message-id:reply-to; bh=F47zjI7MT7DEiMngzdVHe2F3iQ151AcmAQAlJ8asieU=; b=BGJJD65HQcFULwb7eZcW4hNKc8wh8JdPrmB6OLt1peu0BGH+pvnMSUYzJjXWolcQfS 5FAUa1w43sNKNO8LVyv1etZplQFMfObwiamtBbTQojdKwkJJNkpr4hEllf9f4bFFowtJ dg9MqMmNY6VAda6kxt7xVGxkg+BAkOXE4KwdIDe5asJ7t0wyFpOJr3CaCmPrHLxxg23C 0XvHOL95l/qhvNlsfOdAgv6ygKJPO2gxnMWF+ksiGIW3SpVwWZYGMobC9zR86KB4Inyg 28YzeqV+yEsvmRz2Znyd+9f7To94eHf5bhxkXKb6mt1ETmixDHJ+vUePdp0+KTqPu9Iv PgDA== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AFNElJ+NPVNOXUk3ewktNE1DqPqEGu4cmoMarDyolV07XkFw9TMNC/Gd6LgzwE3P9tJ1K4I+DvM9@ilbers.de X-Gm-Message-State: AOJu0Yzds9/qcwDhmIBvxAMjfGyRhapFhlhefT/3D7IDNb6IG6WInNiz Pb/lZ9LvWF7ugDbZRjR8yQYvnndi7q5MtQHgSs4tt2lnlhuQodqj10j8 X-Received: by 2002:a05:600c:8909:b0:489:1b10:d896 with SMTP id 5b1f17b1804b1-4891b10dd45mr174968015e9.0.1776853702788; Wed, 22 Apr 2026 03:28:22 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="AYAyTiLn8VgOQbGtQ6nSW1/nD6cP3c6FP9znSmZNGhVfhCtJrQ==" Received: by 2002:a05:600c:5254:b0:483:7631:bef7 with SMTP id 5b1f17b1804b1-488f4b18c95ls56091545e9.2.-pod-prod-08-eu; Wed, 22 Apr 2026 03:28:21 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ8agvUcPBprhT7s5hRvJRCxXutCDUKOb/o1cklVEhsNPAdsGLH16FRKW49KPsyuverHXprWOQzpdtkZ@googlegroups.com X-Received: by 2002:a05:600c:4e4f:b0:488:ab37:b442 with SMTP id 5b1f17b1804b1-488fb793c6bmr322881315e9.28.1776853700875; Wed, 22 Apr 2026 03:28:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776853700; cv=none; d=google.com; s=arc-20240605; b=H7z42NulYB1tnbyrGMv9Pqgrz/5r3IKqtPqdjE1dlLHFOzkIsWPz2ynBbl6/kPvnE2 DCSj2AwNz31q1CYRF2qdjI8fh65gmnSd4fIEkMRMQUJT9M62drwN3uzVWiwQAiPstX0C RGr9gvFufSYYT2NpaAYIkxkzz2fPzcp7HlVZT0Ge1TAjWB3ARultkDa8hAChNQ6sbF46 P2RBmg4LTxnCEM0CNu4sHS5SsYIVEAiFXKDXU7dIkSzwy99iG1jF4rlbrIcNm5o4ev9g Y1UxEJWa2qN5pvFfl2ScQEEGP+/jP3IJ/yfX6oUwNFnW5dyKHfluyflASYXFBEHon94S 4MbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id; bh=Spd/Kvp6vXWOIBzIAAYibJocThHlrUiPi0WwTJVgkTA=; fh=byKKdcbJp0+UUfq7yDydjZvMiyS2ZBGGumi2piBKjbU=; b=WrWXeEVHy+BgPvXhYSD+dj9KCLlES/W6scn621JPlh6NI0CVwuDUkzBn+a3/Qh/C6r IAjOqg5KMI84M8+HIFzz4Xar/uWcbV778unS6uGtHdLlDyMZjOmtE6OrmFuUqqbW+5b8 ASYCoND70UouccHHf5jhkmngJ776xXzeG8+KiMrPx8Ua9r4kP+W1s0lOKYlilspijQLl TwpticjWDeXB+9yqzv6W/47oz8erP1CRWEFhLX1E34DXur3ZYsZx4K3look/xo4Itag/ 1lg0+erAo723J/MfefF6yllDk11irYNlmaEkfu7r0jwgFW6je9iQdLSY2ZTSSCNj08Kf eGHQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 5b1f17b1804b1-488fc122e82si3054375e9.0.2026.04.22.03.28.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Apr 2026 03:28:20 -0700 (PDT) Received-SPF: pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [192.168.178.148] ([88.130.203.42]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 63MASKgN001487 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Apr 2026 12:28:20 +0200 Message-ID: <12fb90b0-cd1a-429a-aac5-97111160b971@ilbers.de> Date: Wed, 22 Apr 2026 12:28:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] installer-add-rootfs: wait for full target image build via do_build To: Gourav Singh , isar-users@googlegroups.com References: <20260421172147.4077796-1-gouravsingh@siemens.com> Content-Language: en-US From: Zhihang Wei In-Reply-To: <20260421172147.4077796-1-gouravsingh@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: wzh@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: CXyYsfUrS9PM Applied to next, thanks. Zhihang On 4/21/26 19:21, 'Gourav Singh' via isar-users wrote: > Previously, the installer depended only on do_image_, which was > derived from IMAGE_DATA_POSTFIX (e.g. do_image_wic for wic.zst). This > created a hidden ordering assumption that the image type being installed > was also the last artifact to be built. > > This assumption breaks silently when target images include additional > build steps that run after the wic image, such as swupdate (.swu) > generation. In that case, the installer would start before all artifacts > were ready, missing files like the .swu image entirely. > > Replace the derived do_image_ dependency with do_build, which is > the natural synchronization point signaling that a recipe is fully done. > This guarantees the installer only starts after all target image > artifacts are produced, regardless of which features are enabled. > > As a result, the get_image_type() helper function is no longer needed > and is removed. > > Fixes: a7364ea ("installer-add-rootfs: build target image for image data postfix") > > Signed-off-by: Gourav Singh > --- > meta-isar/classes-recipe/installer-add-rootfs.bbclass | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/meta-isar/classes-recipe/installer-add-rootfs.bbclass b/meta-isar/classes-recipe/installer-add-rootfs.bbclass > index 69d87be8..111506df 100644 > --- a/meta-isar/classes-recipe/installer-add-rootfs.bbclass > +++ b/meta-isar/classes-recipe/installer-add-rootfs.bbclass > @@ -56,10 +56,6 @@ def get_mc_depends(d, task): > deps.append(f"mc:{installer_mc}:{installer_target_mc}:{image}:{task}") > return " ".join(deps) > > -def get_image_type(suffix): > - image_type = suffix.split(".")[0] > - return f"{image_type}" > - > python() { > entries = [] > > @@ -80,5 +76,5 @@ python() { > d.setVar("ROOTFS_ADDITIONAL_FILES", " ".join(entries)) > } > > -INSTALLER_TARGET_TASK ??="do_image_${@ get_image_type(d.getVar('IMAGE_DATA_POSTFIX'))}" > +INSTALLER_TARGET_TASK ??="do_build" > do_rootfs_install[mcdepends] += "${@ get_mc_depends(d, d.getVar('INSTALLER_TARGET_TASK'))}" > -- > 2.39.5 > -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/12fb90b0-cd1a-429a-aac5-97111160b971%40ilbers.de.