From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6621956091070644224 X-Received: by 2002:a25:b804:: with SMTP id v4-v6mr6183937ybj.79.1542619817588; Mon, 19 Nov 2018 01:30:17 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a25:180b:: with SMTP id 11-v6ls9975755yby.11.gmail; Mon, 19 Nov 2018 01:30:17 -0800 (PST) X-Google-Smtp-Source: AJdET5dsJMsj0oqoBTaD9Ifl1LwTXi5auBaaiN+NXrxjYbEukzgHAYZ9MSsaqqR8x5EK2+f9Znuf X-Received: by 2002:a25:f306:: with SMTP id c6-v6mr6342944ybs.84.1542619817336; Mon, 19 Nov 2018 01:30:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542619817; cv=none; d=google.com; s=arc-20160816; b=un0HuH20na5svaSGr9D3UOdMlaSv1QTSC3WDXkXsZ6VjjH1Z1ZFFwlCjaRuc8GGizY owInF5/nqlWBWClQxouYFJcE2yOVdM+7yKh6Bz9i4qVpSc9Ldg/ZEpUPNK306aTQUtwT 7p69eexpnmeZfD0MIlnnMOfvUKPZZYZGaRMigs4+S+LcWVESdjfFdINqaXm7iHICM1om +EWmNS5jcXtUP76jnAaO5EXxT0ZmKRF8le1WvOqkQxt17aWhg8eElQ+2KU4FhXH996lZ phLMdudSGSJbhQJt22DrK/hay6e4smf783wUUCIwX2Jbtceun6c7O0pJllMHqWTnmZy9 4qMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=uxO+Mt+gfSb5KHWJApIAY9WWv9D0CZUMoQlcLLs+b04=; b=K9SjGIM50UxTPxS7ODJA0SPSIssi7c8nmBKX8CAC0eRmtiDmc1sHalpNTLvveOB9wj aP4khpzseVJYpmLdyN/w2bj9YmKE8IQfN/1NEF9KTSLr81RvSRKHLp1izeK3kXFmefT1 dJsqJU2CqVH2pkRiqNOh4YDXagd4SGzFYvgcKTNEA4p8W8GKh6x3rWYSKU/EGgBTD81v ewzSCH5liueAhPSGV2N68DQS0m+LZ5FxonPfdQN5x+T+W/qyLGVwv0sSbdL36Oga9/Ye IQ6fHaLJpLIZuUImO4gzubJKGqbUr/oPsIYR/UR5VvbnWZ67F1Ds79zpb+Kvqtx8n8mL 3FpQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of cedric_hombourger@mentor.com designates 192.94.38.131 as permitted sender) smtp.mailfrom=Cedric_Hombourger@mentor.com Return-Path: Received: from relay1.mentorg.com (relay1.mentorg.com. [192.94.38.131]) by gmr-mx.google.com with ESMTPS id j21-v6si1712627ybg.5.2018.11.19.01.30.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Nov 2018 01:30:17 -0800 (PST) Received-SPF: pass (google.com: domain of cedric_hombourger@mentor.com designates 192.94.38.131 as permitted sender) client-ip=192.94.38.131; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of cedric_hombourger@mentor.com designates 192.94.38.131 as permitted sender) smtp.mailfrom=Cedric_Hombourger@mentor.com Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gOfsm-0007RQ-8G from Cedric_Hombourger@mentor.com ; Mon, 19 Nov 2018 01:30:16 -0800 Received: from svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 19 Nov 2018 09:30:10 +0000 Received: from svr-ies-mbx-02.mgc.mentorg.com ([fe80::a01f:51c9:5b6c:e0c]) by svr-ies-mbx-02.mgc.mentorg.com ([fe80::a01f:51c9:5b6c:e0c%22]) with mapi id 15.00.1320.000; Mon, 19 Nov 2018 09:30:10 +0000 From: "Hombourger, Cedric" To: Henning Schild CC: "isar-users@googlegroups.com" Subject: RE: [PATCH v5 0/2] rbind mounts for /dev and /sys Thread-Topic: [PATCH v5 0/2] rbind mounts for /dev and /sys Thread-Index: AQHUfoXPJYEl+E37ukOyq6u+XmSKDqVW1x6AgAAAOfA= Date: Mon, 19 Nov 2018 09:30:10 +0000 Message-ID: <134a3ad5f86644d5a4a6bf8e2bc0bdac@svr-ies-mbx-02.mgc.mentorg.com> References: <1542385896-879-3-git-send-email-Cedric_Hombourger@mentor.com> <1542466619-1689-1-git-send-email-Cedric_Hombourger@mentor.com> <20181119102725.10e8b13e@md1za8fc.ad001.siemens.net> In-Reply-To: <20181119102725.10e8b13e@md1za8fc.ad001.siemens.net> Accept-Language: en-US, en-IE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [137.202.0.90] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-TUID: MPXRyfc3X3Lp Hi Henning, Yes you read my mind, that's the next thing I'd like to do but wouldn't min= d getting this series in first to unblock some other work we have on-going = here I will go through your comments on the v5 series and respond/handle Cedric -----Original Message----- From: Henning Schild [mailto:henning.schild@siemens.com]=20 Sent: Monday, November 19, 2018 10:27 AM To: Hombourger, Cedric Cc: isar-users@googlegroups.com Subject: Re: [PATCH v5 0/2] rbind mounts for /dev and /sys Looking at how many places we have to change to get the mounts right, we mo= st likely want all that logic in a function. I recently had issues with an = imager class in a layer, that also carries mounting logic. But i guess that would be a cleanup step on top. Henning Am Sat, 17 Nov 2018 15:56:57 +0100 schrieb Cedric Hombourger : > Some of the packages I have been rebuilding within Isar require /sys=20 > mounted. For instance, golang-google-grpc runs some package tests=20 > after it builds itself and reads properties from /sys/class/dmi. >=20 > The initial version of this patch series only added a mount of /sys. > Henning then suggested that we follow Gentoo's guidelines for chroots.=20 > As such, this patch series is now mounting /dev and /sys as rbind=20 > mounts but leaves /proc as a regular procfs mount (like Gentoo does). >=20 > ChangeLog: >=20 > v5: cover letter added as suggested by Jan (private e-mail) > v4: limit rbind mounts to /dev and /sys, leave /proc as a regular=20 > mount v3: rbind mounts for /dev, /proc and /sys, add explicit umount=20 > calls v2: create /sys directory > v1: initial submission, simply mount /sys >=20 > Cedric Hombourger (2): > buildchroot+bootstrap: rbind mount for /dev > buildchroot: add sysfs mount since expected by some packages >=20 > meta/classes/buildchroot.bbclass | 5 ++++- > meta/classes/image.bbclass | 3 ++- > meta/classes/isar-bootstrap-helper.bbclass | 6 +++++- > meta/classes/isar-image.bbclass | 3 ++- > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 8 ++++++-- > 5 files changed, 19 insertions(+), 6 deletions(-) >=20