[PATCH] isar-image-base: Remove apt listing in IMAGE_PREINSTALL

[PATCH] isar-image-base: Remove apt listing in IMAGE_PREINSTALL

[Jan Kiszka]

debootstrap does that for us anyway.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta-isar/recipes-core/images/isar-image-base.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb
index a24aa3e..84001fd 100644
--- a/meta-isar/recipes-core/images/isar-image-base.bb
+++ b/meta-isar/recipes-core/images/isar-image-base.bb
@@ -18,8 +18,7 @@ inherit isar-bootstrap-helper
 
 DEPENDS += "${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}"
 
-IMAGE_PREINSTALL += "apt \
-                     dbus"
+IMAGE_PREINSTALL += "dbus"
 IMAGE_TRANSIENT_PACKAGES += "isar-cfg-localepurge"
 
 WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}"
-- 
2.16.4

Re: [PATCH] isar-image-base: Remove apt listing in IMAGE_PREINSTALL

[chombourger]

[-- Attachment #1.1: Type: text/plain, Size: 1116 bytes --]

Looks good to me. I would just change the subject to 'isar-image-base: 
remove "apt" from IMAGE_PREINSTALL'
(I found "listing" to be confusing/misleading until I looked at the patch)

Cedric

On Wednesday, August 22, 2018 at 9:55:45 PM UTC+2, Jan Kiszka wrote:
>
> debootstrap does that for us anyway. 
>
> Signed-off-by: Jan Kiszka <jan.k...@siemens.com <javascript:>> 
> --- 
>  meta-isar/recipes-core/images/isar-image-base.bb | 3 +-- 
>  1 file changed, 1 insertion(+), 2 deletions(-) 
>
> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb 
> b/meta-isar/recipes-core/images/isar-image-base.bb 
> index a24aa3e..84001fd 100644 
> --- a/meta-isar/recipes-core/images/isar-image-base.bb 
> +++ b/meta-isar/recipes-core/images/isar-image-base.bb 
> @@ -18,8 +18,7 @@ inherit isar-bootstrap-helper 
>   
>  DEPENDS += "${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}" 
>   
> -IMAGE_PREINSTALL += "apt \ 
> -                     dbus" 
> +IMAGE_PREINSTALL += "dbus" 
>  IMAGE_TRANSIENT_PACKAGES += "isar-cfg-localepurge" 
>   
>  WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}" 
> -- 
> 2.16.4 
>

[-- Attachment #1.2: Type: text/html, Size: 3788 bytes --]

Re: [PATCH] isar-image-base: Remove apt listing in IMAGE_PREINSTALL

[Maxim Yu. Osipov]

On 08/22/2018 10:55 PM, Jan Kiszka wrote:
> debootstrap does that for us anyway.

Applied to the 'next',

Thanks,
Maxim.

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>   meta-isar/recipes-core/images/isar-image-base.bb | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb
> index a24aa3e..84001fd 100644
> --- a/meta-isar/recipes-core/images/isar-image-base.bb
> +++ b/meta-isar/recipes-core/images/isar-image-base.bb
> @@ -18,8 +18,7 @@ inherit isar-bootstrap-helper
>   
>   DEPENDS += "${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}"
>   
> -IMAGE_PREINSTALL += "apt \
> -                     dbus"
> +IMAGE_PREINSTALL += "dbus"
>   IMAGE_TRANSIENT_PACKAGES += "isar-cfg-localepurge"
>   
>   WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}"
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov