From: Uladzimir Bely <ubely@ilbers.de>
To: Felix Moessbauer <felix.moessbauer@siemens.com>,
isar-users@googlegroups.com
Cc: adriaan.schmidt@siemens.com
Subject: Re: [PATCH v2 1/1] dpkg-prebuilt: ensure fetched packages are valid debian packages
Date: Mon, 01 Jul 2024 06:14:40 +0300 [thread overview]
Message-ID: <13aeedad3579dde906dd57511f850e446b868455.camel@ilbers.de> (raw)
In-Reply-To: <20240626142519.166207-1-felix.moessbauer@siemens.com>
On Wed, 2024-06-26 at 16:25 +0200, 'Felix Moessbauer' via isar-users
wrote:
> In case of dpkg-prebuilt, we need to check if the fetched packages
> are
> valid debian packages to only deploy valid ones into the sstate
> cache.
> Otherwise broken packages might end up in the cache and break future
> builds.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
> meta/classes/dpkg-prebuilt.bbclass | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/dpkg-prebuilt.bbclass b/meta/classes/dpkg-
> prebuilt.bbclass
> index 7092670b..a6187a07 100644
> --- a/meta/classes/dpkg-prebuilt.bbclass
> +++ b/meta/classes/dpkg-prebuilt.bbclass
> @@ -19,5 +19,8 @@ python do_unpack:prepend() {
> # also breaks inherited (from dpkg-base) dependency on sbuild_chroot
> do_dpkg_build[depends] = "${PN}:do_unpack"
> do_dpkg_build() {
> - true
> + # ensure all packages we got are valid debian packages
> + if [ -n "$(find ${WORKDIR} -maxdepth 1 -name '*.deb' -print -
> quit)" ]; then
> + find ${WORKDIR} -name '*.deb' | xargs -n1 dpkg -I
> + fi
> }
> --
> 2.39.2
>
Applied to next, thanks.
--
Best regards,
Uladzimir.
prev parent reply other threads:[~2024-07-01 3:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 14:25 Felix Moessbauer
2024-07-01 3:14 ` Uladzimir Bely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13aeedad3579dde906dd57511f850e446b868455.camel@ilbers.de \
--to=ubely@ilbers.de \
--cc=adriaan.schmidt@siemens.com \
--cc=felix.moessbauer@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox