Re: [PATCH 2/2] Revert "scripts/ci_build.sh: Set avocado-framework version to 96.0"

[Anton Mikanovich <amikan@ilbers.de>]

13.07.2022 16:12, Gylstorff Quirin wrote:
>
>
> On 7/13/22 07:19, Jan Kiszka wrote:
>> On 12.07.22 19:32, Anton Mikanovich wrote:
>>> No more Avocado version limit needed after switching to nrunner.
>>>
>>> This reverts commit 9aec8ba92912c682f7732b015f1919c5308f40a2.
>>> ---
>>>   scripts/ci_build.sh | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
>>> index fa7208c..debb386 100755
>>> --- a/scripts/ci_build.sh
>>> +++ b/scripts/ci_build.sh
>>> @@ -21,7 +21,7 @@ if ! command -v avocado > /dev/null; then
>>>       rm -rf /tmp/avocado_venv
>>>       virtualenv --python python3 /tmp/avocado_venv
>>>       source /tmp/avocado_venv/bin/activate
>>> -    pip install avocado-framework==96.0
>>> +    pip install avocado-framework
>>>   fi
>>>     # Get Avocado build tests path
>>
>> Bad idea as you can't predict future API changes of Avocado.
>>
>
> We should use a defined version for the avocado framework. This 
> simplifies the testing for new developers.
>
> As alternative we can use a requirements.txt.
>
> Quirin
>> Jan
>>
>
Ok. Let's just fix it to 97.0 for now and move next after manual testing 
only.