public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Koch, Stefan" <stefan-koch@siemens.com>
To: "Schmidt, Adriaan" <adriaan.schmidt@siemens.com>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "Kiszka, Jan" <jan.kiszka@siemens.com>
Subject: Re: [PATCH v3 2/3] linux-custom: use to_boolean when checking ISAR_CROSS_COMPILE
Date: Mon, 13 May 2024 07:45:05 +0000	[thread overview]
Message-ID: <1430838331def6acd59335e82bc8dc611c9412a6.camel@siemens.com> (raw)
In-Reply-To: <20240513041747.774666-3-adriaan.schmidt@siemens.com>

This is already included in:
[PATCH] linux-module: Support emulated module build with cross-compiled
kernel

On Mon, 2024-05-13 at 06:17 +0200, Adriaan Schmidt wrote:
> we've changed style/convention in Isar sometime during the review of
> the
> kbuild series, and this was missed.
> 
> Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
> ---
>  meta/recipes-kernel/linux/linux-custom.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc
> b/meta/recipes-kernel/linux/linux-custom.inc
> index 35c61187..53516ef3 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -97,7 +97,7 @@ KERNEL_NAME_PROVIDED ?= "${@
> d.getVar('BPN').partition('linux-')[2]}"
>  
>  # Determine cross-profile override
>  python() {
> -    if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and
> d.getVar("ISAR_CROSS_COMPILE", True) == "1" and "class-native" not in
> d.getVar("OVERRIDES", True).split(":"):
> +    if d.getVar("DISTRO_ARCH") != d.getVar("HOST_ARCH") and
> bb.utils.to_boolean(d.getVar("ISAR_CROSS_COMPILE")) and "class-
> native" not in d.getVar("OVERRIDES", True).split(":"):
>          d.appendVar("OVERRIDES", ":cross-profile")
>  }
>  

-- 
Stefan Koch
Siemens AG
www.siemens.com

  reply	other threads:[~2024-05-13  7:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-13  4:17 [PATCH v3 0/3] Kbuild follow-up Adriaan Schmidt
2024-05-13  4:17 ` [PATCH v3 1/3] module.inc: fix kbuild dependency Adriaan Schmidt
2024-05-13  5:24   ` Jan Kiszka
2024-05-13  7:02     ` Jan Kiszka
2024-05-13  4:17 ` [PATCH v3 2/3] linux-custom: use to_boolean when checking ISAR_CROSS_COMPILE Adriaan Schmidt
2024-05-13  7:45   ` Koch, Stefan [this message]
2024-05-13  9:06   ` Koch, Stefan
2024-05-13  4:17 ` [PATCH v3 3/3] kbuildtarget.bbclass: add missing license header Adriaan Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430838331def6acd59335e82bc8dc611c9412a6.camel@siemens.com \
    --to=stefan-koch@siemens.com \
    --cc=adriaan.schmidt@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox