Re: [PATCH] kas: Allow to define custom snapshot date

["'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>]

On 07.10.24 09:26, Moessbauer, Felix (FT RPD CED OES-DE) wrote:
> On Fri, 2024-10-04 at 12:20 +0200, 'Jan Kiszka' via isar-users wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Currently very useful for building constantly broken riscv via sid.
>> The
>> default value is actually a known-to-work one, taken from isar-cip-
>> core.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  kas/opt/Kconfig | 20 +++++++++++++++++++-
>>  1 file changed, 19 insertions(+), 1 deletion(-)
>>
>> diff --git a/kas/opt/Kconfig b/kas/opt/Kconfig
>> index 65482e3a..de7700f5 100644
>> --- a/kas/opt/Kconfig
>> +++ b/kas/opt/Kconfig
>> @@ -44,7 +44,25 @@ config USE_APT_SNAPSHOT
>>         bool "Use the distros snapshot mirror"
>>         depends on !MIRROR_DEBIAN && (DEBIAN_BUSTER ||
>> DEBIAN_BULLSEYE || DEBIAN_BOOKWORM || DEBIAN_TRIXIE || DEBIAN_SID ||
>> UBUNTU_FOCAL || UBUNTU_JAMMY)
>>         help
>> -               Use a snapshot mirror for the selected distribution.
>> The date is defined by ISAR_APT_SNAPSHOT_TIMESTAMP.
>> +               Use a snapshot mirror for the selected distribution.
>> +
>> +choice
>> +       prompt "Snapshot date"
>> +       depends on USE_APT_SNAPSHOT
>> +       default APT_SNAPSHOT_GIT_DATE
>> +
>> +config APT_SNAPSHOT_GIT_DATE
>> +       bool "Latest git commit"
>> +
>> +config APT_SNAPSHOT_CUSTOM_DATE
>> +       bool "Custom date"
> 
> The term "date" might be misleading here, as the value is a unix
> timestamp. IIRC Alexander wanted to send a similar patch to specify the
> apt snaptshot date in the upstream format (e.g. 20240702T082400Z),
> making it easier to read.
> 
> Either we rename that here to "Custom timestamp", or we wait for the
> patch of Alexander and adapt accordingly.

This just exposes an existing isar variable. I can clarify the
description of that string.

I also tried some ad-hoc conversion, but the inline python support of
bitbake is too limited for that (required "import datetime; ..."). We
need some helper in the base class for that.

Jan

-- 
Siemens AG, Technology
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/144150fd-3f1e-4182-bcf6-b3b55cea0f95%40siemens.com.