Re: [PATCH 4/7] meta-isar: jh7110-u-boot-spl-image: Fix native build

[Uladzimir Bely <ubely@ilbers.de>]

On Fri, 2023-10-06 at 08:00 +0200, Jan Kiszka wrote:
> On 06.10.23 07:52, Uladzimir Bely wrote:
> > On Thu, 2023-10-05 at 20:32 +0200, Jan Kiszka wrote:
> > > From: Jan Kiszka <jan.kiszka@siemens.com>
> > > 
> > > In general, recipes must not use HOST_ARCH because it does not
> > > account
> > > for ISAR_CROSS_COMPILE being enabled or disabled. This is encoded
> > > into
> > > BUILD_HOST_ARCH, though.
> > > 
> > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > > ---
> > >  .../jh7110-u-boot-spl-image/jh7110-u-boot-spl-image_0.1.bb     
> > > | 2
> > > +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/meta-isar/recipes-bsp/jh7110-u-boot-spl-
> > > image/jh7110-u-
> > > boot-spl-image_0.1.bb b/meta-isar/recipes-bsp/jh7110-u-boot-spl-
> > > image/jh7110-u-boot-spl-image_0.1.bb
> > > index dbce7c28..cd31c9ca 100644
> > > --- a/meta-isar/recipes-bsp/jh7110-u-boot-spl-image/jh7110-u-
> > > boot-
> > > spl-image_0.1.bb
> > > +++ b/meta-isar/recipes-bsp/jh7110-u-boot-spl-image/jh7110-u-
> > > boot-
> > > spl-image_0.1.bb
> > > @@ -12,7 +12,7 @@ DEPENDS = "jh7110-u-boot-spl-tool-native u-
> > > boot-
> > > starfive-visionfive2"
> > >  DEBIAN_BUILD_DEPENDS = "jh7110-u-boot-spl-tool:native, u-boot-
> > > starfive-visionfive2:${DISTRO_ARCH}"
> > >  
> > >  # this is a host tool
> > > -PACKAGE_ARCH = "${HOST_ARCH}"
> > > +PACKAGE_ARCH = "${BUILD_HOST_ARCH}"
> > >  
> > 
> > What do you think about renaming variable BUILD_HOST_ARCH to
> > BUILD_ARCH
> > in Isar? While it's not yet widely used in the recipes, it would
> > better
> > to do it earlier.
> > 
> > It is an internal Isar variable and renaming should not affect any
> > downstreams. Renaming  should make us a bit closer to OE, where
> > BUILD_ARCH has the same meaning.
> > 
> 
> I was also thinking about this, yes. Should I include such a patch in
> my
> series?
> 

Yes, please.
Actually, I've just applied patch1 from the series to 'next', so the
new patch could be first in series v2, so other patches would keep
their numbers. 

> Jan
> 
> > Additionally, it would fix the issue with sstate-cache and "-
> > native"
> > packages ( https://groups.google.com/g/isar-users/c/2TNQPOb0IXY ).
> > 
> > >  do_prepare_build[cleandirs] += "${S}/debian"
> > >  do_prepare_build(){
> > 
>