Re: [PATCH] linux-custom: skip linux-libc-dev deployment on downgrade

[Jan Kiszka <jan.kiszka@siemens.com>]

On 23.01.19 18:23, [ext] Henning Schild wrote:
> Ping
> 

Looks good to me - what scenarios did you test?

Jan

> Am Thu, 17 Jan 2019 14:03:42 +0100
> schrieb Henning Schild <henning.schild@siemens.com>:
> 
>> From: Henning Schild <henning.schild@siemens.com>
>>
>> A custom kernel usually deploys linux-libc-dev in the kernels version.
>> But some packages in the distribution depend on >= expected upstream
>> version of that package. If we deploy a linux-libc-dev in a lower
>> version, installing packages like build-essential will not be possible
>> anymore.
>> That is especially problematic since incremental builds will pull that
>> into our buildchroot and break package installation in there.
>>
>> If detecting a downgrade, do not deploy the package and issue a
>> warning.
>>
>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
>> ---
>>   meta/recipes-kernel/linux/files/build-kernel.sh | 7 +++++++
>>   meta/recipes-kernel/linux/linux-custom.inc      | 3 +++
>>   2 files changed, 10 insertions(+)
>>
>> diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh
>> b/meta/recipes-kernel/linux/files/build-kernel.sh index
>> dbd6162..e4a5d30 100644 ---
>> a/meta/recipes-kernel/linux/files/build-kernel.sh +++
>> b/meta/recipes-kernel/linux/files/build-kernel.sh @@ -122,3 +122,10
>> @@ rm -f linux-image-${PV}_${PV}-1_*.deb fakeroot dpkg-deb -b
>> ${REPACK_LINUX_HEADERS_DIR} \
>> linux-headers-${KERNEL_NAME}_${PV}-1_${KERNEL_NAME}.deb rm -f
>> linux-headers-${PV}_${PV}-1_*.deb +
>> +# linux-libc-dev causes dependency problems if we downgrade
>> +# remove it after the build so the downgraded version does not get
>> deployed +LINUX_LIBC_DEV_V=`dpkg-query --show --showformat
>> '${Version}' linux-libc-dev` +if dpkg --compare-versions
>> $LINUX_LIBC_DEV_V gt $PV; then
>> +	rm -f linux-libc-dev_${PV}*.deb
>> +fi
>> diff --git a/meta/recipes-kernel/linux/linux-custom.inc
>> b/meta/recipes-kernel/linux/linux-custom.inc index f33bb9d..ac37412
>> 100644 --- a/meta/recipes-kernel/linux/linux-custom.inc
>> +++ b/meta/recipes-kernel/linux/linux-custom.inc
>> @@ -62,4 +62,7 @@ dpkg_runbuild() {
>>   	export
>> KERNEL_HEADERS_DEBIAN_DEPENDS="${KERNEL_HEADERS_DEBIAN_DEPENDS}"
>>   	sudo -E chroot --userspec=$( id -u ):$( id -g )
>> ${BUILDCHROOT_DIR} ${PP}/build-kernel.sh ${PP}/${PPS} ${DISTRO_ARCH}
>> +	if [ ! -f ${WORKDIR}/linux-libc-dev_${PV}*.deb ]; then
>> +		bbwarn "Kernel downgrade detected, not deploying
>> linux-libc-dev"
>> +	fi
>>   }
> 

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux