From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6647450695491387392 X-Received: by 2002:a05:6000:114e:: with SMTP id d14mr282267wrx.5.1548264391596; Wed, 23 Jan 2019 09:26:31 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:b754:: with SMTP id h81ls13692wmf.7.canary-gmail; Wed, 23 Jan 2019 09:26:31 -0800 (PST) X-Google-Smtp-Source: ALg8bN71430Y0UimDG5tsRhJ/AZmgrM7zQWHSB5SHHWR73SudgDvuV0tyv6J9Eicrcw0bJ1nCnxV X-Received: by 2002:a1c:dc82:: with SMTP id t124mr328780wmg.0.1548264391015; Wed, 23 Jan 2019 09:26:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548264391; cv=none; d=google.com; s=arc-20160816; b=u2o82cheB/gupGY5lrPqXceAeHcFZmNvzq8VlZN8+L7KW1pZqtrmRExGm93Ge+e8ns qdGBOugqgxyFkeI7by1y84Ly79iKYjsPlyk2bGTaaxmJm7/rjluo6veMB2qagctf0vEE wy/P5D4ikVW3Dxq3WXtocJXzQbbDGGMmVzh3ccNHJPu3omTy3K4ujLnTsPaOlK5nYgeF LU+CAP51ZxnnqXvzebQ6a91RPXn2zYLsWMMf9epDImkx5n7boJSE4taybz2hZfUs0yYx uviMo3wsqalsEZUYZxqmEzfi6hy+KnC6Qt176fsn6Bt6cqffj2v2z/OrYGrt/JCbQyeU pCiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=RYGUflxq5rHt2Gljr9MuEdeV/Zsbi15WbnzBSlBknRY=; b=a6RGZyziK/kYBJ1IiPn7V1MDCOm7YSPHBOMuAO1rsr57kSViixPT/amLKle+bxf8v2 Tf5QxA0u/yu1vR3xLKdgRPVQWiqwZOOeIa+OGW7FQgI83a7iEqEPkHoulpBPI0kzkAkw wWvXrONpNh/kRE5ZgZpNyNCZ/cK8GEY1d7RELQtaqZXMyQipzLJUdd3nG+SQocisjk83 s7voMTlwJULG9DEzKv781lG2qNbrnBEvnp71/YYmufWzVBgbMXfPwvcpIlZSjHSDfvG8 mER5zI0z2nYqXgbbvj2KI5GXs5RMjz5HXi627ktdLVE1IArhefpv8aWbeJKQJ1wzS8NQ ivtw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id i11si325975wmb.2.2019.01.23.09.26.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Jan 2019 09:26:31 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x0NHQUUo000607 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 23 Jan 2019 18:26:30 +0100 Received: from [139.22.37.91] ([139.22.37.91]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x0NHQSJ2027623; Wed, 23 Jan 2019 18:26:29 +0100 Subject: Re: [PATCH] linux-custom: skip linux-libc-dev deployment on downgrade To: "[ext] Henning Schild" , isar-users References: <20190117130342.15743-1-henning.schild@siemens.com> <20190123182303.4795f660@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <14dc306a-4db0-a8d4-6839-a2369369f372@siemens.com> Date: Wed, 23 Jan 2019 18:26:08 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20190123182303.4795f660@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 78fZ3EqM4tUY On 23.01.19 18:23, [ext] Henning Schild wrote: > Ping > Looks good to me - what scenarios did you test? Jan > Am Thu, 17 Jan 2019 14:03:42 +0100 > schrieb Henning Schild : > >> From: Henning Schild >> >> A custom kernel usually deploys linux-libc-dev in the kernels version. >> But some packages in the distribution depend on >= expected upstream >> version of that package. If we deploy a linux-libc-dev in a lower >> version, installing packages like build-essential will not be possible >> anymore. >> That is especially problematic since incremental builds will pull that >> into our buildchroot and break package installation in there. >> >> If detecting a downgrade, do not deploy the package and issue a >> warning. >> >> Signed-off-by: Henning Schild >> --- >> meta/recipes-kernel/linux/files/build-kernel.sh | 7 +++++++ >> meta/recipes-kernel/linux/linux-custom.inc | 3 +++ >> 2 files changed, 10 insertions(+) >> >> diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh >> b/meta/recipes-kernel/linux/files/build-kernel.sh index >> dbd6162..e4a5d30 100644 --- >> a/meta/recipes-kernel/linux/files/build-kernel.sh +++ >> b/meta/recipes-kernel/linux/files/build-kernel.sh @@ -122,3 +122,10 >> @@ rm -f linux-image-${PV}_${PV}-1_*.deb fakeroot dpkg-deb -b >> ${REPACK_LINUX_HEADERS_DIR} \ >> linux-headers-${KERNEL_NAME}_${PV}-1_${KERNEL_NAME}.deb rm -f >> linux-headers-${PV}_${PV}-1_*.deb + >> +# linux-libc-dev causes dependency problems if we downgrade >> +# remove it after the build so the downgraded version does not get >> deployed +LINUX_LIBC_DEV_V=`dpkg-query --show --showformat >> '${Version}' linux-libc-dev` +if dpkg --compare-versions >> $LINUX_LIBC_DEV_V gt $PV; then >> + rm -f linux-libc-dev_${PV}*.deb >> +fi >> diff --git a/meta/recipes-kernel/linux/linux-custom.inc >> b/meta/recipes-kernel/linux/linux-custom.inc index f33bb9d..ac37412 >> 100644 --- a/meta/recipes-kernel/linux/linux-custom.inc >> +++ b/meta/recipes-kernel/linux/linux-custom.inc >> @@ -62,4 +62,7 @@ dpkg_runbuild() { >> export >> KERNEL_HEADERS_DEBIAN_DEPENDS="${KERNEL_HEADERS_DEBIAN_DEPENDS}" >> sudo -E chroot --userspec=$( id -u ):$( id -g ) >> ${BUILDCHROOT_DIR} ${PP}/build-kernel.sh ${PP}/${PPS} ${DISTRO_ARCH} >> + if [ ! -f ${WORKDIR}/linux-libc-dev_${PV}*.deb ]; then >> + bbwarn "Kernel downgrade detected, not deploying >> linux-libc-dev" >> + fi >> } > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux