From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6499063932287713280 X-Received: by 10.46.56.19 with SMTP id f19mr557142lja.33.1513270936697; Thu, 14 Dec 2017 09:02:16 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.4.83 with SMTP id 80ls795491lje.12.gmail; Thu, 14 Dec 2017 09:02:16 -0800 (PST) X-Google-Smtp-Source: ACJfBos4exEnohNZlEtCeQ55QBLhKLeVDeafsRJj5R3+0kaF8z8uf0c1owCiMNiDtZ/aKg4pdRAm X-Received: by 10.25.212.68 with SMTP id l65mr449219lfg.27.1513270935996; Thu, 14 Dec 2017 09:02:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513270935; cv=none; d=google.com; s=arc-20160816; b=b0bkZXM2uW1xruZ+H1/EnPngxlI5M5Z/T91B0QOQ6imIIU2Xs1Ghnf9DCN20WIeQm3 qsV2vGszMjyJpQmFDNmp1sBXuneAsymscMuaoroLP18S8NnY4C1YXTH77sFygI+YC+ce kIUvFs5++ni9sf2/ixjE+qJVDMfgqs+BpBzucKLDB7PDxwaHRWlJdP6et7j0tzTQQw2g 9fh6URbBwkea+ALRDVYPwmt7W8ytECZfzFW7TWvp2oIinSyNYdQCyJ/8skkepYN0rpMv uEYa7rzr2hOxLgVKzichL4Yz9MtFlqf29wkQXoqVxi4kPfSOjPBmg3J4tDcHMs4m45ad FvGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:references:in-reply-to:date:cc:to:from:subject :message-id:arc-authentication-results; bh=SN8zQmN/E807RMaJWvoQJq6pFPLAmSxUmGA8Cq7sbOQ=; b=r1nc+zMFrinI9cHBwEXRI5/aj+LzuLfR+gACOKsDXVOEzCFTRH2Y5pMYXjohTUL8cQ slAuiUmGpmK5mZwSd1oLXLroektlwNdqu92AsSwyxo25NzwmJuBGzBh9Zh5VkmLjauh8 KI7beXcHjXmmZQaVY01HSh0JozMs48KuVAiMK3mwZT5V4NdjiXwfBMpTw5fuzP31UZ/i XYwCqd51ggP8ZdM7JLgyyP/o4lBHoPm0ruRsSv2Fy0hMWlyWBqkeE/qQuF4e1xinJZpU VV92wM4IGVR6b5sgHYsglXX8y1QaHQTQ7xqICGtcKmOPQ7MnIro3rlTC5B1I1j2r2pdK 9zmg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id o75si454804lfc.2.2017.12.14.09.02.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Dec 2017 09:02:14 -0800 (PST) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) client-ip=212.18.0.9; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3yyKc61t85z1qsjx; Thu, 14 Dec 2017 18:02:14 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3yyKc61fHSz26T23; Thu, 14 Dec 2017 18:02:14 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id QLPQ3siqVP_R; Thu, 14 Dec 2017 18:02:13 +0100 (CET) X-Auth-Info: VXblkrEIns/plLsG+mfADR4MRjShyndkJa8lNUIsJQI= Received: from Orrorin.lan (ipservice-092-217-114-122.092.217.pools.vodafone-ip.de [92.217.114.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 14 Dec 2017 18:02:13 +0100 (CET) Message-ID: <1513270920.31110.62.camel@denx.de> Subject: Re: [RFC PATCH 0/1] Special debian depends entries From: Claudius Heine To: Henning Schild Cc: "[ext] claudius.heine.ext@siemens.com" , isar-users@googlegroups.com Date: Thu, 14 Dec 2017 18:02:00 +0100 In-Reply-To: <20171214172044.2eaf4180@mmd1pvb1c.ad001.siemens.net> References: <20171213160710.3610-1-claudius.heine.ext@siemens.com> <20171214144205.063a6c49@mmd1pvb1c.ad001.siemens.net> <1513260757.31110.23.camel@denx.de> <20171214153628.1b3d6d36@mmd1pvb1c.ad001.siemens.net> <1513263138.31110.37.camel@denx.de> <20171214172044.2eaf4180@mmd1pvb1c.ad001.siemens.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-X3oojnJA3AQ1Aknhbu+I" X-Mailer: Evolution 3.26.2 Mime-Version: 1.0 X-TUID: 4l8Y60D5oEkf --=-X3oojnJA3AQ1Aknhbu+I Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-12-14 at 17:20 +0100, Henning Schild wrote: > Am Thu, 14 Dec 2017 15:52:18 +0100 > schrieb Claudius Heine : >=20 > > On Thu, 2017-12-14 at 15:36 +0100, Henning Schild wrote: > > > Am Thu, 14 Dec 2017 15:12:37 +0100 > > > schrieb Claudius Heine : > > > =20 > > > > Hi Henning, > > > >=20 > > > > On Thu, 2017-12-14 at 14:42 +0100, Henning Schild wrote: =20 > > > > > Am Wed, 13 Dec 2017 17:07:09 +0100 > > > > > schrieb "[ext] claudius.heine.ext@siemens.com" > > > > > : > > > > > =20 > > > > > > From: Claudius Heine > > > > > >=20 > > > > > > Hi, > > > > > >=20 > > > > > > this patch is to start the discussion about how to > > > > > > implement > > > > > > the > > > > > > debian depends. > > > > > >=20 > > > > > > Instead of going the just 'echo ${DEBIAN_DEPENDS}' route, I > > > > > > chose > > > > > > to > > > > > > be backwards compatible. Another reason for this is also > > > > > > for > > > > > > the > > > > > > possible next feature where ISAR 'DEPENDS' or 'RDEPENDS' > > > > > > will > > > > > > be > > > > > > converted to the package specific 'DEBIAN_DEPENDS'. =20 > > > > >=20 > > > > > With the current nature of dpkg-raw DEPENDS and RDEPENDS make > > > > > no > > > > > sense. > > > > > Maybe some day the class will do more than just wrap stuff in > > > > > a > > > > > package, but at the moment i do not see that coming. > > > > > And even if that ever happened the class could take care of > > > > > turning > > > > > the > > > > > bitbake-list (R)DEPENDS into a Debian comma-seperated list. > > > > >=20 > > > > > I tried your code in a bash (not in Isar/bitbake etc.) and i > > > > > got > > > > > a > > > > > few > > > > > more commas that i would have expected. > > > > >=20 > > > > > 'libc, (>=3D, 2.16)', 'tar, |, bsdtar', systemd > > > > >=20 > > > > > Shell code is nasty, i think i do not even want to know why > > > > > it > > > > > worked for you or wether it would work in Isar with my build > > > > > env. =20 > > > >=20 > > > > I works in here because the ${DEBIAN_DEPENDS} is inserted by > > > > bitbake > > > > before any shell is executed. So in shell code for this example > > > > looks > > > > like this: > > > >=20 > > > > DEBIAN_DEPS=3D"$(for i in 'libc (>=3D 2.16)' 'tar | bsdtar' > > > > systemd;do > > > > echo $i,;done|tr '\n' ' '|sed 's/, *$//')" > > > >=20 > > > > If you try that out with your shell: > > > >=20 > > > > $ echo "$(for i in 'libc (>=3D 2.16)' 'tar | bsdtar' > > > > systemd;do > > > > echo > > > > $i,;done|tr '\n' ' '|sed 's/, *$//')" > > > > libc (>=3D 2.16), tar | bsdtar, systemd > > > >=20 > > > > It works correctly just like in bitbake. > > > >=20 > > > > DEBIAN_DEPENDS is not a shell variable but a bitbake one. > > > >=20 > > > > But I get your point that this is confusing and error-prone. > > > > Doing > > > > it > > > > with python might be easier. =20 > > >=20 > > > It is just one of multiple points. > > >=20 > > > Could you live with the simple solution of just taking the string > > > from > > > the recipe and requiring recipe-updates? =20 > >=20 > > I would rather not break backward compatibility. > >=20 > > I know that isar is not at a stage were a fancy idea like this one > > really matters, but for me this issue is currently not important > > enough to justify this breakage and the work to change all the > > recipes relying on the old behavior. >=20 > How many recipes are we talking about here 3-5 in your layer? Let us > please not make this about principle but just be pragmatic about it. > The change to the recipes is trivial! I will come over to your desk > and > help you with it, but only if you are doing the 15+ on my side ;). >=20 > Christian said he wants to be able to express versions and choices > and > does not care about compatibility. And so far i did not hear any > other > complaints. >=20 > To me it is the perfect time to take the issue seriously. Because now > we can still change the interface without making too many people > angry. >=20 > > So for me we either fix it in a compatible way, like my patch does, > > or > > don't bother and wait for a usecase where we cannot advice the user > > to > > just debianize the sources in some way. >=20 > No, Christian identified a bug that should be fixed. >=20 > You can always debianize sources, you could probably do everything > that > dpkg-raw is doing in a /debian instead of a /DEBIAN folder. But this > has nothing to do with whether, when, or how the bug at hand should > be > fixed. You haven't given any advantages to having a comma seperated list in the DEBIAN_DEPENDS yet. Ok, you don't like the shell code, fine. But if I invest the about same time that it takes to fixing all my 5 recipes into writing the same transformation I did in python and have a compatible fix for this issue, isn't that better than having an incompatible fix? For me its about pragmatism not about principles. Just fix the code at one place and not in many. :) Cheers, Claudius --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 Keyserver: hkp://pool.sks-keyservers.net --=-X3oojnJA3AQ1Aknhbu+I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAloyrogACgkQEXPLGZgI sVPEdA//XwTASSCcVxWHpU+xczfImtbltdk/eZylz3D2BMCCkTuXt6kEWVS6nB9v Qms1Q0PKn7f+/FAYf2l9JxkE7G/rBKLrGW6PjULmsVdJeS9Wa9pW4XqGgrnqMGml aqCelsXdJhaNfgQ/QV6a0z3AM2WVacgCGZMwrfCrXmgOr2sqpxj8pWmGUVcYatnz 8y16Y4JSndpYcRpJE3Hg6K8dRSHhFz/GuX0Di2CceyZGYgXQTDA9eADRhWLYBXGv MHwr7JZGj3N2wi/VE6rYilIxyfyqMP76MIHlJ+VPy7Q0GRwzLs4bTQn7ZRE+C6+G andvDwqOBhvw/tirfh+xQ3PZtmQKoAiU/NSEs9RbLBSnCjmb9rVju32MOLGn3F8m CW3kALI/8AAlRh2zS/kXNcjtynkXbeO3g9zevK70n5cH38uxmDk1F9l36tB3qlwZ 0UZM6Pd4+wHAxts3IVujJbxTS1V1CHgVkZD1W2oUQL/OsLy9EDpiMeRhqRUJf+mX rCZJgEm6ACk3SPQMn7k1m+SoWSIRLL7wHmHmloB1VKkBV+WnH5ltuaSmm5UHyOW4 UWom/pqE4hwVn2xHL5qTGEy1xL94Jpc/1NNKL4cYjclv6cmIA8+ULDYr1RTLGvbg im4VuAJLFTQS4mvgt8H0HULcXQrNrgtRJlbvfSK3Ik0fRJW4EWQ= =PNld -----END PGP SIGNATURE----- --=-X3oojnJA3AQ1Aknhbu+I--