[PATCH] linux: add "git" to KBUILD_DEPENDS

[PATCH] linux: add "git" to KBUILD_DEPENDS

[Cedric Hombourger]

Several build scripts from the kernel use "git" and in particular
scripts/setlocalversion. The latter is used to produce a version
string when we "make -s kernelrelease". My kernel builds would
sporadically fail with the PV check as the "+" sign appended by
kbuild would or would not be present in the "kernelrelease" output
if "git" was installed or not in the buildchroot. Get consistent
results by getting "git" installed into the buildchroot when we
build custom kernels.

Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
---
 meta/recipes-kernel/linux/linux-custom.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc
index 8438143..d75346e 100644
--- a/meta/recipes-kernel/linux/linux-custom.inc
+++ b/meta/recipes-kernel/linux/linux-custom.inc
@@ -24,7 +24,7 @@ inherit dpkg-base
 
 SRC_URI += "file://build-kernel.sh"
 
-KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc"
+KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc git"
 KERNEL_DEBIAN_DEPENDS ?= "initramfs-tools | linux-initramfs-tool, kmod, linux-base (>= 4.3~)"
 KERNEL_HEADERS_DEBIAN_DEPENDS ?= "libc6, libssl1.1"
 
-- 
2.11.0

Re: [PATCH] linux: add "git" to KBUILD_DEPENDS

[Jan Kiszka]

On 2018-08-26 11:10, Cedric Hombourger wrote:
> Several build scripts from the kernel use "git" and in particular
> scripts/setlocalversion. The latter is used to produce a version
> string when we "make -s kernelrelease". My kernel builds would
> sporadically fail with the PV check as the "+" sign appended by
> kbuild would or would not be present in the "kernelrelease" output
> if "git" was installed or not in the buildchroot. Get consistent
> results by getting "git" installed into the buildchroot when we
> build custom kernels.
> 
> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>   meta/recipes-kernel/linux/linux-custom.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc
> index 8438143..d75346e 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -24,7 +24,7 @@ inherit dpkg-base
>   
>   SRC_URI += "file://build-kernel.sh"
>   
> -KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc"
> +KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc git"
>   KERNEL_DEBIAN_DEPENDS ?= "initramfs-tools | linux-initramfs-tool, kmod, linux-base (>= 4.3~)"
>   KERNEL_HEADERS_DEBIAN_DEPENDS ?= "libc6, libssl1.1"
>   
> 

Makes sense to me.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH] linux: add "git" to KBUILD_DEPENDS

[Maxim Yu. Osipov]

On 08/26/2018 12:10 PM, Cedric Hombourger wrote:
> Several build scripts from the kernel use "git" and in particular
> scripts/setlocalversion. The latter is used to produce a version
> string when we "make -s kernelrelease". My kernel builds would
> sporadically fail with the PV check as the "+" sign appended by
> kbuild would or would not be present in the "kernelrelease" output
> if "git" was installed or not in the buildchroot. Get consistent
> results by getting "git" installed into the buildchroot when we
> build custom kernels.

Applied to the 'next'.

Thanks,
Maxim.

> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>   meta/recipes-kernel/linux/linux-custom.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc
> index 8438143..d75346e 100644
> --- a/meta/recipes-kernel/linux/linux-custom.inc
> +++ b/meta/recipes-kernel/linux/linux-custom.inc
> @@ -24,7 +24,7 @@ inherit dpkg-base
>   
>   SRC_URI += "file://build-kernel.sh"
>   
> -KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc"
> +KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc git"
>   KERNEL_DEBIAN_DEPENDS ?= "initramfs-tools | linux-initramfs-tool, kmod, linux-base (>= 4.3~)"
>   KERNEL_HEADERS_DEBIAN_DEPENDS ?= "libc6, libssl1.1"
>   
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov