Re: [PATCH 9/9] doc: Creation of local apt repo caching upstream Debian packages

[Claudius Heine <ch@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 3248 bytes --]

Hi Baurzhan,

Quoting Baurzhan Ismagulov (2018-10-04 11:03:11)
> On Tue, Oct 02, 2018 at 04:02:54PM +0200, Claudius Heine wrote:
> > > +# Uncomment this to enable use of cached base repository
> > > +#ISAR_USE_CACHED_BASE_REPO ?= "1"
> > 
> > No that doesn't make sense to me.
> > 
> > In my opinion its very important to not have such flags or commands. Caching
> > and reproducible builds should be the default operation, upgrading or
> > removing the cache should be an extra step.
> 
> The first step is to provide the mechanism which is usable manually or
> automatically. Defining policy and setting it as default is best done when the
> feature has been stabilized; I'd be reluctant to slap a new feature as default
> as soon as it is introduced. I'd suggest to address that in later steps. That
> said, the option doesn't take it away from you -- just set it to true in your
> configuration.

Ok, but then the machanism should be designed that way so that this
feature can be enabled all the time, and the build should work on the first run
with this setting enabled as well.

> > Also please avoid those binary settings like `ISAR_USE_CACHED_BASE_REPO`.
> > That just bad design because it leads to every tiny setting having an own
> > variable. Use FEATURE variables with entries like:
> > 
> > `ISAR_BUILD_FEATURE = "cross-build use-cache ..."`
> > 
> > Yes cross-builds should have been done like this as well IMO.
> 
> Hmm, that's an interesting idea. Conceptually, I fail to see any difference
> from boolean vars: One still has boolean feature names for every tiny setting.

If you do 'bitbake -e ..' you see all used features in one variable
instead of searching for many different variables all over to find what
features are enabled.

> I personally don't like features since they are difficult to remove from
> default settings.

I don't know if I understand you correctly here. I think you meant that
removing an entry from a variable is difficult. If that is the case, then
you could just do:

    ISAR_BUILD_FEATURE_remove = "use-cache"

As documented here: [1]

If you meant something different, please explain further.

Cheers,
Claudius

[1] https://www.yoctoproject.org/docs/current/bitbake-user-manual/bitbake-user-manual.html#removing-override-style-syntax

> 
> 
> With kind regards,
> Baurzhan.
> 
> -- 
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To post to this group, send email to isar-users@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/20181004090311.GA12890%40yssyq.m.ilbers.de.
> For more options, visit https://groups.google.com/d/optout.

--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

           PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
                             Keyserver: hkp://pool.sks-keyservers.net

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlu3VFwACgkQEXPLGZgI
sVOfdxAAgdOSOg1SJJtiuIBva41RvkcX2rSbEGbqBvIpmerOXt12vZkTmQaj0erf
otXh+tjZD5GeU0YvARBNh+dGu3T+NFDqzS6p7AYYz2jr8gdWiMSLpnMC4UyMWDer
1J3dt5KHp/iQZSx7RCyhljqzdn5LMtiETufH7FZ4LfgzykcNrnuILrfvl3k7fdjO
uVLfHFp44elFx2dNe34AR3JRCEJU4AkaeLoVu5vRU+vaOm7cavcxo7aJRDD3RcXD
WEExtJUQy0Xdpl2ZKSVRCPBmflloNtSo/vQF6kNIfAWwaKsIIMG7HYdJPV+JgOP+
REoxOYw+z3BdJCV5ZhNrFC2HOV9tPLJUlHZO8Si91tQHbXmsQvV4xvMbYQKnBfU9
zDMEBUacPNYAH5CnGMGj1zje3LicWSB0HMTDObD6m7fXRn7snCGoB2CO41fRlIhc
LZWtFszIgrrfDk+CRoWLEGj3EzCrYqx5ykuk7q8XpmGy7iL4JXrY9mw60oKkNBGM
j9gLIdRsTECfDHMRBYDKB34V+OKGb4F07nGY9Xk4kNTWKM00jvFIpXQKQm73xWL2
mFiSRhylQJs6aZ9F6iOd2yoBDvr54IwxpPb3u6Fs9/IyuKBuHe+KeMwTs/BOt/Lh
ZGBXq2N2v7qmNyW5LI97YFPyNY/k4Ff71ChUZq7O5zXGzO2ENKg=
=hSnV
-----END PGP SIGNATURE-----