From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6621956091070644224 X-Received: by 2002:a67:4e47:: with SMTP id c68mr4592341vsb.15.1542385910143; Fri, 16 Nov 2018 08:31:50 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ab0:64c9:: with SMTP id j9ls922715uaq.2.gmail; Fri, 16 Nov 2018 08:31:49 -0800 (PST) X-Google-Smtp-Source: AJdET5cJrgo6xmaDqEdy/4az3KWnwF1YyvJt+peT8I3WEZS+MygLH+PsUwQfbekj9+qqsTW4OAq9 X-Received: by 2002:ab0:6048:: with SMTP id o8mr4522053ual.23.1542385909927; Fri, 16 Nov 2018 08:31:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542385909; cv=none; d=google.com; s=arc-20160816; b=KpLvV3d01pfkpb8KVl7wfF/lGhK2w1ktVZkRrl7Wt076XtZPEQvdTkYfosdeWn0ZkE vQaZJ32vjxm7GqskEGuHKt3LY64QVat2c8bVxqjZ8ootKoMSq/RgZHnJx2F+hui/929R GLlU6BU4Fa5oq+eH8bRm0wJs3ixBQKykrUsRltq9sfEoNLssZ0fXOKzXsXoZM5BzTYNw 1b46IG/N58louaSQqv/wA36C564HU6IzyOb3Hiljs3j30KSQHPPpXXhgUFPPF34Aa9HI dOS+mla5CULywoIWTu/xZVOubpBX8b0sou6I2T0crLRNKIXQ6VG5bNKPMT4ICidag4Zk tkcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=A52E6cY5ylUdEMPpHGa45UUj7P01ey6ClusZyn4REzA=; b=VYUSV1knd8K/sKpf4hwlGc2LXbU1HOC3SarmQKPwdrQ2ZH2zlGiB6xmD1GFF65VwEE 4vB9YhzveJZL264R0c6uNu5YPQvjk6QNaM+zChZVf990dI0UmnbSUcaWlJGvZwuXFOd1 BFcnAih97lQD8giivPmHb/7o7COpQSv4dXE0xQUHDgFQANBFncZvfQn7JqIvrsLQsXfK Sn1BWmfhG3dsTshdhEBwHvYM9kzDI4Mi3WiFQ+outTw2WrTGvHU1s54mc7sUiRH59BdI cAEC0pJjSRiqTt2TJlEQGUlCA10H2MYZsKLll8nq4YTpF4o1vc8ur97Ou6IkTSnDTaKX K4wQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of cedric_hombourger@mentor.com designates 192.94.38.131 as permitted sender) smtp.mailfrom=Cedric_Hombourger@mentor.com Return-Path: Received: from relay1.mentorg.com (relay1.mentorg.com. [192.94.38.131]) by gmr-mx.google.com with ESMTPS id 187si1254861vkc.1.2018.11.16.08.31.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 08:31:49 -0800 (PST) Received-SPF: pass (google.com: domain of cedric_hombourger@mentor.com designates 192.94.38.131 as permitted sender) client-ip=192.94.38.131; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of cedric_hombourger@mentor.com designates 192.94.38.131 as permitted sender) smtp.mailfrom=Cedric_Hombourger@mentor.com Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-02.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gNh24-0001ZK-Ju from Cedric_Hombourger@mentor.com for isar-users@googlegroups.com; Fri, 16 Nov 2018 08:31:48 -0800 Received: from FRG-W10-HOMBOUR.world.mentorg.com (137.202.0.90) by svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Fri, 16 Nov 2018 16:31:43 +0000 From: Cedric Hombourger To: CC: Cedric Hombourger Subject: [PATCH v4 1/2] buildchroot+bootstrap: rbind mount for /dev Date: Fri, 16 Nov 2018 08:31:34 -0800 Message-ID: <1542385896-879-1-git-send-email-Cedric_Hombourger@mentor.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) To svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) X-TUID: xIYIHc/NtZSH Bind mount the entire hierarchy for /dev as recommended in Gentoo's chroot setup guide. Suggested-by: Henning Schild Signed-off-by: Cedric Hombourger --- meta/classes/buildchroot.bbclass | 3 ++- meta/classes/image.bbclass | 2 +- meta/classes/isar-bootstrap-helper.bbclass | 3 ++- meta/classes/isar-image.bbclass | 2 +- meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 +++-- 5 files changed, 9 insertions(+), 6 deletions(-) diff --git a/meta/classes/buildchroot.bbclass b/meta/classes/buildchroot.bbclass index 34b7f59..a8964c6 100644 --- a/meta/classes/buildchroot.bbclass +++ b/meta/classes/buildchroot.bbclass @@ -27,7 +27,8 @@ buildchroot_do_mounts() { if ! grep -q ${BUILDCHROOT_DIR}/isar-apt /proc/mounts; then mount --bind ${REPO_ISAR_DIR}/${DISTRO} ${BUILDCHROOT_DIR}/isar-apt mount --bind ${DL_DIR} ${BUILDCHROOT_DIR}/downloads - mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${BUILDCHROOT_DIR}/dev + mount --rbind /dev ${BUILDCHROOT_DIR}/dev + mount --make-rslave ${BUILDCHROOT_DIR}/dev mount -t proc none ${BUILDCHROOT_DIR}/proc fi diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index d033cf5..01e045d 100644 --- a/meta/classes/image.bbclass +++ b/meta/classes/image.bbclass @@ -108,7 +108,7 @@ do_populate_sdk() { # Purge apt cache to make image slimmer sudo rm -rf ${SDKCHROOT_DIR}/rootfs/var/cache/apt/* - sudo umount ${SDKCHROOT_DIR}/rootfs/dev || true + sudo umount -R ${SDKCHROOT_DIR}/rootfs/dev || true sudo umount ${SDKCHROOT_DIR}/rootfs/proc || true # Create SDK archive diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass index e6a46ce..1d3e5f6 100644 --- a/meta/classes/isar-bootstrap-helper.bbclass +++ b/meta/classes/isar-bootstrap-helper.bbclass @@ -103,7 +103,8 @@ setup_root_file_system() { sudo mount --bind ${REPO_BASE_DIR} ${ROOTFSDIR}/base-apt fi - sudo mount -t devtmpfs -o mode=0755,nosuid devtmpfs $ROOTFSDIR/dev + sudo mount --rbind /dev ${ROOTFSDIR}/dev + sudo mount --make-rslave ${ROOTFSDIR}/dev sudo mount -t proc none $ROOTFSDIR/proc # Refresh /etc/resolv.conf diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass index e0508be..703b3e7 100644 --- a/meta/classes/isar-image.bbclass +++ b/meta/classes/isar-image.bbclass @@ -59,7 +59,7 @@ isar_image_cleanup() { -maxdepth 1 -name 'qemu-*-static' -type f -delete sudo umount -l ${IMAGE_ROOTFS}/isar-apt sudo rmdir ${IMAGE_ROOTFS}/isar-apt - sudo umount -l ${IMAGE_ROOTFS}/dev + sudo umount -R -l ${IMAGE_ROOTFS}/dev sudo umount -l ${IMAGE_ROOTFS}/proc sudo rm -f "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf" } diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index 21454b0..dfd649e 100644 --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -183,7 +183,7 @@ isar_bootstrap() { set -e if [ ! -e "${DEPLOY_ISAR_BOOTSTRAP}" ]; then if [ -e "${ROOTFSDIR}" ]; then - umount -l "${ROOTFSDIR}/dev" || true + umount -R -l "${ROOTFSDIR}/dev" || true umount -l "${ROOTFSDIR}/proc" || true rm -rf "${ROOTFSDIR}" fi @@ -243,7 +243,8 @@ isar_bootstrap() { "${ROOTFSDIR}/chroot-setup.sh" "setup" "${ROOTFSDIR}" # update APT - mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${ROOTFSDIR}/dev + mount --rbind /dev ${BUILDCHROOT_DIR}/dev + mount --make-rslave ${BUILDCHROOT_DIR}/dev mount -t proc none ${ROOTFSDIR}/proc export DEBIAN_FRONTEND=noninteractive -- 2.11.0