public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Cedric Hombourger <Cedric_Hombourger@mentor.com>
To: <isar-users@googlegroups.com>
Cc: Cedric Hombourger <Cedric_Hombourger@mentor.com>
Subject: [PATCH v6 2/2] buildchroot: add sysfs mount since expected by some packages
Date: Tue, 20 Nov 2018 13:40:58 +0100	[thread overview]
Message-ID: <1542717658-157-3-git-send-email-Cedric_Hombourger@mentor.com> (raw)
In-Reply-To: <1542717658-157-1-git-send-email-Cedric_Hombourger@mentor.com>

Some packages look for /sys when they configure, build or test themselves (for
instance golang-google-grpc).

Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
---
 meta/classes/buildchroot.bbclass                    | 2 ++
 meta/classes/image.bbclass                          | 1 +
 meta/classes/isar-bootstrap-helper.bbclass          | 2 ++
 meta/classes/isar-image.bbclass                     | 1 +
 meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 3 +++
 5 files changed, 9 insertions(+)

diff --git a/meta/classes/buildchroot.bbclass b/meta/classes/buildchroot.bbclass
index a8964c6..0d4ff4e 100644
--- a/meta/classes/buildchroot.bbclass
+++ b/meta/classes/buildchroot.bbclass
@@ -30,6 +30,8 @@ buildchroot_do_mounts() {
             mount --rbind /dev ${BUILDCHROOT_DIR}/dev
             mount --make-rslave ${BUILDCHROOT_DIR}/dev
             mount -t proc none ${BUILDCHROOT_DIR}/proc
+            mount --rbind /sys ${BUILDCHROOT_DIR}/sys
+            mount --make-rslave ${BUILDCHROOT_DIR}/sys
         fi
 
         # Refresh /etc/resolv.conf at this chance
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 01e045d..d8fbfd5 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -110,6 +110,7 @@ do_populate_sdk() {
 
     sudo umount -R ${SDKCHROOT_DIR}/rootfs/dev || true
     sudo umount ${SDKCHROOT_DIR}/rootfs/proc || true
+    sudo umount -R ${SDKCHROOT_DIR}/rootfs/sys || true
 
     # Create SDK archive
     sudo tar -C ${SDKCHROOT_DIR} --transform="s|^rootfs|sdk-${DISTRO}-${DISTRO_ARCH}|" \
diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass
index 1d3e5f6..d77690f 100644
--- a/meta/classes/isar-bootstrap-helper.bbclass
+++ b/meta/classes/isar-bootstrap-helper.bbclass
@@ -106,6 +106,8 @@ setup_root_file_system() {
     sudo mount --rbind /dev ${ROOTFSDIR}/dev
     sudo mount --make-rslave ${ROOTFSDIR}/dev
     sudo mount -t proc none $ROOTFSDIR/proc
+    sudo mount --rbind /sys ${ROOTFSDIR}/sys
+    sudo mount --make-rslave ${ROOTFSDIR}/sys
 
     # Refresh /etc/resolv.conf
     sudo cp -L /etc/resolv.conf ${ROOTFSDIR}/etc
diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass
index 703b3e7..7aaaecb 100644
--- a/meta/classes/isar-image.bbclass
+++ b/meta/classes/isar-image.bbclass
@@ -61,6 +61,7 @@ isar_image_cleanup() {
     sudo rmdir ${IMAGE_ROOTFS}/isar-apt
     sudo umount -R -l ${IMAGE_ROOTFS}/dev
     sudo umount -l ${IMAGE_ROOTFS}/proc
+    sudo umount -R -l ${IMAGE_ROOTFS}/sys
     sudo rm -f "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf"
 }
 
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index dfd649e..3f7910f 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -185,6 +185,7 @@ isar_bootstrap() {
             if [ -e "${ROOTFSDIR}" ]; then
                umount -R -l "${ROOTFSDIR}/dev" || true
                umount -l "${ROOTFSDIR}/proc" || true
+               umount -R -l "${ROOTFSDIR}/sys" || true
                rm -rf "${ROOTFSDIR}"
             fi
             if [ ${IS_HOST} ]; then
@@ -246,6 +247,8 @@ isar_bootstrap() {
             mount --rbind /dev ${BUILDCHROOT_DIR}/dev
             mount --make-rslave ${BUILDCHROOT_DIR}/dev
             mount -t proc none ${ROOTFSDIR}/proc
+            mount --rbind /sys ${BUILDCHROOT_DIR}/sys
+            mount --make-rslave ${BUILDCHROOT_DIR}/sys
 
             export DEBIAN_FRONTEND=noninteractive
             chroot "${ROOTFSDIR}" /usr/bin/apt-get update -y
-- 
2.7.4


  parent reply	other threads:[~2018-11-20 12:42 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 20:11 [PATCH] " Cedric Hombourger
2018-11-10  7:15 ` [PATCH v2] " Cedric Hombourger
2018-11-12  9:31   ` Henning Schild
2018-11-13  4:59     ` [PATCH v3 1/2] buildchroot+bootstrap: use rbinds for /dev and /proc Cedric Hombourger
2018-11-13  4:59       ` [PATCH v3 2/2] buildchroot: add sysfs mount since expected by some packages Cedric Hombourger
2018-11-13 10:43         ` chombourger
2018-11-13 10:59           ` Jan Kiszka
2018-11-13 12:07         ` Henning Schild
2018-11-13 12:37           ` Hombourger, Cedric
2018-11-13 12:59             ` Jan Kiszka
2018-11-14  7:44         ` Henning Schild
2018-11-16 16:29           ` chombourger
2018-11-16 16:31             ` [PATCH v4 1/2] buildchroot+bootstrap: rbind mount for /dev Cedric Hombourger
2018-11-16 16:31               ` [PATCH v3 1/2] buildchroot+bootstrap: use rbinds for /dev and /proc Cedric Hombourger
2018-11-16 16:31               ` [PATCH v4 2/2] buildchroot: add sysfs mount since expected by some packages Cedric Hombourger
2018-11-17 14:56                 ` [PATCH v5 0/2] rbind mounts for /dev and /sys Cedric Hombourger
2018-11-17 14:56                   ` [PATCH v5 1/2] buildchroot+bootstrap: rbind mount for /dev Cedric Hombourger
2018-11-19  9:25                     ` Henning Schild
2018-11-20 12:36                       ` chombourger
2018-11-17 14:56                   ` [PATCH v5 2/2] buildchroot: add sysfs mount since expected by some packages Cedric Hombourger
2018-11-19  9:24                     ` Henning Schild
2018-11-20 12:40                       ` [PATCH v6 0/2] rbind mounts for /dev and /sys Cedric Hombourger
2018-11-20 12:40                         ` [PATCH v6 1/2] buildchroot+bootstrap: rbind mount for /dev Cedric Hombourger
2018-11-20 12:40                         ` Cedric Hombourger [this message]
2018-11-22 16:08                           ` [PATCH v6 2/2] buildchroot: add sysfs mount since expected by some packages chombourger
2018-11-23 14:13                         ` [PATCH v6 0/2] rbind mounts for /dev and /sys Maxim Yu. Osipov
2018-11-27 14:45                         ` Maxim Yu. Osipov
2018-11-27 14:48                           ` Hombourger, Cedric
2018-11-29  8:22                             ` Maxim Yu. Osipov
2018-11-29  8:28                               ` Hombourger, Cedric
2018-11-29  8:48                                 ` Maxim Yu. Osipov
2018-11-29 10:00                                 ` Baurzhan Ismagulov
2018-11-29  9:54                             ` Henning Schild
2018-11-19  9:27                   ` [PATCH v5 " Henning Schild
2018-11-19  9:30                     ` Hombourger, Cedric
2018-11-13 12:06       ` [PATCH v3 1/2] buildchroot+bootstrap: use rbinds for /dev and /proc Henning Schild
2018-11-12  9:46   ` [PATCH v2] buildchroot: add sysfs mount since expected by some packages Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1542717658-157-3-git-send-email-Cedric_Hombourger@mentor.com \
    --to=cedric_hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox