Re: [PATCH v2] meta: Add targz image class

[Harald Seiler <hws@denx.de>]

Hello Maxim,

On Fri, 2018-11-23 at 10:32 +0300, Maxim Yu. Osipov wrote:
> Hi Harald,
> 
> Could you please answer to Cedric's email (see below)?

It didn't show up in my mail client for some reason, sorry ...

> Kind regards,
> Maxim.
> 
> On 11/20/18 4:14 PM, chombourger@gmail.com wrote:>
> >
> > On Tuesday, November 20, 2018 at 2:07:35 PM UTC+1, Harald Seiler wrote:
> >
> >      > How will we test that?
> >
> >     The final tar could be checked agains the rootfs tree generated
> >     during the build using:
> >
> >              tar --compare --file=archive-file.tar -C /some/where/
> >
> >     I am not sure if this is worth it though, as this will always work
> >     unless tar itself made a mistake ... I think the recipe is trivial
> >     enough that this check can be omitted.
> >
> >
> > I wonder if Jan was instead asking how would be have this feature
> > tested? possibly from a CI perspective?
> >
> 

That is what I was referring to ... I don't see much to be tested except
having one ci target build an image with this class and the compare test.

I think we would need to add a new multiconf target for this?

> 
> On 11/20/18 4:19 PM, Harald Seiler wrote:
> > Signed-off-by: Harald Seiler <hws@denx.de>
> > ---
> >   meta/classes/targz-img.bbclass | 15 +++++++++++++++
> >   1 file changed, 15 insertions(+)
> >   create mode 100644 meta/classes/targz-img.bbclass
> > 
> > diff --git a/meta/classes/targz-img.bbclass b/meta/classes/targz-img.bbclass
> > new file mode 100644
> > index 0000000..cce8ded
> > --- /dev/null
> > +++ b/meta/classes/targz-img.bbclass
> > @@ -0,0 +1,15 @@
> > +# This software is a part of ISAR.
> > +# Copyright (c) Siemens AG, 2018
> > +#
> > +# SPDX-License-Identifier: MIT
> > +
> > +TARGZ_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${IMAGE_FULLNAME}.tar.gz"
> > +
> > +do_targz_image[stamp-extra-info] = "${DISTRO}-${MACHINE}"
> > +
> > +do_targz_image() {
> > +    rm -f ${TARGZ_IMAGE_FILE}
> > +    sudo tar -cvzf ${TARGZ_IMAGE_FILE} -C ${IMAGE_ROOTFS} .
> > +}
> > +
> > +addtask targz_image before do_build after do_rootfs
> > 
> 

-- 
Harald

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-62  Fax: +49-8142-66989-80   Email: hws@denx.de