From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6625908871596605440 X-Received: by 2002:a50:b7bc:: with SMTP id h57mr844007ede.5.1542973110947; Fri, 23 Nov 2018 03:38:30 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:9177:: with SMTP id f52ls3712463eda.2.gmail; Fri, 23 Nov 2018 03:38:30 -0800 (PST) X-Google-Smtp-Source: AFSGD/XZa7XInbJ/N5WmxEa1Q9rWaHZutB7y6F+vr2QHKdtCNtdjsREtL8QYA0ly6Taeo4W+72Z4 X-Received: by 2002:a50:b4a1:: with SMTP id w30mr3118767edd.2.1542973110523; Fri, 23 Nov 2018 03:38:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542973110; cv=none; d=google.com; s=arc-20160816; b=DDn7qe9jpM2Wi9M9Wi4ibZRsXBH8FzryrO6ka86hLRqqbVIm4S+OrTY3gSKjL92pfq 3FnJ+7FqScYxHk3cDCJ77pKc2ANZE3K/Ddg/g3dIi6PMbX+dfYZdhzHN9JY9h5vI7SC3 d9wm8wg4WkB7bOOrEJD/LwhDfUz5u8sff4qkMrciwiBtsYSQgzS9MVN0QO2wLM8jw9jy cCUWNNHO1JoGHUXzKD86jTYoVQB6Zfqq49yraPbY2d/YJgz8c8E8yro3q+JvBn4wvs25 CxpYo0ENmhyzUxPW7/UAQKkk8i+977u8sXKQgVdaF6HtvtavLWCTvZoy/psxC5Ptk+c+ XGiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to:date :to:from:subject:message-id; bh=tR86HSeQdbRyEtHLf6LDwwcDDgUFMyoy2DjklF2xUAg=; b=tgb3Vwa3crcoLsmvzB0VVhhs6/FfdrtO5/p800avwRMvyOotBgNtnZPxBaSltEnVHT rFvKu7WpeCY039vX09o0/0Fjw6r9/Ajp7aEi90SlZpbKI2YyJDe8Ks/DFWL1jvXxu1WK SptZdbeFY83vFpRJ+kI+Tvip4okEsps5t5LULggjkWdyV6MsWiXcCeaDQ9ftoc/OXl9+ MiMnENhRt+np8cLFHtM40cpJ4Z0ZYvBbuv8HvLRICEnoYQiJZ5Z3GbZc2Ih/lG2xQoId u/JCp65Feo8Abud0Ws+Jbftfg5/jOZrxxoRuaDUl3yX34r+M16GJMZ/xCX8USceKi27T 4JIA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of hws@denx.de) smtp.mailfrom=hws@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id k25si605504edd.1.2018.11.23.03.38.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Nov 2018 03:38:30 -0800 (PST) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of hws@denx.de) client-ip=212.18.0.9; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of hws@denx.de) smtp.mailfrom=hws@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 431Z7p1wgBz1r01q; Fri, 23 Nov 2018 12:38:30 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 431Z7p1m4Kz1qtfT; Fri, 23 Nov 2018 12:38:30 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id eX26b5vU29FL; Fri, 23 Nov 2018 12:38:29 +0100 (CET) X-Auth-Info: TUBWJfmLhzn8Cp51FxrKTWaKggvL3jwIlUCQhIAwcSA= Received: from elite.denx.de (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 23 Nov 2018 12:38:29 +0100 (CET) Message-ID: <1542973109.2564.59.camel@denx.de> Subject: Re: [PATCH v2] meta: Add targz image class From: Harald Seiler To: "Maxim Yu. Osipov" , isar-users@googlegroups.com Date: Fri, 23 Nov 2018 12:38:29 +0100 In-Reply-To: <5b838cf5-cddc-57d4-6833-a9a3aa659a2f@ilbers.de> References: <20181120135119.119185af@md1za8fc.ad001.siemens.net> <0a84c12f027ce7691f78e99c26c019473ef74300.camel@denx.de> <5b838cf5-cddc-57d4-6833-a9a3aa659a2f@ilbers.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 (3.26.6-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUID: a5W7hFqBsAFc Hello Maxim, On Fri, 2018-11-23 at 10:32 +0300, Maxim Yu. Osipov wrote: > Hi Harald, > > Could you please answer to Cedric's email (see below)? It didn't show up in my mail client for some reason, sorry ... > Kind regards, > Maxim. > > On 11/20/18 4:14 PM, chombourger@gmail.com wrote:> > > > > On Tuesday, November 20, 2018 at 2:07:35 PM UTC+1, Harald Seiler wrote: > > > > > How will we test that? > > > > The final tar could be checked agains the rootfs tree generated > > during the build using: > > > > tar --compare --file=archive-file.tar -C /some/where/ > > > > I am not sure if this is worth it though, as this will always work > > unless tar itself made a mistake ... I think the recipe is trivial > > enough that this check can be omitted. > > > > > > I wonder if Jan was instead asking how would be have this feature > > tested? possibly from a CI perspective? > > > That is what I was referring to ... I don't see much to be tested except having one ci target build an image with this class and the compare test. I think we would need to add a new multiconf target for this? > > On 11/20/18 4:19 PM, Harald Seiler wrote: > > Signed-off-by: Harald Seiler > > --- > > meta/classes/targz-img.bbclass | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > create mode 100644 meta/classes/targz-img.bbclass > > > > diff --git a/meta/classes/targz-img.bbclass b/meta/classes/targz-img.bbclass > > new file mode 100644 > > index 0000000..cce8ded > > --- /dev/null > > +++ b/meta/classes/targz-img.bbclass > > @@ -0,0 +1,15 @@ > > +# This software is a part of ISAR. > > +# Copyright (c) Siemens AG, 2018 > > +# > > +# SPDX-License-Identifier: MIT > > + > > +TARGZ_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${IMAGE_FULLNAME}.tar.gz" > > + > > +do_targz_image[stamp-extra-info] = "${DISTRO}-${MACHINE}" > > + > > +do_targz_image() { > > + rm -f ${TARGZ_IMAGE_FILE} > > + sudo tar -cvzf ${TARGZ_IMAGE_FILE} -C ${IMAGE_ROOTFS} . > > +} > > + > > +addtask targz_image before do_build after do_rootfs > > > -- Harald DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-62 Fax: +49-8142-66989-80 Email: hws@denx.de