Re: [PATCH 2/2] integrate ubifs image type

[Claudius Heine <ch@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 1931 bytes --]

Quoting Henning Schild (2019-01-29 10:10:50)
...
> > >> Do you think that refactoring should be part of this patchset?  
> > > 
> > > I am not sure, just wanted to write it down. On the one hand it
> > > would be nice to solve all drive-by issues as we go. On the other
> > > hand that will slow down development and impose on contributors.
> > > So feel free to ignore my comments, the inconsistencies are not your
> > > fault and asking you to fix them would be too much.  
> > 
> > Maybe we should open issues for all those inconsistencies and 
> > annoyances, so that they can be fixed or at least be documented.
> 
> We do not use issues, so we would need another way to track not fully
> resolved discussions from the list. But i agree, it would be nice to
> keep track of things in a structured way to fix them eventually.
> Maybe a TODO.md?

I am not really a fan of TODO lists that are checked into the VCS.

I would find it very strange to send patches to the TODO list... I don't
even know what the process there would be? Should I first send a patch
to the TODO list and then have discussions about it and afterwarts start
working on patches in isar?

I rather have some uncoupled list of TODO items somewhere without the
patch/review overhead.

> > At some point making a complete code review (not just patches) on
> > isar would be great, just to find and fix those.
> 
> I thought the same, maybe an Isar hackathon.

Maybe... I am not a hackathon expert. I don't know if quality codes
comes out of that...

Claudius

--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

           PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
                             Keyserver: hkp://pool.sks-keyservers.net

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlxQHEEACgkQEXPLGZgI
sVMU7Q//V9y0LiS+yeGgeOXctxeJOzZMzyDc4AuNAnV2aRoFVsnb4LTylS3OLpof
zqQwGe4NszJpI/pLvyyH2vagrozC14AMWXEEAqsgUsN3XbLP92cljrvT8DI/YSzS
Vvk22CQK0eVkb3+JpftGHSwq4bIFKONzSOkKOzdh3HIXKTCbn47PeTvUX0qzGRGB
/rf5BiHIENPYntYPgNCFp9JIFcoskN63ANUgmcyDEaKaOEAugMBcwvqG9PMAoQN3
iza2M9cAOKavNMNReNtM7BCAe5umaytGY2FCLl+UMhRH96pivHNOeSQvUccBKWxV
2QDEM/d4MOdy1V2uZR+OAhvP7gFQyb1OGUwlkCg6GTWTe97AY+hpOo/BiiXLr3fu
F33EXDU+EI095F1/z6fZyqVPiwvZ9mvatRWA1PhipnoEEsuJX9DHheG8faawjk5J
e1hFoC/Jft00iNLDJ6aVfFz+hPeIR3s+A0i4X+ZkCFHLubu0IUx4p5mQbMlpdD8E
DaKPNts3i1NUXuR5cGOJOfUwnhegugRL4hvkVfQdAR3ColSLsHFNf83rVIggBa6m
wME68g+/70z60ZVJoRMsgrZkeO43yHOTJibF59eeczpMWlWGkBvcjLf+ydDiB75k
+aw/aExE/abmIPWMnIne33kMcy/9ibLkpzjllY1K+oxifvip6FA=
=52NA
-----END PGP SIGNATURE-----