From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6651523578180141056 X-Received: by 2002:a17:906:8492:: with SMTP id m18mr462406ejx.12.1548753992330; Tue, 29 Jan 2019 01:26:32 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:a5f8:: with SMTP id b53ls4681619edc.5.gmail; Tue, 29 Jan 2019 01:26:31 -0800 (PST) X-Google-Smtp-Source: AHgI3Iar+7ixsxO+oC+KAvSpoiUFOAmPKRvjuKiNXBKeFRmTFKO8l60IGOWiXzhLlRKjpNPK2WFi X-Received: by 2002:a50:d1d6:: with SMTP id i22mr485194edg.1.1548753991832; Tue, 29 Jan 2019 01:26:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548753991; cv=none; d=google.com; s=arc-20160816; b=QIIxZ1IfTGITceqawt1yrXbFUp37tEV+Szl+/F5eqP9miITC9hn5SmDolIA2OlcvV8 xLYJsvIiCph6AqxO/6hxtPLANrZwMLZea0+cSIsrkPFq4Di5GsN0IFyZcuTmxKZMXp2r Vp1+dX9BzgEef319kbcLA2Tb4bQ8qutQohUOCVxAswwQLkqgSw/B6K66P4tlpyB1W7Ri qRSTFmcg+REIkmDLBMHNZFjFN0DtdydT4ITMUTFrgt3LMlkE1c/h8YZOneHn+hCGAbgz 0NSgTxTHPYXpdeGtwpnGtMPz14fhJYQMREWU4lnmraBoc2qyae1SR+jonfQXjRA4qkID I+fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:user-agent:message-id:from:to:cc:subject:references :in-reply-to:content-disposition:mime-version; bh=bJaedUWTJnRVnSiPz/bxQHMlPFlhApFzuwVQy7mqGpg=; b=DHC/7QbDxmozM7jBo5joPfRF4fS7PP7ayrqSKHprb+ShUQFmaD4ALa9o3NKspDdxnE 6DABQwxqLfQlh7jh9mONa9x9yZQVPfALifdVr34DYSD+IbatOH/Jop252WJNfdCJ6Vho fFW6qRqt9YhZFtQ6hkqs1sXEAhhT8lnOTrpKyPVc8TR2cUGbMo6dyWcNrPpNAwkWJNlo 6scvUR/FOK0OrY1HFasVU4X5IEzRmf2zM8zPjKh8For5MR4CW7vMkxaOv8jD+5cK9u5k r7U7Q1G7sRoputYB6LkIAj9z1FO1ekUVrZml4CqgaJSFyIGntNmubgkvaRdgqFQF+76e Iolw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id i17si2112228edg.2.2019.01.29.01.26.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 01:26:31 -0800 (PST) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) client-ip=212.18.0.9; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 43ph2b3m3zz1r3fS; Tue, 29 Jan 2019 10:26:31 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 43ph2b3Swzz1r2HT; Tue, 29 Jan 2019 10:26:31 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 6EXDWz4oYiI9; Tue, 29 Jan 2019 10:26:30 +0100 (CET) X-Auth-Info: 20kHLgsY18igUSzktq0aZCJ8SC60Nvc2sglkHYv8Kv8= Received: from localhost (p578a821c.dip0.t-ipconnect.de [87.138.130.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 29 Jan 2019 10:26:30 +0100 (CET) Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="===============0106761611724439932==" MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190129101050.7681afdc@md1za8fc.ad001.siemens.net> References: <20190128122821.10002-1-claudius.heine.ext@siemens.com> <20190128122821.10002-3-claudius.heine.ext@siemens.com> <20190128140344.7bc5f072@md1za8fc.ad001.siemens.net> <20190128182237.04ab656b@md1za8fc.ad001.siemens.net> <5fab2f59-9f15-713f-f2c8-15886800a3dc@siemens.com> <20190129101050.7681afdc@md1za8fc.ad001.siemens.net> Subject: Re: [PATCH 2/2] integrate ubifs image type Cc: isar-users@googlegroups.com To: Claudius Heine , Henning Schild From: Claudius Heine Message-ID: <154875398897.7929.15412282169649766110@ardipi> User-Agent: alot/0.8 Date: Tue, 29 Jan 2019 10:26:28 +0100 X-TUID: QrR9SgUfT2LS --===============0106761611724439932== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Quoting Henning Schild (2019-01-29 10:10:50) ... > > >> Do you think that refactoring should be part of this patchset? =20 > > >=20 > > > I am not sure, just wanted to write it down. On the one hand it > > > would be nice to solve all drive-by issues as we go. On the other > > > hand that will slow down development and impose on contributors. > > > So feel free to ignore my comments, the inconsistencies are not your > > > fault and asking you to fix them would be too much. =20 > >=20 > > Maybe we should open issues for all those inconsistencies and=20 > > annoyances, so that they can be fixed or at least be documented. >=20 > We do not use issues, so we would need another way to track not fully > resolved discussions from the list. But i agree, it would be nice to > keep track of things in a structured way to fix them eventually. > Maybe a TODO.md? I am not really a fan of TODO lists that are checked into the VCS. I would find it very strange to send patches to the TODO list... I don't even know what the process there would be? Should I first send a patch to the TODO list and then have discussions about it and afterwarts start working on patches in isar? I rather have some uncoupled list of TODO items somewhere without the patch/review overhead. > > At some point making a complete code review (not just patches) on > > isar would be great, just to find and fix those. >=20 > I thought the same, maybe an Isar hackathon. Maybe... I am not a hackathon expert. I don't know if quality codes comes out of that... Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 Keyserver: hkp://pool.sks-keyservers.net --===============0106761611724439932== MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Description: signature Content-Type: application/pgp-signature; name="signature.asc"; charset="us-ascii" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlxQHEEACgkQEXPLGZgI sVMU7Q//V9y0LiS+yeGgeOXctxeJOzZMzyDc4AuNAnV2aRoFVsnb4LTylS3OLpof zqQwGe4NszJpI/pLvyyH2vagrozC14AMWXEEAqsgUsN3XbLP92cljrvT8DI/YSzS Vvk22CQK0eVkb3+JpftGHSwq4bIFKONzSOkKOzdh3HIXKTCbn47PeTvUX0qzGRGB /rf5BiHIENPYntYPgNCFp9JIFcoskN63ANUgmcyDEaKaOEAugMBcwvqG9PMAoQN3 iza2M9cAOKavNMNReNtM7BCAe5umaytGY2FCLl+UMhRH96pivHNOeSQvUccBKWxV 2QDEM/d4MOdy1V2uZR+OAhvP7gFQyb1OGUwlkCg6GTWTe97AY+hpOo/BiiXLr3fu F33EXDU+EI095F1/z6fZyqVPiwvZ9mvatRWA1PhipnoEEsuJX9DHheG8faawjk5J e1hFoC/Jft00iNLDJ6aVfFz+hPeIR3s+A0i4X+ZkCFHLubu0IUx4p5mQbMlpdD8E DaKPNts3i1NUXuR5cGOJOfUwnhegugRL4hvkVfQdAR3ColSLsHFNf83rVIggBa6m wME68g+/70z60ZVJoRMsgrZkeO43yHOTJibF59eeczpMWlWGkBvcjLf+ydDiB75k +aw/aExE/abmIPWMnIne33kMcy/9ibLkpzjllY1K+oxifvip6FA= =52NA -----END PGP SIGNATURE----- --===============0106761611724439932==--