public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Cedric Hombourger <Cedric_Hombourger@mentor.com>
To: <isar-users@googlegroups.com>
Cc: Cedric Hombourger <Cedric_Hombourger@mentor.com>
Subject: [PATCH] dpkg: acquire a read (shared) locks while building packages
Date: Fri, 8 Mar 2019 10:57:33 +0100	[thread overview]
Message-ID: <1552039053-1152-1-git-send-email-Cedric_Hombourger@mentor.com> (raw)

As debhelper scripts involved during the actual build process
(dpkg-buildpackage) may access the dpkg database, we need to
make sure it does not get modified in the background by other
build tasks for other packages (such as install_build_deps).
An example of a reader is dh_shlibdeps/dpkg-shlibdeps: it
needs to find packages providing the shared libraries the
package depends on to substitue shlibs variables found in its
control file with package dependencies. Acquire the isar-apt
lock as a shared lock to block writers.

Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
---
 meta/classes/dpkg.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index 24b9fe3..f4e3d7a 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -19,5 +19,6 @@ do_install_builddeps[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
 # Build package from sources using build script
 dpkg_runbuild() {
     E="${@ bb.utils.export_proxies(d)}"
+    flock -s "${REPO_ISAR_DIR}/isar.lock" \
     sudo -E chroot --userspec=$( id -u ):$( id -g ) ${BUILDCHROOT_DIR} /isar/build.sh ${PP}/${PPS} ${DISTRO_ARCH}
 }
-- 
2.11.0


             reply	other threads:[~2019-03-08  9:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08  9:57 Cedric Hombourger [this message]
2019-03-08 10:04 ` Jan Kiszka
2019-03-08 13:33   ` cedric_hombourger
2019-03-08 15:13     ` Jan Kiszka
2019-03-08 15:24       ` cedric_hombourger
2019-03-08 15:27         ` Jan Kiszka
2019-03-08 15:49           ` [PATCH v2] " Cedric Hombourger
2019-03-08 16:38             ` Jan Kiszka
2019-03-14  6:21               ` cedric_hombourger
2019-03-15  4:47             ` Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1552039053-1152-1-git-send-email-Cedric_Hombourger@mentor.com \
    --to=cedric_hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox