Re: [PATCH 1/2] meta-isar: Separate images per MACHINE

[Claudius Heine <ch@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 3583 bytes --]

Hi Maxim,

Quoting Maxim Yu. Osipov (2019-03-15 10:02:48)
[...]
> >>> diff --git a/meta-isar/conf/conf-notes.txt 
> >>> b/meta-isar/conf/conf-notes.txt
> >>> index 87bd2dc..84049e1 100644
> >>> --- a/meta-isar/conf/conf-notes.txt
> >>> +++ b/meta-isar/conf/conf-notes.txt
> >>> @@ -1,4 +1,4 @@
> >>>   Common targets are:
> >>> -    multiconfig:qemuarm-stretch:isar-image-base
> >>> -    multiconfig:qemuamd64-stretch:isar-image-base
> >>> -    multiconfig:rpi-jessie:isar-image-base
> >>> +    multiconfig:qemuarm-stretch:isar-image-base-qemuarm
> >>> +    multiconfig:qemuamd64-stretch:isar-image-base-qemuamd64
> >>> +    multiconfig:rpi-jessie:isar-image-base-rpi
> > 
> > I am not a big fan of having to specify the machine when building a image.
> > 
> > Would it be possible to have virtual recipes?
> > 
> > IMO all isar-image-base-* would provide a isar-image-base.
> 
> Not sure that I got your point.
> OK, let's add two line to isar-image-base.bb
> 
> PF .= "-${MACHINE}"
> PROVIDES += "isar-image-base"

Well that is not what my initial suggestion was.

If you want to use my initial suggestion and use PROVIDES then of course
you will have to do something like this:

  PN .= "-${MACHINE}"
  PROVIDES += "isar-image-base"

If you use my latest suggestion then you would have something like this:

  PF .= "-${MACHINE}"
  WORKDIR .= "-${MACHINE}"

If you sort of start combining my code then this will not work of
course.

Please investigate yourself what code you write does. I don't provide copy
paste stuff in reviews, just ideas. You might be lucky if they just work by
copy-pasting, but you might not be and have to think a bit yourself to
make it work. If I would do that, then I would have written the patch
myself.

[...]

> >>> --- a/scripts/start_vm
> >>> +++ b/scripts/start_vm
> >>> @@ -1,7 +1,7 @@
> >>>   #!/bin/sh
> >>>   #
> >>>   # This software is a part of ISAR.
> >>> -# Copyright (C) 2015-2017 ilbers GmbH
> >>> +# Copyright (C) 2015-2019 ilbers GmbH
> >>>   set -e
> >>> @@ -46,7 +46,7 @@ show_help() {
> >>>       echo "                          Supported: arm, i386, amd64, 
> >>> arm64."
> >>>       echo "    -b, --build BUILD     set path to build directory."
> >>>       echo "    -d, --distro DISTRO   set isar Debian distribution."
> >>> -    echo "                          Supported: jessie, stretch."
> >>> +    echo "                          Supported: jessie, stretch, buster"
> > 
> > Well that change together with the copyright update should be moved in a 
> > different patch. It has nothing to do with 'Separate images per MACHINE' 
> > IMO.
> 
> Well...formally you are right, but in my opinion such "copyright" 
> commits just litter the patch queue.

Having unrelated changes in a commit will make is harder to review, and
litter the git history/blame stuff. So while it might be a small
inconveniece short term (by needing to create and submitt more than one
patch in a queue) it makes the history cleaner for the whole future.

Cheers,
Claudius

--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

           PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
                             Keyserver: hkp://pool.sks-keyservers.net

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlyLfXoACgkQEXPLGZgI
sVOUAg/9Ei8kXsF6D5unrr7wFEnXJWwU02qw54kq+eFCIk7dVhMMNnWrc8fdDk8h
MqxhTtKGx6Dmv0Pjih284dSiJVhnXdmrvxiw32sejQ54vP0+kLOix48jDiBztcel
7mcunrTMIf3tqB3VJYd073jkglo8yCwqHLIQ6Q1x6wLRDe7Tc5RRtmU+7e/LP3vT
aF9DE2tXkLB9/1YgsMHBhs8Rw67n1bfKT1RZRl+ZMW+yNGpwlUmGtTva4Wze9qQa
ARnL7Y+DOnjWroVOzAxw2r67D1C5dxpy9otXVcR5AvX19eT9Q3oh6i6cu3MRnmHB
XAYJ7MZlunTTYKkt1JjQ35yW4KCi3f/DydqujaGuMuacDQ8Z3G0URXIngmI38fl0
2rPaG1osgxwod8eAluDQ5BrNx3hTgIrXT7nJilxUh0cfrq4UvSuIP+o702ard9EW
O/49jAMQbE5ccCaXsDlRqg6FGNbcfqfNmqTCL57NBTsCUWrba15WrLlDmx+XKE9B
uDoehoOLI8bvUbe6UQnr17OHEGkIDV5sJTkiRkp5tigHIh3aT3Sywr2PaEjhLkn8
xqsgRWEzALJqcGLnkTPHnTFO7gI0fvHkEsGg3ZXkpYtpnEp+E/p898cl1MZALw+S
jnq++WY2URbyaXfhYKBnB8uF5lXnFWSviWbzkg7tQJPmh1Z3PjU=
=MdsW
-----END PGP SIGNATURE-----