From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6667603680306397184 X-Received: by 2002:a1c:cf48:: with SMTP id f69mr164645wmg.13.1552645511190; Fri, 15 Mar 2019 03:25:11 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:6a86:: with SMTP id s6ls1451162wru.10.gmail; Fri, 15 Mar 2019 03:25:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqwklDsyjCc7rWAQ5hFOxI4DntfzAaDtBo+WqcI6zmKDiFbbHmvD+MI7GVepnWVwZJPAivIn X-Received: by 2002:adf:9f42:: with SMTP id f2mr144548wrg.25.1552645510732; Fri, 15 Mar 2019 03:25:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552645510; cv=none; d=google.com; s=arc-20160816; b=qpOf3o1zRMIYPgQaazm+29N4tPKoSbskkinmWG84Vb4RxKKYOOFu30gp11Pd1jm1n/ 1ZjMnbhZodYiU7aRBtlr9J0yN4n7EsKIxu8aq6eGsryHcjUg4MOByqg5vBjrNzxlwj3c dEvdyZ5Khgt/k0ywYkqZyY8dHIPvAH0m1tfKR2M1vV4i+AXc2sKZQLyMcG4Zi3tShY1b aD84ofeQzVJCw9td5UX2PJYjXkZIW0DKNX6Z874H5Y3/YX0o9ZMHyugwKGxOjMzQDmTf HMwGSW/v6ZW/wCCXPRKswgfdn+Mj3CKuwVZqUt/n/LLsF2NlCXnasq3zzNRPAhYcPRY1 dt9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:user-agent:message-id:subject:to:from:references:in-reply-to :content-disposition:mime-version; bh=EQCNIBE2ZPiS05Wr1FbyT5nLBnQiKPYo3mttJcI5D4k=; b=0drH8Xb9JxTzQZv5rFx0O5/mJaPWEt6dIuNym1Va2x5nQhMzKJA1CR3lgKZW8607b9 FO0P2+cwoZbHZ+AHqo7EhJjewh7wfUCH9n1A//FkgdVYBRxivN8gSfb1ri0SpBEfzmb6 gUtpz0b3rB5kowPUBBqo0p8z5ukzEeBmNYjxDWOwRqiBnNVUALzaHyGL8eFvRZNKhw4H q7obG8EbN2j81vowgZ7oyOWKXMOmeQhjjOTfJyheeTtNVkUiqzpM6U9Q2CKpnzw0pqv4 WpM6OHAy/CdKg7SzvwcEOq679xo+y2k8kAmvio+P1mhTW0S3S6Im80oG47OBaACAqBw/ /wSg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.10]) by gmr-mx.google.com with ESMTPS id t22si65425wmj.2.2019.03.15.03.25.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Mar 2019 03:25:10 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of ch@denx.de) client-ip=212.18.0.10; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 44LMCV3FwTz1r92x; Fri, 15 Mar 2019 11:25:10 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 44LMCV2w08z1qr5w; Fri, 15 Mar 2019 11:25:10 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id aQYDbpxaLS2L; Fri, 15 Mar 2019 11:25:08 +0100 (CET) X-Auth-Info: 2dO6LbrwkMkaeiRl9MBrx5m5DjPrZxGX9c5D3I0l3+8= Received: from localhost (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 15 Mar 2019 11:25:08 +0100 (CET) Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="===============3215499550035010557==" MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <91c1cdc1-9e63-7833-1518-e64dd144f102@ilbers.de> References: <20190312202713.18792-1-mosipov@ilbers.de> <7984d051-8bf0-dff1-804d-104ad2a17af7@siemens.com> <91c1cdc1-9e63-7833-1518-e64dd144f102@ilbers.de> From: Claudius Heine To: "Maxim Yu. Osipov" , Claudius Heine , isar-users@googlegroups.com Subject: Re: [PATCH 1/2] meta-isar: Separate images per MACHINE Message-ID: <155264550626.9286.14205828919186368830@ardipi> User-Agent: alot/0.8 Date: Fri, 15 Mar 2019 11:25:06 +0100 X-TUID: DKA95weERfEI --===============3215499550035010557== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Maxim, Quoting Maxim Yu. Osipov (2019-03-15 10:02:48) [...] > >>> diff --git a/meta-isar/conf/conf-notes.txt=20 > >>> b/meta-isar/conf/conf-notes.txt > >>> index 87bd2dc..84049e1 100644 > >>> --- a/meta-isar/conf/conf-notes.txt > >>> +++ b/meta-isar/conf/conf-notes.txt > >>> @@ -1,4 +1,4 @@ > >>> =C2=A0 Common targets are: > >>> -=C2=A0=C2=A0=C2=A0 multiconfig:qemuarm-stretch:isar-image-base > >>> -=C2=A0=C2=A0=C2=A0 multiconfig:qemuamd64-stretch:isar-image-base > >>> -=C2=A0=C2=A0=C2=A0 multiconfig:rpi-jessie:isar-image-base > >>> +=C2=A0=C2=A0=C2=A0 multiconfig:qemuarm-stretch:isar-image-base-qemua= rm > >>> +=C2=A0=C2=A0=C2=A0 multiconfig:qemuamd64-stretch:isar-image-base-qem= uamd64 > >>> +=C2=A0=C2=A0=C2=A0 multiconfig:rpi-jessie:isar-image-base-rpi > >=20 > > I am not a big fan of having to specify the machine when building a ima= ge. > >=20 > > Would it be possible to have virtual recipes? > >=20 > > IMO all isar-image-base-* would provide a isar-image-base. >=20 > Not sure that I got your point. > OK, let's add two line to isar-image-base.bb >=20 > PF .=3D "-${MACHINE}" > PROVIDES +=3D "isar-image-base" Well that is not what my initial suggestion was. If you want to use my initial suggestion and use PROVIDES then of course you will have to do something like this: PN .=3D "-${MACHINE}" PROVIDES +=3D "isar-image-base" If you use my latest suggestion then you would have something like this: PF .=3D "-${MACHINE}" WORKDIR .=3D "-${MACHINE}" If you sort of start combining my code then this will not work of course. Please investigate yourself what code you write does. I don't provide copy paste stuff in reviews, just ideas. You might be lucky if they just work by copy-pasting, but you might not be and have to think a bit yourself to make it work. If I would do that, then I would have written the patch myself. [...] > >>> --- a/scripts/start_vm > >>> +++ b/scripts/start_vm > >>> @@ -1,7 +1,7 @@ > >>> =C2=A0 #!/bin/sh > >>> =C2=A0 # > >>> =C2=A0 # This software is a part of ISAR. > >>> -# Copyright (C) 2015-2017 ilbers GmbH > >>> +# Copyright (C) 2015-2019 ilbers GmbH > >>> =C2=A0 set -e > >>> @@ -46,7 +46,7 @@ show_help() { > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 echo "=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Supported: arm, i386, amd64, = > >>> arm64." > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 echo "=C2=A0=C2=A0=C2=A0 -b, --build B= UILD=C2=A0=C2=A0=C2=A0=C2=A0 set path to build directory." > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 echo "=C2=A0=C2=A0=C2=A0 -d, --distro = DISTRO=C2=A0=C2=A0 set isar Debian distribution." > >>> -=C2=A0=C2=A0=C2=A0 echo "=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Supported: jessie, stretch." > >>> +=C2=A0=C2=A0=C2=A0 echo "=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Supported: jessie, stretch, buster" > >=20 > > Well that change together with the copyright update should be moved in = a=20 > > different patch. It has nothing to do with 'Separate images per MACHINE= '=20 > > IMO. >=20 > Well...formally you are right, but in my opinion such "copyright"=20 > commits just litter the patch queue. Having unrelated changes in a commit will make is harder to review, and litter the git history/blame stuff. So while it might be a small inconveniece short term (by needing to create and submitt more than one patch in a queue) it makes the history cleaner for the whole future. Cheers, Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 Keyserver: hkp://pool.sks-keyservers.net --===============3215499550035010557== MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Description: signature Content-Type: application/pgp-signature; name="signature.asc"; charset="us-ascii" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlyLfXoACgkQEXPLGZgI sVOUAg/9Ei8kXsF6D5unrr7wFEnXJWwU02qw54kq+eFCIk7dVhMMNnWrc8fdDk8h MqxhTtKGx6Dmv0Pjih284dSiJVhnXdmrvxiw32sejQ54vP0+kLOix48jDiBztcel 7mcunrTMIf3tqB3VJYd073jkglo8yCwqHLIQ6Q1x6wLRDe7Tc5RRtmU+7e/LP3vT aF9DE2tXkLB9/1YgsMHBhs8Rw67n1bfKT1RZRl+ZMW+yNGpwlUmGtTva4Wze9qQa ARnL7Y+DOnjWroVOzAxw2r67D1C5dxpy9otXVcR5AvX19eT9Q3oh6i6cu3MRnmHB XAYJ7MZlunTTYKkt1JjQ35yW4KCi3f/DydqujaGuMuacDQ8Z3G0URXIngmI38fl0 2rPaG1osgxwod8eAluDQ5BrNx3hTgIrXT7nJilxUh0cfrq4UvSuIP+o702ard9EW O/49jAMQbE5ccCaXsDlRqg6FGNbcfqfNmqTCL57NBTsCUWrba15WrLlDmx+XKE9B uDoehoOLI8bvUbe6UQnr17OHEGkIDV5sJTkiRkp5tigHIh3aT3Sywr2PaEjhLkn8 xqsgRWEzALJqcGLnkTPHnTFO7gI0fvHkEsGg3ZXkpYtpnEp+E/p898cl1MZALw+S jnq++WY2URbyaXfhYKBnB8uF5lXnFWSviWbzkg7tQJPmh1Z3PjU= =MdsW -----END PGP SIGNATURE----- --===============3215499550035010557==--