From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6641861376070385664 X-Received: by 2002:a5d:50c6:: with SMTP id f6mr3343440wrt.10.1546870856173; Mon, 07 Jan 2019 06:20:56 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:3581:: with SMTP id c123ls132567wma.9.gmail; Mon, 07 Jan 2019 06:20:55 -0800 (PST) X-Google-Smtp-Source: ALg8bN73BCLVlkZ06svrG6iNUR+PUAc2liO+5unzN1x2uDGZ6Y355mgC8ylTPIzo9CrztIvSkwXx X-Received: by 2002:a1c:e703:: with SMTP id e3mr1036627wmh.1.1546870855785; Mon, 07 Jan 2019 06:20:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546870855; cv=none; d=google.com; s=arc-20160816; b=X37R/0gFA499R0TwSYhTHmAM8TPMHw+wxKZfMW/i+9CkHpX9jqHm0ddqWx0Cn1ii4m G2zbYCuhQ5T7L1IL8K0iTx0Lj1uDlVCFPWi16ilftLc5SQx9Iup7nz0hi5N/sn6L4dKt 49f8GIRiKibfOo/p1sJefFkTfhZJvyQzR//H+/xfKUpG24oKrXAA6/K1UT1baIJzaq1E C799X47Nk4dpnTZsZRGkUnvLMex4SVKtlb7pRHSCGNavX/so4qLm2rKC6GDuBDf5mQ62 JtTCeKiTURwIMZw3CB/0I76n6sGCm18PUUlULKroF0FuaDIH3O9M2ChbleXHshCgJRi+ FXWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=/5tXHQxJNYTpiwn5LGsCGtN9NgNF0nXX6h1h0sZsmpI=; b=o4J/+sgDLs2MzCTBj0EntMcSbcoTf+fd7+v7hCOBlftsSgpM/60J5O9TUm24AVwTjr gUuBSCs9LEjMTTVsUuDmyEqTOIv40gseMavk9uGTZpXudqr+dZIYoKWrdlbap+4JFgSi rBoL+FCHESp3LOMgTZmrLeGxt8U9PU35Nnc6RI24GbT/YiBfpXJBvqHTiJtSzEgrUZz4 tvu0nRFmLdOshVh6CO1PYiKG2qx/gXfDNo4IdGUk/m9XxbhrH6OfzPsGoTjXjOdvK9DM vavQ42gg9FRheHQ15dZQN2OsjgFDOR+JfQecqWUs/m/rk4XB0FzeoC+gTvnY9I1T+Omj Y5vA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id p15si2498534wrm.5.2019.01.07.06.20.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Jan 2019 06:20:55 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x07EKtXf007071 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 7 Jan 2019 15:20:55 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x07EKtOs030409; Mon, 7 Jan 2019 15:20:55 +0100 Subject: Re: [PATCH 1/7] dpkg-raw: Respect file permissions defined by recipe To: Henning Schild Cc: isar-users References: <20190107142049.0c5426a3@md1za8fc.ad001.siemens.net> <20190107151959.2627fcd8@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <1552f87b-a193-fca2-6496-e94554b21d6f@siemens.com> Date: Mon, 7 Jan 2019 15:20:55 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20190107151959.2627fcd8@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: j90tRy2SERlQ On 07.01.19 15:19, Henning Schild wrote: > Am Mon, 7 Jan 2019 14:28:47 +0100 > schrieb Jan Kiszka : > >> On 07.01.19 14:20, Henning Schild wrote: >>> Am Wed, 2 Jan 2019 12:34:11 +0100 >>> schrieb Jan Kiszka : >>> >>>> From: Jan Kiszka >>>> >>>> dh_fixperms overwrites the permissions do_install defined >>>> carefully. Skip this step to avoid that. >>>> >>>> Fixes: f301ccb2b5b1 ("meta/dpkg-raw: build raw packages like all >>>> others") CC: Henning Schild >>>> Signed-off-by: Jan Kiszka >>>> --- >>>> meta/classes/dpkg-raw.bbclass | 4 +++- >>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/meta/classes/dpkg-raw.bbclass >>>> b/meta/classes/dpkg-raw.bbclass index 8d11433..10fb1b9 100644 >>>> --- a/meta/classes/dpkg-raw.bbclass >>>> +++ b/meta/classes/dpkg-raw.bbclass >>>> @@ -56,9 +56,11 @@ EOF >>>> deb_create_rules() { >>>> cat << EOF > ${S}/debian/rules >>>> #!/usr/bin/make -f >>>> + >>>> +override_dh_fixperms: >>>> + >>>> %: >>>> dh \$@ >>>> - >>> >>> I think it is not a good idea to do that in general. While you might >>> have found an example where dh_fixperms caused problems, there are >>> probably many where it helps. Say people use "cp" to fill ${D} or >>> "echo" to fill ${D}/bin/ >> >> I'm open for better suggestions. > > The suggestion is to do that in the one recipe that you need it for, > and not touch the general case. ...except for causing that regression: Keep in mind that we used to respect permissions defined by the user before the switch to packaging via Debian! Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux