From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7167793861521047552 X-Received: by 2002:a17:90a:c296:b0:234:1fac:f291 with SMTP id f22-20020a17090ac29600b002341facf291mr408066pjt.8.1677152618664; Thu, 23 Feb 2023 03:43:38 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:902:6b02:b0:19c:b122:6f2d with SMTP id o2-20020a1709026b0200b0019cb1226f2dls3631173plk.2.-pod-prod-gmail; Thu, 23 Feb 2023 03:43:37 -0800 (PST) X-Google-Smtp-Source: AK7set/TbUcaxXZi4OQwZGgJBs/LGoidjaVCz5jEyz8C89z6QYGMzNkWownuv5TbMk5MsyieiCXk X-Received: by 2002:a17:90b:3b4f:b0:237:3d0c:89ae with SMTP id ot15-20020a17090b3b4f00b002373d0c89aemr6090850pjb.34.1677152617690; Thu, 23 Feb 2023 03:43:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677152617; cv=none; d=google.com; s=arc-20160816; b=d9xlmLztiI/qoKlAzWKAh+ND82+F27GNeBbS1XsFiyLOiJkuOpUOEaJp3xpGUdng6k 8U4DYu0hi35zMpPEyrIViAJ4VJwSGB8VZFDspQCQXvuwHAw6G4lGpkKjSb6rrNdBS29u nT8782R9FAqSf/f+AsYk3XjyoGMZGXpMsCfeTEwAFLUeHADaUDBjUIImkYYK9BXsaJCw gsMolOCcjxqbbFxoOhI7meurDpHstWYizz9RyxNlkpfu38yt9QtatpVMRyzOjfmxmqFe BeUvqCv5kLM4NN2ISPy82wCYHjwZVCLONkxVgj1+iEsiKcQ3HWIa9WFNquy4WCdzOXl+ FgFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=K7xNRhulZEWJT9OoApx02TcHSSAAq7Xd6KlPiSPDuJA=; b=hIQocdYePCT55/OK7xLmnDc8eNbt/zn2N9zu4UwBGJH17jc8NmceJYT2rD2r4yiArl exh8Bcm7LGYh0VEZgIiDIuAKG+8bQF12sWaT1Szpcyi/5E3nc4YJ3OIA3DZh2+nheZI7 g4AHpXa5G8raxhWZmoG5wiKhoPZwtnpL7KNS0a8lkwrIm6obWUp5aMZ87zqVboaUYslX MK5OsApSSUpAUMPHW5z3+yVGuYtIa2p0EYb9juSz3oKQXFADIoSsXfDOmThUkJd3XstU +mS3HB0OG7s4lbIvj1eqrhNg4KH9htXNLboHJnHVlBqKrYSrGP4opM6s3Q0wdz5lPnBl 2CHA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id n9-20020a170902f60900b0019cbe03d60csi78494plg.11.2023.02.23.03.43.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Feb 2023 03:43:37 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from home.localnet (44-208-124-178-static.mgts.by [178.124.208.44] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 31NBhYan019992 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Feb 2023 12:43:35 +0100 From: Uladzimir Bely To: Anton Mikanovich , "T. Schaffner" , isar-users@googlegroups.com Cc: quirin.gylstorff@siemens.com, Florian Bezdeka Subject: Re: [PATCH 2/2] Warn if systemd-firstboot misses configurations Date: Thu, 23 Feb 2023 14:43:35 +0300 Message-ID: <15530605.Emhk5qWAgF@home> In-Reply-To: <892fe496354a967054e63a67fbba59268f372548.camel@siemens.com> References: <20221119182031.2005807-1-tobias.schaffner@siemens.com> <08d391d5-cb8c-4a49-826d-51b69cd7ef07@ilbers.de> <892fe496354a967054e63a67fbba59268f372548.camel@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: k59rs5dBt8b4 In the email from Tuesday, 22 November 2022 13:24:53 +03 user Florian Bezdeka wrote: > On Tue, 2022-11-22 at 13:04 +0300, Anton Mikanovich wrote: > > 19.11.2022 21:20, T. Schaffner wrote > > > From: Tobias Schaffner > > > > > > systemd-firstboot checks the existence of different system configurations > > > like locale or hostname. Debian packages may trust that these configurations > > > are in the location that systemd-firstboot enforced. > > > > > > Warn the user in the image postproc step if systemd-firstboot misses any > > > configurations in the image. > > > > > > Signed-off-by: Tobias Schaffner > > > > If we have a warning here, do we really need to mask the service in p1? > > User should fix the reason but not hide it, and masking can be optional just > > in case there are no other ways. > > I didn't have the time to review the patches in detail yet, so I might > be wrong. But: If systemd-firstboot is enabled (not masked) and we miss > one of the config settings that it checks the image won't boot up. > > It will enter a interactive mode and ask you questions on how to > configure your system (locale, keyboard layout, ...). Especially for CI > and embedded systems that's a real issue. > > So I guess the idea was to simply mask systemd-firstboot (we don't like > interactive mode) and warn the user that the system might not be fully > configured. > > Tobias, please correct me if need to. > > Florian > > > > > We are still waiting for the answer, so the merge process is delayed. Anyway, CI on recent `next` is still passed OK with the patch, so if no one against, we would merge it soon.