Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Claudius Heine <ch@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 2924 bytes --]

Hi Maxim,

Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
> > From: Claudius Heine <ch@denx.de>
> > 
> > isar-bootstrap-host only supports bootstrapping Debian root file
> > systems. Therefore deactivate any DISTRO_APT_KEYS from other
> > distributions.
> > 
> > Signed-off-by: Claudius Heine <ch@denx.de>
> > ---
> >   meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > index 08b068f..3e96281 100644
> > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
> >   ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
> >   
> >   require isar-bootstrap.inc
> > +# We only build debian host buildchroot environments
> > +DISTRO_APT_KEYS = ""
> 
>  From the first glance this modification limits functionality.
> It looks like a hack and I would suggest to avoid this modification.

Well it is a fix and that limited functionality was already present but
just implicit, hidden behind some bug and the cleanup just made it
appear.

> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to 
> avoid confusion between target and host apt keys.

Good idea. But that would be a new feature/improvement.

Also thanks for looking at the code!

Claudius

> 
> 
> Maxim.
> 
> 
> 
> >   inherit isar-bootstrap-helper
> >   
> >   do_generate_keyring[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
> > 
> 
> 
> -- 
> Maxim Osipov
> ilbers GmbH
> Maria-Merian-Str. 8
> 85521 Ottobrunn
> Germany
> +49 (151) 6517 6917
> mosipov@ilbers.de
> http://ilbers.de/
> Commercial register Munich, HRB 214197
> General Manager: Baurzhan Ismagulov
> 
> -- 
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To post to this group, send email to isar-users@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/ccc13295-982c-7b25-cfc2-e079033689c0%40ilbers.de.
> For more options, visit https://groups.google.com/d/optout.

--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

           PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
                             Keyserver: hkp://pool.sks-keyservers.net

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlzCtQwACgkQEXPLGZgI
sVPbFBAAkU6wWKvx56TEGQ/INClJLSlHec9QbPesSbjfHb9AxW79UUwj3ZtYfhUo
IAU3LA3GXI7E7eDrqKmrTE2DDFH7vuWFc310AFdXMkeCfg1w+f1GVOIuqmw5rVOs
YTnpKs9q1h6PzySPkrtM7QBei4Dc/GHHmJpAUvWGUWgxwzOans9PMNr4nwPeNAZs
4aR4QQkXLMiBxELN0pI4ua42IQonkhMDHH2JuV3SUpOYKtiiKU89fK3witMRN/Ln
fTDhcs6S2qAPZJson1mRx01PECnfmP/n/930uflgxmTVZNyOqML3/UIyt5J+cV8e
/OxtwtYBeD7YNJaAHRXd0F+vOtCteBQEfMsro4pjG1bx2svEvoQ6fU6nCtopSZtT
OGYAEtP3zbdxDPwfmoiDUDFpfxLwlvoAACafRNSWBN5Q8rvQZd6Vna81nxyQXeUD
WpqPitrr93sFGvCGffVkX6JADwkPp0vgxtmFJ1hhCQPIWRcuQdoU0It945Hf7TOf
OnZuczIamokDkBx7RfvI/6D/WX6E0WHkAS8ZHdb0uTkFIlIpQ2xPyChQGv5AuTC1
nnGzzcjizD+marwruDg+rMQ4NfIWWVuIP2nRlZD7cmVNDN12ndM4nxuwVVXhIPDF
S5IDtchIkU0Djo3OvozeejEpyFI70zsgW9Lxv0mzbJIjwlbTEF8=
=8wKQ
-----END PGP SIGNATURE-----