Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage

[Claudius Heine <ch@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 4067 bytes --]

Quoting Maxim Yu. Osipov (2019-04-26 10:41:16)
> Hi Claudius, Andreas,
> 
> @Andreas
> Your input is very welcome at this topic as you were busy with all this 
> APT keys stuff.
> 
> On 4/26/19 9:36 AM, Claudius Heine wrote:
> > Hi Maxim,
> > 
> > Quoting Maxim Yu. Osipov (2019-04-25 20:20:59)
> >> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote:
> >>> From: Claudius Heine <ch@denx.de>
> >>>
> >>> isar-bootstrap-host only supports bootstrapping Debian root file
> >>> systems. Therefore deactivate any DISTRO_APT_KEYS from other
> >>> distributions.
> >>>
> >>> Signed-off-by: Claudius Heine <ch@denx.de>
> >>> ---
> >>>    meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++
> >>>    1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> >>> index 08b068f..3e96281 100644
> >>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> >>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> >>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}"
> >>>    ISAR_BOOTSTRAP_LOCK = "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${HOST_ARCH}.lock"
> >>>    
> >>>    require isar-bootstrap.inc
> >>> +# We only build debian host buildchroot environments
> >>> +DISTRO_APT_KEYS = ""
> >>
> >>   From the first glance this modification limits functionality.
> >> It looks like a hack and I would suggest to avoid this modification.
> > 
> > Well it is a fix and that limited functionality was already present but
> > just implicit, hidden behind some bug and the cleanup just made it
> > appear.
> 
> 
> Could you please point to this hidden, implicit place where mentioned 
> bug persists?

The HOST_DISTRO is set to 'debian-stretch' in
isar-bootstrap-helper.bbclass (included by isar-bootstrap-host.bb)
results in isar-bootstap-host only bootstrapping debian-stretch
repositories, since the 'HOST_DISTRO_APT_SOURCES' (set in
isar-bootstrap.inc) variable only points to 'debian-stretch.list'.

Yes that is quite a mess of spaghetti code, which this patch set is
trying to sort out somewhat and also probably why this patch set now
reveals some hidden bugs or limitations like this.

A patch later in this patch series sets 'HOST_DISTRO' to 'DISTRO' per
default. But that only opens the possibility to use other debian
versions (buster) for buildchroot-host, not allowing non-debian distros.
So the implicit limitation is somewhat loosened with this patch series.

> And bootstrapping itself (function isar_bootsrap in isar-bootstrap.inc) 
> differs only by passing extra '--arch' to target DISTRO_ARCH. Nothing 
> regarding

Well 'isar-bootstrap-host' does contain some issues that needs fixing but
this is not in scope of this patch series, which focuses mainly on
the rootfs creation process and only secondary on the isar-bootstrap*
stuff.

> >> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to
> >> avoid confusion between target and host apt keys.
> > 
> > Good idea. But that would be a new feature/improvement.
> 
> Yes. But your series is also improvement, isn't?

With that reasoning you could also say that my patch series should fix
every issue in existence because that might be an 'improvement'.

Fixing the world is not in scope of this patch set.

> I need more arguments for introduction of this limitation.

Again, that limitation is already present. I don't get why you are
often so sure of yourself, especially about code you have not written
or worked with intensively.

Claudius

--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de

           PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
                             Keyserver: hkp://pool.sks-keyservers.net

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlzC39sACgkQEXPLGZgI
sVM/lg//XmkmaozLfqJGtO7wVVzu/o8DBe8on1k99BcTQRLZyg1uOwlYt8fSFGFw
3m6t5Gkmbjp8UoVQ4c24Pd3FDrX96HZppenfg+oZT3Gz6hsQ7K1xQ6cgcJ9Zdhjm
ByfLoT2Zc3SymYnXNxPkR0GMD7F8moAnrxmq+DueXTAGJ2INDCUg+su6KxTCApoN
A6Cw/YJ1/LwnVbJuJfx43GsVkuYOaQlZ/b0YTzQ2J2U2AuxEiOrF7IX+jq9CasUQ
+36rCppcl363TYLrtvHq2ybpIBh+Zfc9d3PdNPjAY6YQVxqUH4pQ4+gPsp/hjjGC
l0BsJyxnMmoSnczOfSFC5nWjvE9by65SvoOfkRHiLLUM55ByelpLuyFsCLV2B5vH
TCkxaH6MiWNYJ731GsOMzcSPk4Ncx88edbC221YBS4RQUxp5Kggi+yIVsg718T3M
DpxaU8AbBVNGRMWHRmxpSNi6Q1zkhaOFAMWb3F6iJjeNqW/pslUMOsLGJEFhehfg
gqzkPWLr+dhsHiHGmuo7Kc99RRBduseAwLuuFdGLa0luqjn5N35z2bSWFyXT/pJi
5aDS+v4DQjgcY2CO89jiQcWhJP5zn4i1FcXHjbkGsiQayBbQubmGuDn24OHFwOhT
4QmheXhBpiJYIyH2TKiahIMbHo6xH+n3pxz4YdiUqj3yLOBHeH8=
=3D5v
-----END PGP SIGNATURE-----