From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6683827867816558592 X-Received: by 2002:a1c:2d0e:: with SMTP id t14mr7202131wmt.33.1556275175007; Fri, 26 Apr 2019 03:39:35 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:2d04:: with SMTP id t4ls3748878wmt.4.gmail; Fri, 26 Apr 2019 03:39:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqwOsU7VhnuX8JAhRl/3VNE/aspu8QbZuJnQcGCCsePDvtqt+gXpyNYx5qffE6mveTsvgVqy X-Received: by 2002:a1c:a010:: with SMTP id j16mr7562117wme.40.1556275174565; Fri, 26 Apr 2019 03:39:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556275174; cv=none; d=google.com; s=arc-20160816; b=apO3+h804VOOrtEjTF7YDLxfgoxJiYcAePIJQ5vfWeO3zmiRgTQ552H9fTcf/lkE7C V9/2sbauU45gf16qltq28FNfzz9edqmAADOBhE3UgYNl6j6Yb27oDBolG5m3M0uunuFS FQrmdCAzkwSoefCrZFlb/mszNVhTkldquZtmhpU/lq1oyGhjJM3aNf6k3j78ykVlpbCt IeRxZ+CG5uDuxqL7gZvftG4KnaQEP0WagpA/X54K7lOljK4JogeiATNWD5B+NUSZ8EOF /HbF+Di/pD/vHIeFLJPoI3L9V9CIj0ptpHomQ3OCy15C5lSCjq2hLZRdqXcdP4RD9QQo G9Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:user-agent:message-id:to:subject:from:cc:references :in-reply-to:content-disposition:mime-version; bh=0TFR9AzMD1G5KuqJFJtfhuYEEstgeuhH+RuxyL/H2ww=; b=VkQbUP2dewWXPLnywELQ0faY76ZBiytxnggnMK+CdEguHxNDwfcTFUe5omzrr3IbhT 0gPokTnqi9ELec3emS6kf/lta6FCiq0CtrRajoVkLhPLPgSKQ7939n38iJyxFB/1Vs7s dpU3sS2U4kHqNHCvhSGdJl6rIYM4+0zWPu0+su53J4AXEjUCJ25TjiZbnH7cdgkbvApJ EoCt1LcZlyoKUw6shydewkCjonVoTAiMox+ed6h4j4rSI1G7diea9tOwj+P/OGRYetBC PCubEU8yalrxyPqH5tOLNF8yW1S6WdA2LeIm8ToiYo7lM1Mf7vQtiA5a+DP/kwiZeS3T 57Bw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id l13si436733wmc.1.2019.04.26.03.39.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Apr 2019 03:39:34 -0700 (PDT) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) client-ip=212.18.0.9; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 44r9Xk2N9Qz1rKJH; Fri, 26 Apr 2019 12:39:34 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 44r9Xk211Mz1qySp; Fri, 26 Apr 2019 12:39:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ulWTKlndV4Er; Fri, 26 Apr 2019 12:39:29 +0200 (CEST) X-Auth-Info: uwp31ScGTZohM5zypC5aMLRuyox2Kw964VUSwM+Nsug= Received: from localhost (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 26 Apr 2019 12:39:29 +0200 (CEST) Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="===============5636899727623928693==" MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <89e6b417-265c-b1a6-b151-0938fed5d462@ilbers.de> References: <20190425134450.13443-1-claudius.heine.ext@siemens.com> <20190425134450.13443-2-claudius.heine.ext@siemens.com> <155626421155.10914.2537647574220599237@ardipi> <89e6b417-265c-b1a6-b151-0938fed5d462@ilbers.de> Cc: isar-users@googlegroups.com From: Claudius Heine Subject: Re: [PATCH v4 1/9] isar-bootstrap-host: disable DISTRO_APT_KEYS usage To: "Maxim Yu. Osipov" , Andreas Reichel , claudius.heine.ext@siemens.com Message-ID: <155627516700.10914.10549936123827316965@ardipi> User-Agent: alot/0.8 Date: Fri, 26 Apr 2019 12:39:27 +0200 X-TUID: rBa7bCZl9+x4 --===============5636899727623928693== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Quoting Maxim Yu. Osipov (2019-04-26 10:41:16) > Hi Claudius, Andreas, >=20 > @Andreas > Your input is very welcome at this topic as you were busy with all this=20 > APT keys stuff. >=20 > On 4/26/19 9:36 AM, Claudius Heine wrote: > > Hi Maxim, > >=20 > > Quoting Maxim Yu. Osipov (2019-04-25 20:20:59) > >> On 4/25/19 3:44 PM, claudius.heine.ext@siemens.com wrote: > >>> From: Claudius Heine > >>> > >>> isar-bootstrap-host only supports bootstrapping Debian root file > >>> systems. Therefore deactivate any DISTRO_APT_KEYS from other > >>> distributions. > >>> > >>> Signed-off-by: Claudius Heine > >>> --- > >>> meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb = b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb > >>> index 08b068f..3e96281 100644 > >>> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb > >>> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb > >>> @@ -12,6 +12,8 @@ DEPLOY_ISAR_BOOTSTRAP =3D "${DEPLOY_DIR_BOOTSTRAP}/= ${HOST_DISTRO}-${HOST_ARCH}" > >>> ISAR_BOOTSTRAP_LOCK =3D "${DEPLOY_DIR_BOOTSTRAP}/${HOST_DISTRO}-${= HOST_ARCH}.lock" > >>> =20 > >>> require isar-bootstrap.inc > >>> +# We only build debian host buildchroot environments > >>> +DISTRO_APT_KEYS =3D "" > >> > >> From the first glance this modification limits functionality. > >> It looks like a hack and I would suggest to avoid this modification. > >=20 > > Well it is a fix and that limited functionality was already present but > > just implicit, hidden behind some bug and the cleanup just made it > > appear. >=20 >=20 > Could you please point to this hidden, implicit place where mentioned=20 > bug persists? The HOST_DISTRO is set to 'debian-stretch' in isar-bootstrap-helper.bbclass (included by isar-bootstrap-host.bb) results in isar-bootstap-host only bootstrapping debian-stretch repositories, since the 'HOST_DISTRO_APT_SOURCES' (set in isar-bootstrap.inc) variable only points to 'debian-stretch.list'. Yes that is quite a mess of spaghetti code, which this patch set is trying to sort out somewhat and also probably why this patch set now reveals some hidden bugs or limitations like this. A patch later in this patch series sets 'HOST_DISTRO' to 'DISTRO' per default. But that only opens the possibility to use other debian versions (buster) for buildchroot-host, not allowing non-debian distros. So the implicit limitation is somewhat loosened with this patch series. > And bootstrapping itself (function isar_bootsrap in isar-bootstrap.inc)=20 > differs only by passing extra '--arch' to target DISTRO_ARCH. Nothing=20 > regarding Well 'isar-bootstrap-host' does contain some issues that needs fixing but this is not in scope of this patch series, which focuses mainly on the rootfs creation process and only secondary on the isar-bootstrap* stuff. > >> Some time ago I thought about introduction of HOST_DISTRO_APT_KEYS to > >> avoid confusion between target and host apt keys. > >=20 > > Good idea. But that would be a new feature/improvement. >=20 > Yes. But your series is also improvement, isn't? With that reasoning you could also say that my patch series should fix every issue in existence because that might be an 'improvement'. Fixing the world is not in scope of this patch set. > I need more arguments for introduction of this limitation. Again, that limitation is already present. I don't get why you are often so sure of yourself, especially about code you have not written or worked with intensively. Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 Keyserver: hkp://pool.sks-keyservers.net --===============5636899727623928693== MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Description: signature Content-Type: application/pgp-signature; name="signature.asc"; charset="us-ascii" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlzC39sACgkQEXPLGZgI sVM/lg//XmkmaozLfqJGtO7wVVzu/o8DBe8on1k99BcTQRLZyg1uOwlYt8fSFGFw 3m6t5Gkmbjp8UoVQ4c24Pd3FDrX96HZppenfg+oZT3Gz6hsQ7K1xQ6cgcJ9Zdhjm ByfLoT2Zc3SymYnXNxPkR0GMD7F8moAnrxmq+DueXTAGJ2INDCUg+su6KxTCApoN A6Cw/YJ1/LwnVbJuJfx43GsVkuYOaQlZ/b0YTzQ2J2U2AuxEiOrF7IX+jq9CasUQ +36rCppcl363TYLrtvHq2ybpIBh+Zfc9d3PdNPjAY6YQVxqUH4pQ4+gPsp/hjjGC l0BsJyxnMmoSnczOfSFC5nWjvE9by65SvoOfkRHiLLUM55ByelpLuyFsCLV2B5vH TCkxaH6MiWNYJ731GsOMzcSPk4Ncx88edbC221YBS4RQUxp5Kggi+yIVsg718T3M DpxaU8AbBVNGRMWHRmxpSNi6Q1zkhaOFAMWb3F6iJjeNqW/pslUMOsLGJEFhehfg gqzkPWLr+dhsHiHGmuo7Kc99RRBduseAwLuuFdGLa0luqjn5N35z2bSWFyXT/pJi 5aDS+v4DQjgcY2CO89jiQcWhJP5zn4i1FcXHjbkGsiQayBbQubmGuDn24OHFwOhT 4QmheXhBpiJYIyH2TKiahIMbHo6xH+n3pxz4YdiUqj3yLOBHeH8= =3D5v -----END PGP SIGNATURE----- --===============5636899727623928693==--