From: Cedric Hombourger <Cedric_Hombourger@mentor.com>
To: <isar-users@googlegroups.com>
Cc: Cedric Hombourger <Cedric_Hombourger@mentor.com>
Subject: [PATCH v4 - misc fixes 1/6] wic-img: do not leave temporary files behind
Date: Fri, 8 Nov 2019 10:23:18 +0100 [thread overview]
Message-ID: <1573205003-1335-2-git-send-email-Cedric_Hombourger@mentor.com> (raw)
In-Reply-To: <1573205003-1335-1-git-send-email-Cedric_Hombourger@mentor.com>
We do not seem to make any use of the timestamped wic images being
generated and worse we are leaving them in the buildchroot tmp folder.
"mv" the generated files instead of "cp"'ing them to the deploy
directory.
Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
---
meta/classes/wic-img.bbclass | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/meta/classes/wic-img.bbclass b/meta/classes/wic-img.bbclass
index 795640f..24c3b65 100644
--- a/meta/classes/wic-img.bbclass
+++ b/meta/classes/wic-img.bbclass
@@ -155,8 +155,12 @@ EOSUDO
-e ${IMAGE_BASENAME} ${WIC_CREATE_EXTRA_ARGS}
sudo chown -R $(stat -c "%U" ${ISARROOT}) ${ISARROOT}/meta ${ISARROOT}/meta-isar ${ISARROOT}/scripts || true
WIC_DIRECT=$(ls -t -1 ${BUILDCHROOT_DIR}/$WICTMP/${IMAGE_FULLNAME}.wic/*.direct | head -1)
- cp -f ${WIC_DIRECT} ${WIC_IMAGE_FILE}
- cp -f ${WIC_DIRECT}.bmap ${WIC_IMAGE_FILE}.bmap
+ sudo chown $(stat -c "%U:%G" ${ISARROOT}) ${WIC_DIRECT} ${WIC_DIRECT}.bmap
+ sudo mv -f ${WIC_DIRECT} ${WIC_IMAGE_FILE}
+ sudo mv -f ${WIC_DIRECT}.bmap ${WIC_IMAGE_FILE}.bmap
+ sudo rmdir --ignore-fail-on-non-empty \
+ ${BUILDCHROOT_DIR}/${WICTMP}/${IMAGE_FULLNAME}.wic \
+ ${BUILDCHROOT_DIR}/${WICTMP}
}
do_wic_image[file-checksums] += "${WKS_FILE_CHECKSUM}"
--
2.20.1
next prev parent reply other threads:[~2019-11-08 9:23 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 9:34 [PATCH 0/4] miscellaneous (minor) fixes Cedric Hombourger
2019-10-21 9:34 ` [PATCH 1/4] wic-img: do not leave temporary files behind Cedric Hombourger
2019-10-21 9:34 ` [PATCH 2/4] isar-bootstrap: wipe out previously created rootfs with --one-file-system Cedric Hombourger
2019-10-21 9:34 ` [PATCH 3/4] base-apt-helper: fixed a few typos found in comments Cedric Hombourger
2019-10-21 9:34 ` [PATCH 4/4] patch: suffix patch files copied to .applied_patches with "~" Cedric Hombourger
2019-10-21 11:26 ` Henning Schild
2019-10-21 11:36 ` Cedric Hombourger
2019-10-21 12:43 ` Henning Schild
2019-10-21 12:53 ` Cedric Hombourger
2019-10-21 15:08 ` [PATCH v2 0/5] miscellaneous (minor) fixes Cedric Hombourger
2019-10-21 15:08 ` [PATCH v2 1/5] wic-img: do not leave temporary files behind Cedric Hombourger
2019-10-21 15:08 ` [PATCH v2 2/5] isar-bootstrap: wipe out previously created rootfs with --one-file-system Cedric Hombourger
2019-10-21 15:08 ` [PATCH v2 3/5] base-apt-helper: fixed a few typos found in comments Cedric Hombourger
2019-10-21 15:08 ` [PATCH v2 4/5] patch: suffix patch files copied to .applied_patches with "~" Cedric Hombourger
2019-10-21 15:10 ` [PATCH v2 5/5] hello: add a sample patch to exercise patch.bbclass against dpkg recipes Cedric Hombourger
2019-10-25 17:15 ` [PATCH 4/4] patch: suffix patch files copied to .applied_patches with "~" Jan Kiszka
2019-10-25 17:58 ` Cedric Hombourger
2019-11-05 12:52 ` [PATCH v3 0/6] miscellaneous (minor) fixes Cedric Hombourger
2019-11-05 12:53 ` [PATCH v3 1/6] wic-img: do not leave temporary files behind Cedric Hombourger
2019-11-05 12:53 ` [PATCH v3 2/6] isar-bootstrap: wipe out previously created rootfs with --one-file-system Cedric Hombourger
2019-11-05 12:53 ` [PATCH v3 3/6] base-apt-helper: fixed a few typos found in comments Cedric Hombourger
2019-11-05 12:53 ` [PATCH v3 4/6] ci_build.sh: delay "set -x" for a clean --help output Cedric Hombourger
2019-11-05 12:53 ` [PATCH v3 5/6] linux-custom: honor KERNEL_FILE setting Cedric Hombourger
2019-11-05 12:53 ` [PATCH v3 6/6] bitbake.conf: set name of the qemu-static binary to use for mipsel Cedric Hombourger
2019-11-08 9:23 ` [PATCH v4 - misc fixes 0/6] miscellaneous (minor) fixes Cedric Hombourger
2019-11-08 9:23 ` Cedric Hombourger [this message]
2019-11-15 13:38 ` [PATCH v4 - misc fixes 1/6] wic-img: do not leave temporary files behind Jan Kiszka
2019-11-15 13:42 ` Cedric Hombourger
2019-11-15 17:00 ` [PATCH v5 0/6] miscellaneous (minor) fixes Cedric Hombourger
2019-11-15 17:00 ` [PATCH v5 1/6] wic-img: do not leave temporary files behind Cedric Hombourger
2019-11-15 17:00 ` [PATCH v5 2/6] isar-bootstrap: wipe out previously created rootfs with --one-file-system Cedric Hombourger
2019-11-15 17:00 ` [PATCH v5 3/6] base-apt-helper: fixed a few typos found in comments Cedric Hombourger
2019-11-15 17:00 ` [PATCH v5 4/6] ci_build.sh: delay "set -x" for a clean --help output Cedric Hombourger
2019-11-15 17:00 ` [PATCH v5 5/6] linux-custom: honor KERNEL_FILE setting Cedric Hombourger
2019-11-15 17:00 ` [PATCH v5 6/6] bitbake.conf: set name of the qemu-static binary to use for mipsel Cedric Hombourger
2019-11-20 12:39 ` [PATCH v5 0/6] miscellaneous (minor) fixes Baurzhan Ismagulov
2019-11-08 9:23 ` [PATCH v4 - misc fixes 2/6] isar-bootstrap: wipe out previously created rootfs with --one-file-system Cedric Hombourger
2019-11-08 9:23 ` [PATCH v4 - misc fixes 3/6] base-apt-helper: fixed a few typos found in comments Cedric Hombourger
2019-11-08 9:23 ` [PATCH v4 - misc fixes 4/6] ci_build.sh: delay "set -x" for a clean --help output Cedric Hombourger
2019-11-08 9:24 ` [PATCH v4 - misc fixes 5/6] linux-custom: honor KERNEL_FILE setting Cedric Hombourger
2019-11-08 9:24 ` [PATCH v4 - misc fixes 6/6] bitbake.conf: set name of the qemu-static binary to use for mipsel Cedric Hombourger
2019-11-12 19:20 ` [PATCH v4 - misc fixes 0/6] miscellaneous (minor) fixes chombourger
2019-11-14 17:01 ` Baurzhan Ismagulov
2019-11-15 16:59 ` chombourger
2019-11-19 16:56 ` Baurzhan Ismagulov
2019-11-15 13:34 ` chombourger
2019-11-15 13:39 ` Baurzhan Ismagulov
2019-11-15 13:39 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573205003-1335-2-git-send-email-Cedric_Hombourger@mentor.com \
--to=cedric_hombourger@mentor.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox