public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Alexander Smirnov <asmirnov@ilbers.de>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	"isar-users" <isar-users@googlegroups.com>
Subject: Re: [PATCH 5/6] dpkg-raw: Clean DEBIAN dir prior to filling it
Date: Tue, 13 Feb 2018 19:31:39 +0300	[thread overview]
Message-ID: <1619001e5f8.27ac.034a6b0541ed39b7fb4e17f4ac219eaa@ilbers.de> (raw)
In-Reply-To: <038079cd-cae7-cf0f-82e9-79d14d536e61@siemens.com>




Jan Kiszka <jan.kiszka@siemens.com> 13 февраля 2018 г. 19:22:23 написал:

> On 2018-02-13 15:06, Alexander Smirnov wrote:
>>
>>
>> On 02/12/2018 10:59 AM, Jan Kiszka wrote:
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> When we run unprivileged, writing files in that directory will not work
>>> after the first run because everything is root-owned at the end.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>> ---
>>>   meta/classes/dpkg-raw.bbclass | 5 ++---
>>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/meta/classes/dpkg-raw.bbclass
>>> b/meta/classes/dpkg-raw.bbclass
>>> index 44aa078..e3ae9e8 100644
>>> --- a/meta/classes/dpkg-raw.bbclass
>>> +++ b/meta/classes/dpkg-raw.bbclass
>>> @@ -16,10 +16,9 @@ do_install() {
>>>   do_install[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
>>>   addtask install after do_unpack before do_deb_package_prepare
>>>   -# so we can put hooks etc. in there already
>>> -do_install[dirs] = "${D}/DEBIAN"
>>
>> Here you remove this folder, while it's used in example-raw recipe.

I mean here you break the build for next and master.

Alex

>> > Alex
>>
>>> -
>>>   do_deb_package_prepare() {
>>> +    sudo rm -rf ${D}/DEBIAN
>>> +    mkdir ${D}/DEBIAN
>
> It is created here now - nothing is lost. If you tell me a good reason
> to keep it listed above as well, I'm fine with leaving that line alone.
>
> Jan
>
>>>       cat<<-__EOF__ > ${D}/DEBIAN/control
>>>           Package: ${PN}
>>>           Architecture: ${DISTRO_ARCH}
>>>
>
--
With best regards,
Alexander Smirnov

ilbers GmbH
Baierbrunner Str. 28c
D-81379 Munich
+49 (89) 122 67 24-0
http://ilbers.de/
Commercial register Munich, HRB 214197
General manager: Baurzhan Ismagulov



  reply	other threads:[~2018-02-13 16:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12  7:59 [PATCH 0/6] Add support for automatic partial rebuilds on recipe changes Jan Kiszka
2018-02-12  7:59 ` [PATCH 1/6] Fix indention of base_do_build Jan Kiszka
2018-02-12  7:59 ` [PATCH 2/6] Add clean and cleanall tasks Jan Kiszka
2018-02-13 12:49   ` Alexander Smirnov
2018-02-13 12:51     ` Jan Kiszka
2018-02-12  7:59 ` [PATCH 3/6] Enable recipe caching Jan Kiszka
2018-02-12  7:59 ` [PATCH 4/6] Enable proper rebuilds on dependency changes Jan Kiszka
2018-02-13 13:03   ` Alexander Smirnov
2018-02-13 16:21     ` Jan Kiszka
2018-02-13 17:57       ` Jan Kiszka
2018-02-13 18:08         ` Alexander Smirnov
2018-02-13 18:44           ` Jan Kiszka
2018-02-13 19:02             ` Alexander Smirnov
2018-02-13 19:22               ` Jan Kiszka
2018-02-13 19:38                 ` Alexander Smirnov
2018-02-13 20:04                   ` Jan Kiszka
2018-02-12  7:59 ` [PATCH 5/6] dpkg-raw: Clean DEBIAN dir prior to filling it Jan Kiszka
2018-02-13 14:06   ` Alexander Smirnov
2018-02-13 16:22     ` Jan Kiszka
2018-02-13 16:31       ` Alexander Smirnov [this message]
2018-02-13 16:33         ` Jan Kiszka
2018-02-12  7:59 ` [PATCH 6/6] isar-image-base: Clean rootfs folder prior to building Jan Kiszka
2018-02-13 13:49   ` Alexander Smirnov
2018-02-13 16:24     ` Jan Kiszka
2018-02-13  7:40 ` [PATCH 0/6] Add support for automatic partial rebuilds on recipe changes Jan Kiszka
2018-02-13 14:01 ` Alexander Smirnov
2018-02-13 16:28   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1619001e5f8.27ac.034a6b0541ed39b7fb4e17f4ac219eaa@ilbers.de \
    --to=asmirnov@ilbers.de \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox