From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6522397978051739648 X-Received: by 10.223.144.69 with SMTP id h63mr868895wrh.24.1518698218693; Thu, 15 Feb 2018 04:36:58 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.26.132 with SMTP id a126ls13871wma.1.canary-gmail; Thu, 15 Feb 2018 04:36:58 -0800 (PST) X-Google-Smtp-Source: AH8x224xnrM67DaOEe8say6O9qfJg6gpVlN/VPB3LHlMhSr04FIQjYnFSi6FGtzZ7tQKCM8QI5FX X-Received: by 10.28.192.4 with SMTP id q4mr869724wmf.25.1518698218163; Thu, 15 Feb 2018 04:36:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518698218; cv=none; d=google.com; s=arc-20160816; b=x6ZpovfVVO+B7UzIawXXH3yPj5Kc63bVV0CH5Cn5vpV1XJyi4HmoybMOB0m6smqML9 A7LXAqSEuVeOXiPuwefaDrA6peXqnexcAlc5WOcIieyewK/iRMhO30f7u6kF/8itrBzB uX4QTZBqiMx/mu5csEog/iJBlAEYG1o5pkd2R69FAhhxXhLwb1ScHr4lqMHI+zydwaHH bVhCPPremNE61X1AAsmVKIzkapnTNMtLdkswte2yLcaOLu/NBkIGaiZBOiDMGRHHhC2n xzue+zEVwbi6zrws5abJwc3nkOMWfS9KvlbTKPmx0+F58xA+Bv/Vkx4HWjnQh/rQnEhH XtMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:to:from :arc-authentication-results; bh=LqcwHOMjYY5khhEtNq0y9iKGMxZmIrpQhnyb7ld4ryg=; b=KYbceeE+qaMUUne88Y8vOOpQjkx54LD/ZT1KVHGgyNr0wr6p+58ltZ2qF/V5Y3/48A rJkyM/TfTwjtnus7dbR14+xVizbz7IFPRkAmi5q+uVp8GKAr7xEuazVa52ZpYXr+YYwB 00BSwxscZANYg9lZx89XDGuYptySQNzY8mwqcTgM5kZdqYj0V44DWs+1HagXppI3HyrM v1KbrDdDj0KfcCeIufjxz7QM/IQhU3X2Ll1apqQLHFHsd+MbTJtETVeR38rgoeav1i7N C2NypM7DmF8moQ+4rF95FV62SyLkoAz4qH/2QAe3eRAezQPwxElY8QYFQf+Vz7ZRdPPH tPWg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id q6si835745wrc.4.2018.02.15.04.36.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Feb 2018 04:36:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [100.101.108.201] ([188.170.73.244]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w1FCatFq014319; Thu, 15 Feb 2018 13:36:56 +0100 From: Alexander Smirnov To: Claudius Heine , , Baurzhan Ismagulov Date: Thu, 15 Feb 2018 15:37:09 +0300 Message-ID: <1619976eb38.27ac.034a6b0541ed39b7fb4e17f4ac219eaa@ilbers.de> In-Reply-To: References: <20180214131509.16361-1-claudius.heine.ext@siemens.com> <20180214131509.16361-3-claudius.heine.ext@siemens.com> <20180215114214.GC5374@yssyq.radix50.net> User-Agent: AquaMail/1.10.0-403 (build: 101000001) Subject: Re: [PATCH 2/2] centralize multistrap configuration generation MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="UTF-8" Content-Transfer-Encoding: 8bit X-TUID: jUBJ64RatS6B Claudius Heine 15 февраля 2018 г. 15:08:50 написал: > Hi Baurzhan, > > On 02/15/2018 12:42 PM, Baurzhan Ismagulov wrote: >> On Wed, Feb 14, 2018 at 02:15:09PM +0100, claudius.heine.ext@siemens.com wrote: >>> From: Claudius Heine >>> >>> Previous there was redundant code between the buildchroot and >>> isar-image-base recipe. >>> >>> This patch moves the generation of the multistrap configuration to a >>> central python script that can be parametrized by both recipes. >>> >>> Signed-off-by: Claudius Heine >>> --- >>> .../recipes-core/images/files/multistrap.conf.in | 38 ---------- >>> meta/lib/isar/multistrap.py | 80 ++++++++++++++++++++++ >>> .../buildchroot/files/multistrap.conf.in | 37 ---------- >> >> Could you please post two final multistrap.confs you'd like to get with your >> changes? > > 'like to get'? I don't want to get any other multistrap.conf than > before. This is not a change of the multistrap.conf files, but just how > they are generated. The python configparser created ini-file format only > puts spaces around the '=' characters, but the resulting deserialized > objects is the same. The difference that I see IMHO: now you need to feed multistrap by community-standardized input, you propose to add custom tool that eats proprietary input. > > Ok, that is not 100% true, I changed the name of the isar repository > section. Now its called 'isar' in the image (previously 'Isar') and > buildchroot (previously 'isar-apt') multiconfig. But that is it. It has > no different effect outside of multistrap. > >> I'd like to understand the reasons for moving from templates to a magic >> generator. >> >> In my experience, magic is usually poorly documented (if at all) and very >> ununderstandable for users. Simple change of a line requires locating the >> generator, understanding what it does (they tend to be hairy with tons of >> conditions) and patching the upstream [Isar] code. Templates have their >> disadvantages, but are straightforward for users. In general, I'd like to keep >> the current UX and stick with templates, which is possible most of the time. > > You prefer duplicated code? Two slightly different templates for two > buildchroot and image recipe? > AFAIK the key idea is to have the only single multistrap that works with upstream repos. Other multistraps fetch packages from local cache. So after this is done, the problem with duplicacations in configs will go. > Also this patch is only an intermediate step of the way for multi-repo > support. IMO it has value on its own, since it centralized the > generation of the multistrap configuration. > The current kind of 'template' does not support creating repository > entries on the fly. What is the use case to have them "on the fly"? Alex It might be possible to extent the multiconfig with > shell scripting, but I prefer using python for such advanced logic. I don't care about python or bash > > regards, > Claudius > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de > > -- > You received this message because you are subscribed to the Google Groups > "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to isar-users+unsubscribe@googlegroups.com. > To post to this group, send email to isar-users@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/isar-users/d58343b9-c284-81e7-f743-2672c1f5f8ef%40siemens.com. > For more options, visit https://groups.google.com/d/optout.