* [PATCH 1/3] isar-bootstrap|configscript: implement one shot config option
2018-05-23 12:17 [PATCH 0/3] One-shot configuration packages claudius.heine.ext
@ 2018-05-23 12:17 ` claudius.heine.ext
2018-05-23 12:17 ` [PATCH 2/3] meta/isar-cfg-localepurge: added locale purge recipe claudius.heine.ext
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: claudius.heine.ext @ 2018-05-23 12:17 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine
From: Claudius Heine <ch@denx.de>
Some configuration tasks on the image require certain other packages,
but those packages might not be required on the final image.
One way to solve this is use a special package that is installed to the
image and then removed again. When installing it makes certain that all
required packages are installed to the image as well. Then the image
can be configured in the postinst hook. When this package is removed and
all unused dependencies are removed as well, no not required packages
used by this package should remain on the image.
Signed-off-by: Claudius Heine <ch@denx.de>
---
.../images/files/debian-configscript.sh | 1 -
.../images/files/raspbian-configscript.sh | 1 -
meta/classes/isar-bootstrap-helper.bbclass | 23 +++++++++++++++----
3 files changed, 19 insertions(+), 6 deletions(-)
diff --git a/meta-isar/recipes-core/images/files/debian-configscript.sh b/meta-isar/recipes-core/images/files/debian-configscript.sh
index 042b530..0ff2f0f 100755
--- a/meta-isar/recipes-core/images/files/debian-configscript.sh
+++ b/meta-isar/recipes-core/images/files/debian-configscript.sh
@@ -62,4 +62,3 @@ fi
# Purge unused locale and installed packages' .deb files
localepurge
-apt-get clean
diff --git a/meta-isar/recipes-core/images/files/raspbian-configscript.sh b/meta-isar/recipes-core/images/files/raspbian-configscript.sh
index ec05a6b..47c9c37 100644
--- a/meta-isar/recipes-core/images/files/raspbian-configscript.sh
+++ b/meta-isar/recipes-core/images/files/raspbian-configscript.sh
@@ -62,4 +62,3 @@ kernel=$KERNEL_IMAGE
EOF
localepurge
-apt-get clean
diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass
index 4284d02..76e20f6 100644
--- a/meta/classes/isar-bootstrap-helper.bbclass
+++ b/meta/classes/isar-bootstrap-helper.bbclass
@@ -5,15 +5,17 @@
#
# SPDX-License-Identifier: MIT
+IMAGE_CFG_PACKAGE ??= ""
+
setup_root_file_system() {
ROOTFSDIR="$1"
- CLEANHOSTLEAK="$2"
+ CLEAN="$2"
shift
shift
PACKAGES="$@"
APT_ARGS="install --yes --allow-unauthenticated \
-o Debug::pkgProblemResolver=yes"
- CLEANHOSTLEAK_FILES="${ROOTFSDIR}/etc/hostname ${ROOTFSDIR}/etc/resolv.conf"
+ CLEAN_FILES="${ROOTFSDIR}/etc/hostname ${ROOTFSDIR}/etc/resolv.conf"
sudo cp -Trpfx \
"${DEPLOY_DIR_IMAGE}/isar-bootstrap-${DISTRO}-${DISTRO_ARCH}/" \
@@ -41,8 +43,21 @@ setup_root_file_system() {
-o Dir::Etc::sourceparts="-" \
-o APT::Get::List-Cleanup="0"
sudo -E chroot "$ROOTFSDIR" \
- /usr/bin/apt-get ${APT_ARGS} --download-only $PACKAGES
- [ "clean" = ${CLEANHOSTLEAK} ] && sudo rm -f ${CLEANHOSTLEAK_FILES}
+ /usr/bin/apt-get ${APT_ARGS} --download-only $PACKAGES \
+ ${IMAGE_CFG_PACKAGE}
+ [ "clean" = ${CLEAN} ] && sudo rm -f ${CLEAN_FILES}
sudo -E chroot "$ROOTFSDIR" \
/usr/bin/apt-get ${APT_ARGS} $PACKAGES
+ if [ -n "${IMAGE_CFG_PACKAGE}" ]; then
+ sudo -E chroot "$ROOTFSDIR" \
+ /usr/bin/apt-get ${APT_ARGS} ${IMAGE_CFG_PACKAGE}
+ sudo -E chroot "$ROOTFSDIR" \
+ /usr/bin/apt-get purge -y ${IMAGE_CFG_PACKAGE}
+ fi
+ if [ "clean" = ${CLEAN} ]; then
+ sudo -E chroot "$ROOTFSDIR" \
+ /usr/bin/apt-get autoremove --purge -y
+ sudo -E chroot "$ROOTFSDIR" \
+ /usr/bin/apt-get clean
+ fi
}
--
2.17.0
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 2/3] meta/isar-cfg-localepurge: added locale purge recipe
2018-05-23 12:17 [PATCH 0/3] One-shot configuration packages claudius.heine.ext
2018-05-23 12:17 ` [PATCH 1/3] isar-bootstrap|configscript: implement one shot config option claudius.heine.ext
@ 2018-05-23 12:17 ` claudius.heine.ext
2018-05-23 12:18 ` [PATCH 3/3] meta-isar/isar-image-base: switch use isar-cfg-localepurge claudius.heine.ext
2018-05-23 12:56 ` [PATCH 0/3] One-shot configuration packages Claudius Heine
3 siblings, 0 replies; 8+ messages in thread
From: claudius.heine.ext @ 2018-05-23 12:17 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine
From: Claudius Heine <ch@denx.de>
The package 'isar-cfg-localepurge' is used to set the locales of the
root file system and purge all not required locales.
Signed-off-by: Claudius Heine <ch@denx.de>
---
.../isar-cfg-localepurge/files/locale.debconf | 12 ++++++++
.../isar-cfg-localepurge/files/locale.gen | 1 +
.../isar-cfg-localepurge/files/postinst | 30 +++++++++++++++++++
.../isar-cfg-localepurge.bb | 19 ++++++++++++
4 files changed, 62 insertions(+)
create mode 100644 meta/recipes-support/isar-cfg-localepurge/files/locale.debconf
create mode 100644 meta/recipes-support/isar-cfg-localepurge/files/locale.gen
create mode 100644 meta/recipes-support/isar-cfg-localepurge/files/postinst
create mode 100644 meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb
diff --git a/meta/recipes-support/isar-cfg-localepurge/files/locale.debconf b/meta/recipes-support/isar-cfg-localepurge/files/locale.debconf
new file mode 100644
index 0000000..169c071
--- /dev/null
+++ b/meta/recipes-support/isar-cfg-localepurge/files/locale.debconf
@@ -0,0 +1,12 @@
+locales locales/locales_to_be_generated multiselect en_US.UTF-8 UTF-8
+locales locales/default_environment_locale select en_US.UTF-8
+
+localepurge localepurge/dontbothernew boolean true
+localepurge localepurge/nopurge multiselect en, en_US, en_US.UTF-8
+localepurge localepurge/use-dpkg-feature boolean false
+localepurge localepurge/verbose boolean false
+localepurge localepurge/showfreedspace boolean false
+localepurge localepurge/none_selected boolean false
+localepurge localepurge/mandelete boolean true
+localepurge localepurge/quickndirtycalc boolean false
+localepurge localepurge/remove_no note
diff --git a/meta/recipes-support/isar-cfg-localepurge/files/locale.gen b/meta/recipes-support/isar-cfg-localepurge/files/locale.gen
new file mode 100644
index 0000000..a66d814
--- /dev/null
+++ b/meta/recipes-support/isar-cfg-localepurge/files/locale.gen
@@ -0,0 +1 @@
+en_US.UTF-8 UTF-8
diff --git a/meta/recipes-support/isar-cfg-localepurge/files/postinst b/meta/recipes-support/isar-cfg-localepurge/files/postinst
new file mode 100644
index 0000000..3ef93cd
--- /dev/null
+++ b/meta/recipes-support/isar-cfg-localepurge/files/postinst
@@ -0,0 +1,30 @@
+#!/bin/sh
+set -e
+
+cat /usr/local/etc/isar-cfg-localepurge/locale.gen \
+ >> /etc/locale.gen
+
+debconf-set-selections /usr/local/etc/isar-cfg-localepurge/locale.debconf
+
+# locale.nopurge needs to be removed before localepurge is reconfigured.
+# Otherwise it would set the debconf to the values from the locale.nopurge
+# file again.
+rm -rf /etc/locale.nopurge
+dpkg-reconfigure -f noninteractive locales localepurge
+
+# When /etc/locale.nopurge was removed before dpkg-reconfigure, it writes
+# the new configuration with the '.ucf-dist' postfix
+mv /etc/locale.nopurge.ucf-dist /etc/locale.nopurge
+
+# Now reconfigure it localpurge again, because otherwise it would complain:
+# Some new locales have appeared on your system:
+#
+# bal be@latin en@boldquot en@quot sr@latin
+#
+# They will not be touched until you reconfigure localepurge
+# with the following command:
+#
+# dpkg-reconfigure localepurge
+dpkg-reconfigure -f noninteractive localepurge
+
+localepurge
diff --git a/meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb b/meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb
new file mode 100644
index 0000000..b68a6d0
--- /dev/null
+++ b/meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb
@@ -0,0 +1,19 @@
+# This software is a part of ISAR.
+
+DESCRIPTION = "Isar configuration package for locale and localepurge"
+MAINTAINER = "isar-users <isar-users@googlegroups.com>"
+DEBIAN_DEPENDS = "localepurge"
+
+SRC_URI = "file://locale.debconf \
+ file://locale.gen \
+ file://postinst"
+
+inherit dpkg-raw
+
+do_install() {
+ install -v -d ${D}/usr/local/etc/${PN}
+ install -v -m 644 ${WORKDIR}/locale.debconf \
+ ${D}/usr/local/etc/${PN}/locale.debconf
+ install -v -m 644 ${WORKDIR}/locale.gen \
+ ${D}/usr/local/etc/${PN}/locale.gen
+}
--
2.17.0
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 3/3] meta-isar/isar-image-base: switch use isar-cfg-localepurge
2018-05-23 12:17 [PATCH 0/3] One-shot configuration packages claudius.heine.ext
2018-05-23 12:17 ` [PATCH 1/3] isar-bootstrap|configscript: implement one shot config option claudius.heine.ext
2018-05-23 12:17 ` [PATCH 2/3] meta/isar-cfg-localepurge: added locale purge recipe claudius.heine.ext
@ 2018-05-23 12:18 ` claudius.heine.ext
2018-05-23 12:56 ` [PATCH 0/3] One-shot configuration packages Claudius Heine
3 siblings, 0 replies; 8+ messages in thread
From: claudius.heine.ext @ 2018-05-23 12:18 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine
From: Claudius Heine <ch@denx.de>
This patch removes the locale setting from the *-configscripts and
instead uses the isar-cfg-localepurge configuration package.
The advantange is that the package 'localepurge' is no longer installed
on every image and locale settings is done in a central place.
Signed-off-by: Claudius Heine <ch@denx.de>
---
.../images/files/debian-configscript.sh | 30 -------------------
.../images/files/raspbian-configscript.sh | 29 ------------------
.../recipes-core/images/isar-image-base.bb | 6 ++--
3 files changed, 3 insertions(+), 62 deletions(-)
diff --git a/meta-isar/recipes-core/images/files/debian-configscript.sh b/meta-isar/recipes-core/images/files/debian-configscript.sh
index 0ff2f0f..136918c 100755
--- a/meta-isar/recipes-core/images/files/debian-configscript.sh
+++ b/meta-isar/recipes-core/images/files/debian-configscript.sh
@@ -10,33 +10,6 @@ readonly BAUDRATE_TTY="$2"
readonly ROOTFS_DEV="$3"
readonly ROOTFS_TYPE="$4"
-cat >> /etc/default/locale << EOF
-LANG=en_US.UTF-8
-LANGUAGE=en_US.UTF-8
-LC_ALL=C
-LC_CTYPE=C
-EOF
-
-## Configuration file for localepurge(8)
-cat > /etc/locale.nopurge << EOF
-
-# Remove localized man pages
-MANDELETE
-
-# Delete new locales which appear on the system without bothering you
-DONTBOTHERNEWLOCALE
-
-# Keep these locales after package installations via apt-get(8)
-en
-en_US
-en_US.UTF-8
-EOF
-
-debconf-set-selections <<END
-locales locales/locales_to_be_generated multiselect en_US.UTF-8 UTF-8
-locales locales/default_environment_locale select en_US.UTF-8
-END
-
cat > /etc/fstab << EOF
# Begin /etc/fstab
/dev/$ROOTFS_DEV / $ROOTFS_TYPE defaults 1 1
@@ -59,6 +32,3 @@ if [ -f /etc/inittab ]; then
echo "T0:23:respawn:/sbin/getty -L $MACHINE_SERIAL $BAUDRATE_TTY vt100" \
>> /etc/inittab
fi
-
-# Purge unused locale and installed packages' .deb files
-localepurge
diff --git a/meta-isar/recipes-core/images/files/raspbian-configscript.sh b/meta-isar/recipes-core/images/files/raspbian-configscript.sh
index 47c9c37..04ea571 100644
--- a/meta-isar/recipes-core/images/files/raspbian-configscript.sh
+++ b/meta-isar/recipes-core/images/files/raspbian-configscript.sh
@@ -10,33 +10,6 @@ readonly BAUDRATE_TTY="$2"
readonly ROOTFS_DEV="$3"
readonly ROOTFS_TYPE="$4"
-cat >> /etc/default/locale << EOF
-LANG=en_US.UTF-8
-LANGUAGE=en_US.UTF-8
-LC_ALL=C
-LC_CTYPE=C
-EOF
-
-## Configuration file for localepurge(8)
-cat > /etc/locale.nopurge << EOF
-
-# Remove localized man pages
-MANDELETE
-
-# Delete new locales which appear on the system without bothering you
-DONTBOTHERNEWLOCALE
-
-# Keep these locales after package installations via apt-get(8)
-en
-en_US
-en_US.UTF-8
-EOF
-
-debconf-set-selections <<END
-locales locales/locales_to_be_generated multiselect en_US.UTF-8 UTF-8
-locales locales/default_environment_locale select en_US.UTF-8
-END
-
cat > /etc/fstab << EOF
# Begin /etc/fstab
/dev/$ROOTFS_DEV / $ROOTFS_TYPE defaults 1 1
@@ -60,5 +33,3 @@ KERNEL_IMAGE=`ls /boot | grep vmlinuz`
cat > /boot/config.txt << EOF
kernel=$KERNEL_IMAGE
EOF
-
-localepurge
diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb
index baac531..beb6f14 100644
--- a/meta-isar/recipes-core/images/isar-image-base.bb
+++ b/meta-isar/recipes-core/images/isar-image-base.bb
@@ -16,11 +16,11 @@ PV = "1.0"
inherit image
inherit isar-bootstrap-helper
-DEPENDS += "${IMAGE_INSTALL}"
+DEPENDS += "${IMAGE_INSTALL} ${IMAGE_CFG_PACKAGE}"
IMAGE_PREINSTALL += "apt \
- dbus \
- localepurge"
+ dbus"
+IMAGE_CFG_PACKAGE += "isar-cfg-localepurge"
WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}"
--
2.17.0
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 0/3] One-shot configuration packages
2018-05-23 12:17 [PATCH 0/3] One-shot configuration packages claudius.heine.ext
` (2 preceding siblings ...)
2018-05-23 12:18 ` [PATCH 3/3] meta-isar/isar-image-base: switch use isar-cfg-localepurge claudius.heine.ext
@ 2018-05-23 12:56 ` Claudius Heine
2018-05-23 13:16 ` Alexander Smirnov
3 siblings, 1 reply; 8+ messages in thread
From: Claudius Heine @ 2018-05-23 12:56 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine
Hi.
I apparently need to do a v2 for this, since Alex 'Last fixes for
locales' patchset was on the fast lane and has gone to next and
simultaneously to master without any time to review it.
Claudius
On 2018-05-23 14:17, [ext] claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
>
> Hi,
>
> here is my implementation of one-shot packages.
>
> I also implemented a packages that does the localepurge step.
>
> Claudius
>
> Claudius Heine (3):
> isar-bootstrap|configscript: implement one shot config option
> meta/isar-cfg-localepurge: added locale purge recipe
> meta-isar/isar-image-base: switch use isar-cfg-localepurge
>
> .../images/files/debian-configscript.sh | 31 -------------------
> .../images/files/raspbian-configscript.sh | 30 ------------------
> .../recipes-core/images/isar-image-base.bb | 6 ++--
> meta/classes/isar-bootstrap-helper.bbclass | 23 +++++++++++---
> .../isar-cfg-localepurge/files/locale.debconf | 12 +++++++
> .../isar-cfg-localepurge/files/locale.gen | 1 +
> .../isar-cfg-localepurge/files/postinst | 30 ++++++++++++++++++
> .../isar-cfg-localepurge.bb | 19 ++++++++++++
> 8 files changed, 84 insertions(+), 68 deletions(-)
> create mode 100644 meta/recipes-support/isar-cfg-localepurge/files/locale.debconf
> create mode 100644 meta/recipes-support/isar-cfg-localepurge/files/locale.gen
> create mode 100644 meta/recipes-support/isar-cfg-localepurge/files/postinst
> create mode 100644 meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 0/3] One-shot configuration packages
2018-05-23 12:56 ` [PATCH 0/3] One-shot configuration packages Claudius Heine
@ 2018-05-23 13:16 ` Alexander Smirnov
2018-05-23 13:34 ` Claudius Heine
0 siblings, 1 reply; 8+ messages in thread
From: Alexander Smirnov @ 2018-05-23 13:16 UTC (permalink / raw)
To: Claudius Heine, isar-users; +Cc: Claudius Heine
Claudius Heine <claudius.heine.ext@siemens.com> 23 мая 2018 г. 15:56:29
написал:
> Hi.
>
> I apparently need to do a v2 for this, since Alex 'Last fixes for
> locales' patchset was on the fast lane and has gone to next and
> simultaneously to master without any time to review it.
1. The patches were sent on May 15 and pushed on May 18 in the evening. In
my opinion 3 days is quite enough to perform the review. So no fast lane
for my patches.
2. Master branch merged after next branch becomes green.
Probably you assume that git commit date represents actual repository
pushing, what is wrong. It represents git am date.
Alex
>
>
> Claudius
>
> On 2018-05-23 14:17, [ext] claudius.heine.ext@siemens.com wrote:
>> From: Claudius Heine <ch@denx.de>
>>
>> Hi,
>>
>> here is my implementation of one-shot packages.
>>
>> I also implemented a packages that does the localepurge step.
>>
>> Claudius
>>
>> Claudius Heine (3):
>> isar-bootstrap|configscript: implement one shot config option
>> meta/isar-cfg-localepurge: added locale purge recipe
>> meta-isar/isar-image-base: switch use isar-cfg-localepurge
>>
>> .../images/files/debian-configscript.sh | 31 -------------------
>> .../images/files/raspbian-configscript.sh | 30 ------------------
>> .../recipes-core/images/isar-image-base.bb | 6 ++--
>> meta/classes/isar-bootstrap-helper.bbclass | 23 +++++++++++---
>> .../isar-cfg-localepurge/files/locale.debconf | 12 +++++++
>> .../isar-cfg-localepurge/files/locale.gen | 1 +
>> .../isar-cfg-localepurge/files/postinst | 30 ++++++++++++++++++
>> .../isar-cfg-localepurge.bb | 19 ++++++++++++
>> 8 files changed, 84 insertions(+), 68 deletions(-)
>> create mode 100644
>> meta/recipes-support/isar-cfg-localepurge/files/locale.debconf
>> create mode 100644 meta/recipes-support/isar-cfg-localepurge/files/locale.gen
>> create mode 100644 meta/recipes-support/isar-cfg-localepurge/files/postinst
>> create mode 100644
>> meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb
>
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
>
> --
> You received this message because you are subscribed to the Google Groups
> "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to isar-users+unsubscribe@googlegroups.com.
> To post to this group, send email to isar-users@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/isar-users/bf3f2835-98b0-1ee0-1b88-5609af44bef6%40siemens.com.
> For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/3] One-shot configuration packages
2018-05-23 13:16 ` Alexander Smirnov
@ 2018-05-23 13:34 ` Claudius Heine
2018-05-23 13:43 ` Alexander Smirnov
0 siblings, 1 reply; 8+ messages in thread
From: Claudius Heine @ 2018-05-23 13:34 UTC (permalink / raw)
To: Alexander Smirnov, isar-users; +Cc: Claudius Heine
Hi Alex,
On 2018-05-23 15:16, Alexander Smirnov wrote:
>
>
> Claudius Heine <claudius.heine.ext@siemens.com> 23 мая 2018 г. 15:56:29
> написал:
>
>> Hi.
>>
>> I apparently need to do a v2 for this, since Alex 'Last fixes for
>> locales' patchset was on the fast lane and has gone to next and
>> simultaneously to master without any time to review it.
>
> 1. The patches were sent on May 15 and pushed on May 18 in the evening.
> In my opinion 3 days is quite enough to perform the review. So no fast
> lane for my patches.
Ok, then its just my experience that patches are on the list for longer,
even if they aren't commented on. (I also was on vacation for this
period, so I couldn't review it in time and it might seemed shorter for
me. But that is my issue :)
>
> 2. Master branch merged after next branch becomes green.
>
> Probably you assume that git commit date represents actual repository
> pushing, what is wrong. It represents git am date.
I was mainly missing the 'merged' confirmation on the Mailinglist. I
normally use that to know if I need to rebase or review.
Claudius
>
> Alex
>
>>
>>
>> Claudius
>>
>> On 2018-05-23 14:17, [ext] claudius.heine.ext@siemens.com wrote:
>>> From: Claudius Heine <ch@denx.de>
>>>
>>> Hi,
>>>
>>> here is my implementation of one-shot packages.
>>>
>>> I also implemented a packages that does the localepurge step.
>>>
>>> Claudius
>>>
>>> Claudius Heine (3):
>>> isar-bootstrap|configscript: implement one shot config option
>>> meta/isar-cfg-localepurge: added locale purge recipe
>>> meta-isar/isar-image-base: switch use isar-cfg-localepurge
>>>
>>> .../images/files/debian-configscript.sh | 31 -------------------
>>> .../images/files/raspbian-configscript.sh | 30 ------------------
>>> .../recipes-core/images/isar-image-base.bb | 6 ++--
>>> meta/classes/isar-bootstrap-helper.bbclass | 23 +++++++++++---
>>> .../isar-cfg-localepurge/files/locale.debconf | 12 +++++++
>>> .../isar-cfg-localepurge/files/locale.gen | 1 +
>>> .../isar-cfg-localepurge/files/postinst | 30 ++++++++++++++++++
>>> .../isar-cfg-localepurge.bb | 19 ++++++++++++
>>> 8 files changed, 84 insertions(+), 68 deletions(-)
>>> create mode 100644
>>> meta/recipes-support/isar-cfg-localepurge/files/locale.debconf
>>> create mode 100644
>>> meta/recipes-support/isar-cfg-localepurge/files/locale.gen
>>> create mode 100644
>>> meta/recipes-support/isar-cfg-localepurge/files/postinst
>>> create mode 100644
>>> meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb
>>
>> --
>> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
>>
>> --
>> You received this message because you are subscribed to the Google
>> Groups "isar-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send
>> an email to isar-users+unsubscribe@googlegroups.com.
>> To post to this group, send email to isar-users@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/isar-users/bf3f2835-98b0-1ee0-1b88-5609af44bef6%40siemens.com.
>>
>> For more options, visit https://groups.google.com/d/optout.
>
>
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/3] One-shot configuration packages
2018-05-23 13:34 ` Claudius Heine
@ 2018-05-23 13:43 ` Alexander Smirnov
0 siblings, 0 replies; 8+ messages in thread
From: Alexander Smirnov @ 2018-05-23 13:43 UTC (permalink / raw)
To: Claudius Heine, isar-users; +Cc: Claudius Heine
Claudius Heine <claudius.heine.ext@siemens.com> 23 мая 2018 г. 16:34:59
написал:
> Hi Alex,
>
> On 2018-05-23 15:16, Alexander Smirnov wrote:
>>
>>
>> Claudius Heine <claudius.heine.ext@siemens.com> 23 мая 2018 г. 15:56:29
>> написал:
>>
>>> Hi.
>>>
>>> I apparently need to do a v2 for this, since Alex 'Last fixes for
>>> locales' patchset was on the fast lane and has gone to next and
>>> simultaneously to master without any time to review it.
>>
>> 1. The patches were sent on May 15 and pushed on May 18 in the evening.
>> In my opinion 3 days is quite enough to perform the review. So no fast
>> lane for my patches.
>
> Ok, then its just my experience that patches are on the list for longer,
> even if they aren't commented on. (I also was on vacation for this
> period, so I couldn't review it in time and it might seemed shorter for
> me. But that is my issue :)
>
>>
>> 2. Master branch merged after next branch becomes green.
>>
>> Probably you assume that git commit date represents actual repository
>> pushing, what is wrong. It represents git am date.
>
> I was mainly missing the 'merged' confirmation on the Mailinglist. I
> normally use that to know if I need to rebase or review.
That's actualy my fault, no comments here. I thought I did it. :-(
Alex
>
>
> Claudius
>
>>
>> Alex
>>
>>>
>>>
>>> Claudius
>>>
>>> On 2018-05-23 14:17, [ext] claudius.heine.ext@siemens.com wrote:
>>>> From: Claudius Heine <ch@denx.de>
>>>>
>>>> Hi,
>>>>
>>>> here is my implementation of one-shot packages.
>>>>
>>>> I also implemented a packages that does the localepurge step.
>>>>
>>>> Claudius
>>>>
>>>> Claudius Heine (3):
>>>> isar-bootstrap|configscript: implement one shot config option
>>>> meta/isar-cfg-localepurge: added locale purge recipe
>>>> meta-isar/isar-image-base: switch use isar-cfg-localepurge
>>>>
>>>> .../images/files/debian-configscript.sh | 31 -------------------
>>>> .../images/files/raspbian-configscript.sh | 30 ------------------
>>>> .../recipes-core/images/isar-image-base.bb | 6 ++--
>>>> meta/classes/isar-bootstrap-helper.bbclass | 23 +++++++++++---
>>>> .../isar-cfg-localepurge/files/locale.debconf | 12 +++++++
>>>> .../isar-cfg-localepurge/files/locale.gen | 1 +
>>>> .../isar-cfg-localepurge/files/postinst | 30 ++++++++++++++++++
>>>> .../isar-cfg-localepurge.bb | 19 ++++++++++++
>>>> 8 files changed, 84 insertions(+), 68 deletions(-)
>>>> create mode 100644
>>>> meta/recipes-support/isar-cfg-localepurge/files/locale.debconf
>>>> create mode 100644
>>>> meta/recipes-support/isar-cfg-localepurge/files/locale.gen
>>>> create mode 100644
>>>> meta/recipes-support/isar-cfg-localepurge/files/postinst
>>>> create mode 100644
>>>> meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb
>>>
>>> --
>>> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
>>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>>> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "isar-users" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to isar-users+unsubscribe@googlegroups.com.
>>> To post to this group, send email to isar-users@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/isar-users/bf3f2835-98b0-1ee0-1b88-5609af44bef6%40siemens.com.
>>>
>>> For more options, visit https://groups.google.com/d/optout.
>
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
^ permalink raw reply [flat|nested] 8+ messages in thread