From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6788114222392803328 X-Received: by 2002:a2e:2201:: with SMTP id i1mr14455812lji.110.1580750415102; Mon, 03 Feb 2020 09:20:15 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:7309:: with SMTP id o9ls1766920ljc.11.gmail; Mon, 03 Feb 2020 09:20:14 -0800 (PST) X-Google-Smtp-Source: APXvYqyOV/YsS2zfp6dyB0f+wSLM7KRUD8a8MEVoilk59rYIdwR7tgw1xHcHElcYI77Zaiqe6yRz X-Received: by 2002:a2e:80d1:: with SMTP id r17mr14517744ljg.292.1580750414148; Mon, 03 Feb 2020 09:20:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1580750414; cv=none; d=google.com; s=arc-20160816; b=G/ZEGZaEbeyJoM6lI2kmjVZNkvP6UOVP+BdGNaM8RuJzo8gILZ4Dv3PSkrVwtylD4s +bh2Fly6D/nmD2b97VMcr6MN2tlnxjjF14oAJAnTjU8Z5PypjTuNsNEDL6s+wOBeRF3y 3mSx7Y5CS1NA/MOMM9kEeA6Wz4DRmryqYNq6qZ2p29wYLGU+wdIk+kEe9uxjY7JbKSoN 55cXVaNX0w5UEYmDOBK5nJASw1nvKJ+0nR3j1XuaLyd0fqyyxfirf4xQK25MNFAS4b/K 5MeXj70rjFcH2pCRWfGodjuTSzRhKGqlYo/LdgJuoB1glohU6ep9s/r2HvvEXcMMJ0ey yTXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=c1F6JfavrCAcOY0PXL48uqrE8f/kVDGHzEheIzv4waw=; b=nVi/ThgROcmYkwuJVH+pt5iGC74lxWVhXxj8b90olCHe4dQCU1N6+dgR9+Rd12FWrC JIIbhYF+6yNLWatp7pDAoxPKMSrjuSdQ5sZsLg1zcyhh5SRo4GkQvn84BRnZ8P2+9u/3 kbxcuU6cZyEXxzbZ8aoNAzlvbcf6dUFPJ1VPQ2ujH11i8MPrQWKDBYT+/RdCJ/Jfsvx9 GmPKUdoV07AQsIhWoELRn0V1QpIkQxULS34FNKohT02tEW0u1fWRgzPOZ6xx4Cvg3BaB y7Ao5z3wBV64nCEw1EiHwZ47VDnD7smEFLi5YskiUHlwXcMZhlbnkJsFtCY1r0ppyJ8g SgKw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id 68si667012lfi.3.2020.02.03.09.20.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Feb 2020 09:20:14 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 013HKCNB004682 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 3 Feb 2020 18:20:12 +0100 Received: from [139.25.68.37] ([139.25.68.37]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 013HKCNj032037; Mon, 3 Feb 2020 18:20:12 +0100 Subject: Re: [PATCHv4 22/26] meta: deb-dl-dir: do not cache debs from isar-apt To: "[ext] Henning Schild" , isar-users@googlegroups.com, "Su, Bao Cheng (RC-CN DI FA R&D SW)" Cc: Vijai Kumar K References: <20200131143000.14873-1-henning.schild@siemens.com> <20200131143000.14873-23-henning.schild@siemens.com> From: Jan Kiszka Message-ID: <16977d1f-fb4d-481b-9c55-53ed064df333@siemens.com> Date: Mon, 3 Feb 2020 18:20:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200131143000.14873-23-henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 2zCNxxBFatIx On 31.01.20 15:29, [ext] Henning Schild wrote: > From: Henning Schild > > Packages from isar-apt are not downloaded from the outside and should > not be cached. > > Signed-off-by: Henning Schild > --- > meta/classes/deb-dl-dir.bbclass | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/meta/classes/deb-dl-dir.bbclass b/meta/classes/deb-dl-dir.bbclass > index ab4b1f09..f9699603 100644 > --- a/meta/classes/deb-dl-dir.bbclass > +++ b/meta/classes/deb-dl-dir.bbclass > @@ -3,8 +3,10 @@ > # > # SPDX-License-Identifier: MIT > > +inherit repository > + > deb_dl_dir_import() { > - export pc="${DEBDIR}/${DISTRO}" > + export pc="${DEBDIR}/${DISTRO}/" > export rootfs="${1}" > [ ! -d "${pc}" ] && return 0 > flock -s "${pc}".lock -c ' \ > @@ -14,12 +16,16 @@ deb_dl_dir_import() { > } > > deb_dl_dir_export() { > - export pc="${DEBDIR}/${DISTRO}" > + export pc="${DEBDIR}/${DISTRO}/" > export rootfs="${1}" > mkdir -p "${pc}" > flock "${pc}".lock -c ' \ > - sudo find "${rootfs}"/var/cache/apt/archives/ -type f -iname '*\.deb' \ > - -exec cp -f '{}' "${pc}" \; > + find "${rootfs}"/var/cache/apt/archives/ -type f -iname '*\.deb' |\ > + while read p; do > + repo_contains_package "${REPO_ISAR_DIR}"/"${DISTRO}" "${p}" && \ repo_contains_package may not be found inside the flock shell context, as Bao Cheng noticed out. He suggests the pattern (flock 8 ... ) 8>${LOCKFILE} Bao Check, maybe you can describe how you noticed. Jan > + continue > + sudo cp -f "${p}" "${pc}" > + done > sudo chown -R $(id -u):$(id -g) "${pc}" > ' > } > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux