From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6830344030104059904 X-Received: by 2002:a05:651c:106f:: with SMTP id y15mr1073379ljm.170.1598891377482; Mon, 31 Aug 2020 09:29:37 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:b4d3:: with SMTP id r19ls1197919ljm.3.gmail; Mon, 31 Aug 2020 09:29:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBzHqnwOt3w3CtfkbSQ4bO+JTy+94IjToVJKPHj7twiTEuuAdrwIW1fVqlyCl5t7JgyxAL X-Received: by 2002:a2e:1417:: with SMTP id u23mr1109670ljd.44.1598891376427; Mon, 31 Aug 2020 09:29:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598891376; cv=none; d=google.com; s=arc-20160816; b=XE8PPy4hojWi31c5WoLrgdGFgPX7pqtMuJue8DKmIbJJXowoHiySNoGGXHCdBz6KXD nJ6bdG5TnUfQVntknkphEmfz2/9Nu0rj+qjrN1aEBG5ImZ+2/bNS1tZLjZGFXPOq/jkv M3qdEtXQbOF5CxdcVzQ0ByXYIhoLoRY93ld3G3f+eJlValql7FUzNejvcpY8WE7pn5J/ fbMrbfv1fshTRsGjRGoFPE8ds+rch6AEakejta8yu6ylGGKDWepdxnHi6HneysBQ3jGD SG/BiTHwqYv95FsBCksEZws5/YgWM8uP5VFa74enS9H0jPUVYa9NlIQSOylZnm3QNaz4 M4/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject; bh=5B2iJw6+7WyPO0CZhoKiITLY8bIietFGFMtmOnSZBC0=; b=QpxrxXhEr/4q1Kqyh+ULgfrnTLlhMFfk4HQJvb4kOJZVaJGWosCkEGUzIkv7qdBynB 2kNWuYgDV8Ny8wkCceRGOSgmyLq7csDXccxKTZEuEVncDOlj0c0ik/iBwilEEjqlB1QF ML8fzSkw9XE/XuZoTZhOBqsDSznU2U25gnz3+VbCYh5zfPur6AVT/9+2XDMc8/RpTYZH /oi4myUw/M1jknvVMXf27ss9M/pI14vw3it3EtxohBDCIlT2cfVpYzBawz2t6Ll3XYRQ 0/ISgrOVBBwdXnxDWMsIyjZPl7UfqPKz/rrL6WKnxWHe9S3ekic/PcqXzIbkezy24T4y KQcw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id b5si88705lfa.0.2020.08.31.09.29.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 Aug 2020 09:29:36 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 07VGTZVm009460 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 Aug 2020 18:29:35 +0200 Received: from [167.87.39.104] ([167.87.39.104]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 07VGTZE7011937; Mon, 31 Aug 2020 18:29:35 +0200 Subject: Re: [PATCH] linux-custom: Clean up minor inconsistencies in rules.tmpl From: Jan Kiszka To: isar-users , Baurzhan Ismagulov References: <289568e6-46d2-e2e3-9771-7668cd10bc01@web.de> <20200528200446.3zlpkejasd2gex4r@yssyq.m.ilbers.de> <4ddde1de-c1bc-451a-e9a1-dd2bd17712bf@siemens.com> Message-ID: <16a1b544-7fec-9895-fff2-03e746910e66@siemens.com> Date: Mon, 31 Aug 2020 18:29:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: xyAHysmsMH+5 On 22.06.20 09:36, [ext] Jan Kiszka wrote: > On 29.05.20 07:53, [ext] Jan Kiszka wrote: >> On 28.05.20 22:04, Baurzhan Ismagulov wrote: >>> On Sun, May 24, 2020 at 11:43:13AM +0200, Jan Kiszka wrote: >>>> .PHONY is not needed (and wasn't consistently used anyway). And that >>>> missing && before the last export was apparently not critical as well. >>> >>> Wow, export A=a export B=b is accepted at least by bash. The && fix is still >>> needed if there is an error in A=a, thanks for the catch. >>> >>> Regarding .PHONY, could you please comment why it is not needed? Usually it's a >>> safeguard against the case when a file with the name of a target exists (e.g., >>> override_dh_auto_clean). In that case, the target is not built, and .PHONY >>> enforces building. If there are no other reasons, I'd rather go towards making >>> it consistent (PHONY -> .PHONY, .PHONY: override_dh_auto_install). >> >> I suspect the Debian's build framework sets them already because I >> haven't seen them in use in all examples and manuals I read. >> > > Ping. > > Jan > Ping² Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux