From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6524973730788016128 X-Received: by 10.28.247.4 with SMTP id v4mr2182460wmh.1.1520496887406; Thu, 08 Mar 2018 00:14:47 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.184.114 with SMTP id u47ls1077801wrf.10.gmail; Thu, 08 Mar 2018 00:14:46 -0800 (PST) X-Google-Smtp-Source: AG47ELsCIT4UcLAJRBQ1X6gxW4ZhK2V7iEdp85aj65VPS88GlCzA3G2tZ3dMtJzSwu4nEAr6nAva X-Received: by 10.223.182.142 with SMTP id j14mr2310790wre.15.1520496886668; Thu, 08 Mar 2018 00:14:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520496886; cv=none; d=google.com; s=arc-20160816; b=olM9AGilNIscsZfbD/B5qYf+IIGOCMwb9zz15cnPrG0FdfjNTs2qK/KshiK4XH+f2m MrB5vA/Y6Ujn0MShqVNzmrp3qLGpwmJVlIa8d/0Su9oAQtjVfBzs0oWQGWS4EWIrvb0/ RWrCjEyu68eB/QIJ8csdZDEoDDXl87agth5a3G9cqzcoa72toxgfGAWJVux/04pshYDz qVrITTJnOYj2hVp71ULfb8dA3j61aJ3pXjOcDM+16+QPUlAjQ1aKm9tiFIIHvQuKyk4x pfk/dIG9uI+7h5eiiZmLakLM3AJyzkLbKM4pV57Ey+aIc4rc4PyCme67IvNI8Iph9i2N g3JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=ojjnB7TJ+s0SHgGMSJ4ZWYcMGyFn/9urRfP4dgJ2iJE=; b=OYbfCaXutvp1FXgUmt9UrCAK6hDGl3+dZ27sG6GIGs+IoGpjOLOG5lZzc+ul1raqca xoYKy3Xx8mB+TZQiCgiIlvCuDgNTu9jBuQ9PuGZmSKk9Hef2y3s2LNgb2GUcGMPSAl9m bQiM7bAy1uLV2OyKnEwbp1PjJX9erPtXmNwgojfvHOKBCaewBjp/eyauhfGntGYsvHK6 Y814IlSdCtRFDF/Uk+ECOdVWkTCDdb+4afBRCKpxHeSbJSence+ovukGKh6MwShmWjA0 Lw2tdpQttilJAYRm9+POBR3rDrO14345eLmRi+7aG27Kwt4WlJG3jdOo8qOTl2yYMqb1 EZzw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id m29si816756wrb.1.2018.03.08.00.14.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Mar 2018 00:14:46 -0800 (PST) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w288EjMH022210 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Mar 2018 09:14:46 +0100 Received: from [139.25.68.223] (linux-ses-ext02.ppmd.siemens.net [139.25.68.223]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id w288EjI8015614; Thu, 8 Mar 2018 09:14:45 +0100 Subject: Re: [PATCH v4 0/5] Debootstrap integration To: Jan Kiszka , isar-users@googlegroups.com Cc: Claudius Heine References: <20180307164457.31933-1-claudius.heine.ext@siemens.com> <646a5e59-a6a1-4ccd-249a-1c1fa87f0d17@siemens.com> <34de0acc-e28b-d1be-2a02-6296849e7e0b@siemens.com> From: Claudius Heine Message-ID: <16b13094-46e0-1c03-f60f-1df8f46e91b9@siemens.com> Date: Thu, 8 Mar 2018 09:14:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <34de0acc-e28b-d1be-2a02-6296849e7e0b@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: n/YBGIMAXj4P Hi Jan, On 03/08/2018 07:06 AM, Jan Kiszka wrote: > On 2018-03-07 20:51, [ext] Jan Kiszka wrote: >> On 2018-03-07 17:44, [ext] claudius.heine.ext@siemens.com wrote: >>> From: Claudius Heine >>> >>> Hi, >>> >>> sorry, just saw a small error, some changes to isar-bootstrap got into >>> the buildchroot patch. >>> >>> Cheers, >>> Claudius >>> >>> Changes from v3: >>> - A small modification to isar-bootstrap.bb snuck into the buildchroot >>> patch. >>> >>> Changes from v2: >>> - rebased to current next >>> - added missing newlines at the end of file >>> - use cleandirs with root permissions >>> this could be improved in some later patch series, so that this >>> feature can be shared. >>> - moved main source url of packages to apt source list files of the >>> distributions: >>> - Implemented some basic parsing of source.lists files in >>> isar-bootstrap. >>> - Made 'DISTRO_SUITE', 'DISTRO_APT_SOURCE' and 'DISTRO_COMPONENTS' >>> variables obsolete. >>> - implemented repo key fetching to support rasbian repositories >>> - now the clean task removes the symlink of isar-bootstrap deploy task >>> >>> Changes from v1: >>> - rebased to current next >>> - added unmounting of /dev and /proc at the end of do_rootfs in isar-image-base >>> This was necessary for image file creation, otherwise it tried to >>> package stuff from the host. >>> - added 'isar-bootstrap:do_deploy' dependency to do_rootfs task in >>> image.bbclass. >>> - Changed 'RFSDIR' variable name to 'ROOTFSDIR' in >>> isar-bootstrap-helper.bbclass to be consistent with the variable >>> name in isar-bootstrap.bb >>> - Moved 'isar-apt' apt-preference settings from isar-bootstrap.bb to >>> isar-bootstrap-helper.bbclass >>> - Removed '--no-install-recommends' parameters in favor of adding the >>> apt configuration in 'isar-bootstrap.bb' >>> - unmount and remove possible existing bootstraped directories before >>> bootstrapping in do_bootstrap task of 'isar-bootstrap.bb' >>> - changed from /dev ro bind mounts to mounting devtmpfs to /dev to be >>> consistent with the other places where /dev is mounted. >>> >>> >>> Claudius Heine (5): >>> implement isar-bootstrap using debootstrap >>> meta/isar-bootstrap-helper.bbclass: handle rfs customization centrally >>> meta/buildchroot: switch to using isar-bootstrap >>> meta-isar/isar-image-base: switch to using isar-bootstrap >>> meta-isar/multiconfig: remove multistrap references >>> >>> meta-isar/conf/distro/debian-jessie.conf | 9 +- >>> meta-isar/conf/distro/debian-jessie.list | 3 + >>> meta-isar/conf/distro/debian-stretch.conf | 7 +- >>> meta-isar/conf/distro/debian-stretch.list | 3 + >>> meta-isar/conf/distro/debian-wheezy.conf | 9 +- >>> meta-isar/conf/distro/debian-wheezy.list | 3 + >>> meta-isar/conf/distro/raspbian-jessie.conf | 12 +- >>> meta-isar/conf/distro/raspbian-jessie.list | 1 + >>> meta-isar/conf/local.conf.sample | 4 +- >>> meta-isar/conf/multiconfig/qemuarm-jessie.conf | 2 +- >>> meta-isar/conf/multiconfig/qemuarm-wheezy.conf | 2 +- >>> meta-isar/conf/multiconfig/rpi-jessie.conf | 2 +- >>> .../recipes-core/images/files/download_dev-random | 24 --- >>> .../recipes-core/images/files/multistrap.conf.in | 38 ---- >>> meta-isar/recipes-core/images/files/setup.sh | 77 -------- >>> meta-isar/recipes-core/images/isar-image-base.bb | 64 +++---- >>> meta/classes/image.bbclass | 2 +- >>> meta/classes/isar-bootstrap-helper.bbclass | 39 ++++ >>> .../isar-bootstrap/files/isar-apt.conf | 2 + >>> meta/recipes-core/isar-bootstrap/isar-bootstrap.bb | 205 +++++++++++++++++++++ >>> meta/recipes-devtools/buildchroot/buildchroot.bb | 59 ++---- >>> meta/recipes-devtools/buildchroot/files/build.sh | 2 +- >>> .../buildchroot/files/configscript.sh | 10 - >>> .../buildchroot/files/multistrap.conf.in | 37 ---- >>> meta/recipes-devtools/buildchroot/files/setup.sh | 82 --------- >>> 25 files changed, 310 insertions(+), 388 deletions(-) >>> create mode 100644 meta-isar/conf/distro/debian-jessie.list >>> create mode 100644 meta-isar/conf/distro/debian-stretch.list >>> create mode 100644 meta-isar/conf/distro/debian-wheezy.list >>> create mode 100644 meta-isar/conf/distro/raspbian-jessie.list >>> delete mode 100644 meta-isar/recipes-core/images/files/download_dev-random >>> delete mode 100644 meta-isar/recipes-core/images/files/multistrap.conf.in >>> delete mode 100755 meta-isar/recipes-core/images/files/setup.sh >>> create mode 100644 meta/classes/isar-bootstrap-helper.bbclass >>> create mode 100644 meta/recipes-core/isar-bootstrap/files/isar-apt.conf >>> create mode 100644 meta/recipes-core/isar-bootstrap/isar-bootstrap.bb >>> delete mode 100644 meta/recipes-devtools/buildchroot/files/multistrap.conf.in >>> delete mode 100755 meta/recipes-devtools/buildchroot/files/setup.sh >>> >> >> FWIW, I've successfully built all CI targets locally just now. No time >> to test the result, though. > > Images also run, and I was specifically able to build and run the next > branch of jailhouse-images with these patches applied. Looks very good! > And I also like "310 insertions(+), 388 deletions(-)" a lot. :) Great that you like it :) But some features would need to be implemented or fixed again, like changing mirrors and setting hostname. So there is some regression happening here unfortunately. Also, I because I was busy tackling and fixing the big issues, there might still be some regressions or left over code in some places. I would try looking at the configscripts for both isar-image-base and buildchroot. I am not sure if everything there is still required or if I accidental deleted something very important from the setup scripts. I don't think so, but I haven't written this code or encountered any issues it fixes. But all those issues should be reasonable straight forward to fix, and if someone or myself follow the suggestions I just posted, then the code reduction might still happen. Cheers, Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de