Re: [PATCH 1/3] wks: added 'rw' to kernel arguments

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi Henning,

On 28/05/2019 19.29, Henning Schild wrote:
> Just looked at recent upstream wic. They do not have the "rw" and are
> probably using their own fstab-stuff.
> 
> Can you elaborate why this is required?

After I removed the fstab in the second patch, the root file system was 
mounted ro in qemu and the /etc/machine-id could not be recreated. The 
easiest solution is to add 'rw' to the kernel cmdline. Since my debian 
host has 'ro' in its cmdline, I think those kind of settings are ok 
there in debian.

> 
> Not that a care about the minimal change in the fork, the patch does
> not motivate it. And there seems to be a difference which would prevent
> us from using random wks files from the internet.

Maybe it would make sense to merge this patch with the next one, since 
this fixes a issue that only happens after fstab is removed.

Claudius

> 
> Henning
> 
> Am Tue, 28 May 2019 10:58:12 +0200
> schrieb "[ext] claudius.heine.ext@siemens.com"
> <claudius.heine.ext@siemens.com>:
> 
>> From: Claudius Heine <ch@denx.de>
>>
>> Signed-off-by: Claudius Heine <ch@denx.de>
>> ---
>>   meta-isar/scripts/lib/wic/canned-wks/bananapi.wks        | 2 +-
>>   meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks | 2 +-
>>   meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks     | 2 +-
>>   3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks
>> b/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks index
>> dbec48e..ad8b46f 100644 ---
>> a/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks +++
>> b/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks @@ -2,4 +2,4 @@
>> part u-boot --source rawcopy --sourceparams
>> "file=/usr/lib/u-boot/Bananapi/u-boo part / --source rootfs-u-boot
>> --ondisk mmcblk0 --fstype ext4 --label platform --align 1024
>> -bootloader --append "rootwait"
>> +bootloader --append "rootwait rw"
>> diff --git a/meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks
>> b/meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks index
>> e78429c..43107b6 100644 ---
>> a/meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks +++
>> b/meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks @@ -4,4
>> +4,4 @@
>>   include common-isar.wks.inc
>>   
>> -bootloader  --timeout=0  --append "rootwait rootfstype=ext4
>> video=vesafb vga=0x318 console=tty0 console=ttyS0,115200n8"
>> +bootloader  --timeout=0  --append "rootwait rw rootfstype=ext4
>> video=vesafb vga=0x318 console=tty0 console=ttyS0,115200n8" diff
>> --git a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks
>> b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks index
>> 2afa016..f9e49ca 100644 ---
>> a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks +++
>> b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks @@ -6,4 +6,4
>> @@ part /boot --source bootimg-efi-isar --sourceparams
>> "loader=grub-efi" --ondisk s part / --source rootfs --ondisk sda
>> --fstype ext4 --label platform --align 1024 --use-uuid -bootloader
>> --ptable gpt --timeout 3 --append "rootwait console=ttyS0,115200
>> console=tty0" +bootloader --ptable gpt --timeout 3 --append "rw
>> rootwait console=ttyS0,115200 console=tty0"
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de