From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6695999620571463680 X-Received: by 2002:a17:906:139a:: with SMTP id f26mr86544463ejc.154.1559111926273; Tue, 28 May 2019 23:38:46 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:6dc1:: with SMTP id j1ls284111ejt.1.gmail; Tue, 28 May 2019 23:38:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqzFldIXNE97V+pdNjks11tqFpAIqIluURIkW4NsIQ4ckoYf5pDVqWZDVoRiWiIg2oBnjhvV X-Received: by 2002:a17:906:22d8:: with SMTP id q24mr104581604eja.261.1559111925883; Tue, 28 May 2019 23:38:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559111925; cv=none; d=google.com; s=arc-20160816; b=pxTR/YR2wQOznqAXwzeq3YHTCU46/ap3tg9u1rMHcR1uRGHximavIt9ozpLTize/9w o4rQ0OkdhZ73/m2NYQIEWxLE8ubYzwK40GtDHnaAc/mFK32hBYsrqi7o9T9c3ZP51ToV 2lIu/b97fnbWcDelGQf+5BAbDNWBM+89u1PPWRr7kTaDucMr85DlqC+Gctukfc4Jiqan eWrSYwMRMo8Pbj9uALGOi/7NSPVKZq9c/5tmiG7nqw43xGHsI38Rqu/tCI/DrMu1Luao HBztXa/dH4I+RHOnOoQvCB40nTuf/4LGCf/Jl88oEqo3MhpWT7zYKERmerZy55Fxrj95 +bMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=+WSx21Gr9aZFcqOEX2yHKq0FW6BinRkD9968cry5/Ig=; b=vzQrMyxCpF2ViOpK5XH+OhqPgfznBy7zipZ4iJH7YlehVxzWrOWkZfpOnIY+89yHlI Pr1xWNf/+7pYE4UWO1FTgTkYJgsSyrssmnOyYi6ZkjXkRYPfc34W/1VxzxxutmUkneuc oFBrD8Aya2OwmgdTeTS20BOm5nGpOxIUvU5N4sjkhz7i/DdibnYY71l3/kQsro/GQHkv huYxflJrEJ5vNbjy98jFOLXfYZBXHJRDUc4s1NXpAxMkKFfbh6JWTUM4ZcUMzh6Ew76c d7b9wp6LGL0yzmplHAiUsDZDMulrXmkATJ/LVOsHqWCsFFKND5QrS3TtjkmgcKDDR41Z VxyQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id h25si569265ejz.1.2019.05.28.23.38.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 May 2019 23:38:45 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x4T6ciqQ011134 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 May 2019 08:38:44 +0200 Received: from [139.25.69.232] (linux-ses-ext02.ppmd.siemens.net [139.25.69.232]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x4T6cgtm001172; Wed, 29 May 2019 08:38:43 +0200 Subject: Re: [PATCH 1/3] wks: added 'rw' to kernel arguments To: Henning Schild Cc: isar-users@googlegroups.com, Claudius Heine References: <20190528085814.12967-1-claudius.heine.ext@siemens.com> <20190528085814.12967-2-claudius.heine.ext@siemens.com> <20190528192955.2abcf9e2@md1za8fc.ad001.siemens.net> From: Claudius Heine Message-ID: <175da011-17ce-d1fe-8cab-a493e8b57e2d@siemens.com> Date: Wed, 29 May 2019 08:38:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190528192955.2abcf9e2@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: VFIt2LPjx1jI Hi Henning, On 28/05/2019 19.29, Henning Schild wrote: > Just looked at recent upstream wic. They do not have the "rw" and are > probably using their own fstab-stuff. > > Can you elaborate why this is required? After I removed the fstab in the second patch, the root file system was mounted ro in qemu and the /etc/machine-id could not be recreated. The easiest solution is to add 'rw' to the kernel cmdline. Since my debian host has 'ro' in its cmdline, I think those kind of settings are ok there in debian. > > Not that a care about the minimal change in the fork, the patch does > not motivate it. And there seems to be a difference which would prevent > us from using random wks files from the internet. Maybe it would make sense to merge this patch with the next one, since this fixes a issue that only happens after fstab is removed. Claudius > > Henning > > Am Tue, 28 May 2019 10:58:12 +0200 > schrieb "[ext] claudius.heine.ext@siemens.com" > : > >> From: Claudius Heine >> >> Signed-off-by: Claudius Heine >> --- >> meta-isar/scripts/lib/wic/canned-wks/bananapi.wks | 2 +- >> meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks | 2 +- >> meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks >> b/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks index >> dbec48e..ad8b46f 100644 --- >> a/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks +++ >> b/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks @@ -2,4 +2,4 @@ >> part u-boot --source rawcopy --sourceparams >> "file=/usr/lib/u-boot/Bananapi/u-boo part / --source rootfs-u-boot >> --ondisk mmcblk0 --fstype ext4 --label platform --align 1024 >> -bootloader --append "rootwait" >> +bootloader --append "rootwait rw" >> diff --git a/meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks >> b/meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks index >> e78429c..43107b6 100644 --- >> a/meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks +++ >> b/meta-isar/scripts/lib/wic/canned-wks/directdisk-isar.wks @@ -4,4 >> +4,4 @@ >> include common-isar.wks.inc >> >> -bootloader --timeout=0 --append "rootwait rootfstype=ext4 >> video=vesafb vga=0x318 console=tty0 console=ttyS0,115200n8" >> +bootloader --timeout=0 --append "rootwait rw rootfstype=ext4 >> video=vesafb vga=0x318 console=tty0 console=ttyS0,115200n8" diff >> --git a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks >> b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks index >> 2afa016..f9e49ca 100644 --- >> a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks +++ >> b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks @@ -6,4 +6,4 >> @@ part /boot --source bootimg-efi-isar --sourceparams >> "loader=grub-efi" --ondisk s part / --source rootfs --ondisk sda >> --fstype ext4 --label platform --align 1024 --use-uuid -bootloader >> --ptable gpt --timeout 3 --append "rootwait console=ttyS0,115200 >> console=tty0" +bootloader --ptable gpt --timeout 3 --append "rw >> rootwait console=ttyS0,115200 console=tty0" > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de