From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6622940919445323776 X-Received: by 2002:a17:906:6006:: with SMTP id o6-v6mr1708949ejj.4.1542030932977; Mon, 12 Nov 2018 05:55:32 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:1304:: with SMTP id w4-v6ls1227994ejb.10.gmail; Mon, 12 Nov 2018 05:55:32 -0800 (PST) X-Google-Smtp-Source: AJdET5cwGhMEZN2wTCSGwbiu4zuJNu8OkMY1Ym6us/BYxZsQ/i00KMdqiPCgO2InesIMpeA2ar30 X-Received: by 2002:a17:906:7084:: with SMTP id b4-v6mr1753617ejk.9.1542030932446; Mon, 12 Nov 2018 05:55:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542030932; cv=none; d=google.com; s=arc-20160816; b=poABfw+ib3XmUM8qfaBJZ+F5psqyeJZdKJ3gyE6XtX2lB8tWXqmqUuephdMI1WD6lA HGtWIxfFwAls9qhLsAPjfvl/ySsTmOzsXpU1foxHQ52ySFPbuwIZmdh1Qmtz15p655Rm XdzjotD0RyrSdCt9OFvg2aE30MxNW9/3GaTC0HB35YwmGNCmLwspesFj7g/y0NJmpmUc x/c1TsNtdNR/ECaD0J0gMYF8osq+jQMQIElXWazL++x6K5d5npMGdQNrizJoLT8zq2PZ VLjVElmC+jDP1QD2zJWEFZnUQvo/U7hiu/B6lK2G7ZYUMiDsd7TNo8fMy5YieeVERdox gtdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=F195+JcjH8UNQwv4rUgz/xzQevvFh+MBqNbXv8yKZnk=; b=I1oee0VPzZe11vywRzC7FhLbNMA6Rmo10X34b7sYZ5uWIobFLFrrkHbKy+Pos5bMiy THN3MeYO1CO+WWygL3D/JT6iX2/6Ob6iN9mWY7IhFZkGuK+1uQvxQ6BT0U00E5LwXr08 dCc3+F7/UBE+vbn1Wz4IGXToJR0fi3VBFwEoTCW7LgVoeGraTn/blRwCz7KjHmmuSnYs jWKayziX5WnB1QWoUG8aDEGreycrILUAnbemgT3LsKYXGQjENFH5ib1S1OIMbSI1zWrx SYZx5xw++XNrtHtXbPpPZtX4WiNmCzUc6iScrdi1/jBSTyp/jpnUFKHxEksxIu2v09Rd aQDg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id a35-v6si886681edd.1.2018.11.12.05.55.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Nov 2018 05:55:32 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id wACDtVfw001883 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 12 Nov 2018 14:55:32 +0100 Received: from [167.87.36.55] ([167.87.36.55]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id wACDtVe1011739; Mon, 12 Nov 2018 14:55:31 +0100 Subject: Re: [PATCH] buildchroot: chown the whole WORKDIR to builder:builder To: "[ext] Henning Schild" , isar-users References: <20181112115315.17647-1-henning.schild@siemens.com> <20181112144624.0cd92d18@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: <17de5954-55a5-bdb7-88b6-e7daebb880e5@siemens.com> Date: Mon, 12 Nov 2018 14:55:30 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20181112144624.0cd92d18@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: /VUai34lBDiU On 12.11.18 14:46, [ext] Henning Schild wrote: > This is truly wrong, because now we chown temp/ and other bitbake owned > files. > The real fix probably is reverting 624b7c484bf5, will send another > patch. Please finally accept: We need alignment of the ownership rights (and that implies user IDs) between the bitbake and the chroot build environment. Then and only then we can revert that commit. Jan > > Henning > > Am Mon, 12 Nov 2018 12:53:15 +0100 > schrieb Henning Schild : > >> The initial idea was to chown as little as possible, but there is a >> "chown -R" in do_unpack that we need to work against when rebuilding a >> package. >> >> Fixes: be291cd991bd ("buildchroot: build debian packages as "builder" >> not "root"") Signed-off-by: Henning Schild >> --- >> meta/recipes-devtools/buildchroot/files/build.sh | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/meta/recipes-devtools/buildchroot/files/build.sh >> b/meta/recipes-devtools/buildchroot/files/build.sh index >> 66b1a77..112aac3 100644 --- >> a/meta/recipes-devtools/buildchroot/files/build.sh +++ >> b/meta/recipes-devtools/buildchroot/files/build.sh @@ -15,6 +15,5 @@ >> for i in configure aclocal.m4 Makefile.am Makefile.in; do done >> >> # Build the package as user "builder" >> -chown -R builder:builder $1 # the sources >> -chown builder:builder $1/.. # the output >> +chown -R builder:builder $1/.. # the whole WORKDIR >> su builder -c "cd $1; dpkg-buildpackage -a$target_arch -d >> --source-option=-I" > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux