From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6449247987705053184 X-Received: by 10.159.33.98 with SMTP id 89mr3231652uab.12.1502218748947; Tue, 08 Aug 2017 11:59:08 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.36.184.70 with SMTP id m67ls7295313ite.18.gmail; Tue, 08 Aug 2017 11:59:08 -0700 (PDT) X-Received: by 10.129.96.136 with SMTP id u130mr3322036ywb.117.1502218748557; Tue, 08 Aug 2017 11:59:08 -0700 (PDT) Received: by 10.55.101.138 with SMTP id z132msqkb; Tue, 8 Aug 2017 06:24:52 -0700 (PDT) X-Received: by 10.25.233.88 with SMTP id g85mr555968lfh.38.1502198692423; Tue, 08 Aug 2017 06:24:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502198692; cv=none; d=google.com; s=arc-20160816; b=bBvHbFfBUatGgcbIPOo/rOikvVK00u4WosPyX+/eEVOYngJmeKezlOe7nYdndAt5DJ no61poi8me7NjU/G21nUvEt3SfkM5myXwVLBiBQAgoLwR2dWfN+iuZHU/tmg43I+Z238 wRdcCqdvgW38GcB8QHuUHCf34Ypi0IXJnC+SiKKfKgP46rxinGLsalt/Dsircu1iVFH8 YjnfS5v2oi1gK/Zo9epwwAE3OMXg93Z0sFxKZrrLOhhvog0N/C3f4nT2JSp7wnfIHkwd PiRQk6YXmG7pPrDEjhoC/Vxiz8DBSugXmFSZNRT1OYAsrQCtIRxv2eNdMsI/oGCPqYN8 dn7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=EunN9EfsMWfkT6Y9MUKhAcM+7y/1LMrUYQs9asUXFOQ=; b=bRzJPB4jw5RoW6a5dksc43TmBh5dnl3QjEsLEgh7ZPgsRO3Geo16FCi8Yz5RZ5TjL+ skuDflERbuhDSSU/lNtnTjxm7+zE3XrJGELs7wIV+13f9z8Lxhc44UJbXEel2Hy7zLTQ sJuVS+k/3ZuxoLJzXdTHObxfr/+BH74iFMshJqCe06bzB/j0FWNkJPmIsRBOZr6sJsNy zuBS7B5ChEWOgWzAA2ff4tGj6MO7KSiYZ42M6IZNN8Os9KsY8xyAl07pGGLfCNcyh9C7 tMiOfJwJqN4RRbflPegxL74FuSf+/jgfQv1nyefCTI9DbFld+hMVVX+mdv8r6B9priU0 dpjQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id 81si494419wmh.1.2017.08.08.06.24.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 06:24:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id v78DOnfG023078 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 8 Aug 2017 15:24:51 +0200 Subject: Re: [PATCH 0-10 of 16 v2 2/8] meta: isar-base: remove unused function To: Henning Schild Cc: isar-users@googlegroups.com References: <369a52a90daaf90bbf7ebcc8831589b7085fcfa3.1501760818.git.henning.schild@siemens.com> <20170808100527.097c4ab1@md1em3qc> <20170808140809.1636322c@md1em3qc> <55765622-5df2-3353-2326-7f3d66a0e57e@ilbers.de> <20170808151247.40b2f573@md1em3qc> From: Alexander Smirnov Message-ID: <187ded0d-5751-3267-e321-4258f77e8557@ilbers.de> Date: Tue, 8 Aug 2017 16:24:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170808151247.40b2f573@md1em3qc> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: Fdx1lvDtkfv8 On 08/08/2017 04:12 PM, Henning Schild wrote: > Am Tue, 8 Aug 2017 15:29:35 +0300 > schrieb Alexander Smirnov : > >> Hi, >> >> On 08/08/2017 03:08 PM, Henning Schild wrote: >>> Am Tue, 8 Aug 2017 12:33:58 +0300 >>> schrieb Alexander Smirnov : >>> >>>> 2017-08-08 11:05 GMT+03:00 Henning Schild >>>> : >>>> >>>>> Am Mon, 7 Aug 2017 22:36:18 +0300 >>>>> schrieb Alexander Smirnov : >>>>> >>>>>> I'm not sure that this function is unused. It's usually used for >>>>>> debug purposes to route traces to console. >>>>> >>>>> It is unused in Isar and not part of the default base class of >>>>> bitbake. >>>>>> http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html >>>>>> chapter: 2.3.8.2 >>>>> >>>>> OE implements it in meta/classes/logging.bbclass >>>>> >>>>> >>>> That's a good hint! So probably we can move this function to >>>> similar class instead of removing it. >>> >>> I would still remove it since it is not used. When people need it >>> they can introduce it again. For logging we have bbnote bbwarn and >>> bbfatal from base.bbclass already. >>> >>> Our bitbake does not seem to know "debug_level" so it is outdated >>> and unused. >> >> I'll send patch which introduces logging class and move all the >> 'bbXXX' helpers to it (also fix bbdebug). > > Please do not touch base.bbclass! Or come up with one that is really > different from the bitbake default one for a good reason. > Why base.bbclass should stay untouched? If default bitbake contains garbage, should we still keep it and workaround as much as possible? >> I really don't like the idea to drop debug capabilities only because >> they are not used at the moment. If this interface is going to be >> dropped, then we need to introduce new interface before. > > Like Isar was used by anyone or this was anything like a tiny > broken print function.... without users or a release who cares about > interfaces? But keep it like the bugs in ext4! In my previous comment I mentioned, that bbdebug should be fixed. > > Can we please start dicsussing the real patches? This discussion relates to real patch. >>>>>> I think it makes sense to keep it to debug complicated classes >>>>>> and recipes in future. >>>>> >>>>> Ok. >>>>> >>>>> Henning >>>>> >>>>>> 2017-08-03 14:55 GMT+03:00 Henning Schild >>>>>> : >>>>>> >>>>>>> Signed-off-by: Henning Schild >>>>>>> --- >>>>>>> meta/classes/isar-base.bbclass | 12 ------------ >>>>>>> 1 file changed, 12 deletions(-) >>>>>>> >>>>>>> diff --git a/meta/classes/isar-base.bbclass >>>>>>> b/meta/classes/isar-base. bbclass >>>>>>> index 67d38a1..efd4223 100644 >>>>>>> --- a/meta/classes/isar-base.bbclass >>>>>>> +++ b/meta/classes/isar-base.bbclass >>>>>>> @@ -21,16 +21,4 @@ >>>>>>> >>>>>>> THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}" >>>>>>> >>>>>>> -bbdebug() { >>>>>>> - test $# -ge 2 || { >>>>>>> - echo "Usage: bbdebug level \"message\"" >>>>>>> - exit 1 >>>>>>> - } >>>>>>> - >>>>>>> - test ${@bb.msg.debug_level['default']} -ge $1 && { >>>>>>> - shift >>>>>>> - echo "DEBUG:" $* >>>>>>> - } >>>>>>> -} >>>>>>> - >>>>>>> do_build[nostamp] = "0" >>>>>>> -- >>>>>>> 2.13.0 >>>>>>> >>>>>>> >>>>> >>>>> >>> >> > -- With best regards, Alexander Smirnov ilbers GmbH Baierbrunner Str. 28c D-81379 Munich +49 (89) 122 67 24-0 http://ilbers.de/ Commercial register Munich, HRB 214197 General manager: Baurzhan Ismagulov