From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7044234567900725248 X-Received: by 2002:a2e:bd15:: with SMTP id n21mr2228764ljq.128.1643275737291; Thu, 27 Jan 2022 01:28:57 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:1599:: with SMTP id bp25ls2873437lfb.0.gmail; Thu, 27 Jan 2022 01:28:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJw0e6LvilaxSVdO8J30qkIJowr7+u4sAdb4avWW7gcebbiADmxPg3Lq7RYYJs3/444zLh1Y X-Received: by 2002:a05:6512:2245:: with SMTP id i5mr2248097lfu.289.1643275736148; Thu, 27 Jan 2022 01:28:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1643275736; cv=pass; d=google.com; s=arc-20160816; b=VGakJhhIJ/Od5k5wrBjlE6FSS0IfmIHZnJEEjtCOHSdKTsBLp1KLHUPKSAM2yKelzX zvcsDYjv1s9jpe67HTREuB7BKpEtYldUaGT4QrUanmPVZA7ErJ1lpeQ3+Yy+TgOYgCkS 8aAvUD32F3WKDzKdNZBP78VR/GLgX0/2KQUaFjHgzfW6W47g1I/KUvZUEJK4UwokZvZv udSAx3VkN8Jr8ZLeY7CqsY8VbQstESPsxyZ9BjEG+T3nnp6tIrhLS60wxsl20wt8mK+s kLnXHzh4Q2NqEU9hKJPsQ/NLck/z4S4HA3DKLyjdAzZX/+Z2zyrq9v49jS68mJ8Jwga+ JcdQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=LdnosxGUFQgEBaX9vr5zGL0uI5av0W6AnrVcH39Nh/w=; b=tTh2Yera1mbSLFZ/JrWO5cFUm7nZprP7+FK/8rthAVQk20c94Hn3jyhq+w/qqC20Rj /raQiiTE7T8RJv35L5r7ApawRoW27sKfGO1cmWpnsoJ2UvsBip/+w+x2oxHXf8+9kW2D HSWyJ3zzG7ClFtbmF/3mfO2LJx0oCYMTEu4FGcbG5PzpSNyNj243WqV9WjX153upSdBe 0Rx3sy9R6SVHTDuNtZ9HwsRG2qMOt/iiJLJijfuJbUlP3VNry2weAhSc2TfsHXKvBV1+ l5ATPRAcQq7qtJzXffQ/Mw0EyTFNIIJAAtkfSgdgDnYd2Zb4WkDzOjmaRp4VuXUt+1QA iRyA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=wSUAiEm8; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.4.74 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40074.outbound.protection.outlook.com. [40.107.4.74]) by gmr-mx.google.com with ESMTPS id k18si45065lfe.8.2022.01.27.01.28.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jan 2022 01:28:56 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.4.74 as permitted sender) client-ip=40.107.4.74; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=wSUAiEm8; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.4.74 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l44cluvKuIAFR73r3aGqiID+/VI6UzLl/nlhCHPGgktIAtVKEX2kL55jxZ1JWIeDaQLymQI5pwGaaVoWCGo0wd8Vk+Irv7vjZIfJjjY7iuHmsjmTeVmCoIWqNGjW3ZP1rbEfeeTRtltnk19ytNFGWM5ZQWGN8FmYH1ivyjgfYZmWTQlnAVbUTlLA5HvhY8IbhvS9+QUdmTkGNeHmouBN41oQxun95CixnL75yjxI+XPjgQocyoLZtpzn2jPzRTLMOU2M8ce7Rm6ANqAKH15oWC0hj0IdZ5lX64WrFpfTU3+7pSGHLoQI4bHzdc90+dMMxGM4Db1lyfOohVaLKmSIMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LdnosxGUFQgEBaX9vr5zGL0uI5av0W6AnrVcH39Nh/w=; b=DiLOg+dbZZGoK13ODXJksze+zEhS/WSBZ5kVx8HCD7Uqe6Rzz0q3HkvRoNUg5xNvwpTp2HI5HkOk13EkuWlzjRtkYXOc0YJDxErE60a1U5ClTdtbMuJlA9DCjYOdxo+RLWvkze15it7S//+uneSBGca0VABxf2el/xA9EjhNrd14e0P9cviYmf5UAP8vPrFHUzCWYTQLRoCq61+6leaxX4p8abGxYAl3M492N/XjcLbmcbGXXUatzMpHtojpYI99R4aMTh3uiZ0VXnpYeIpHpqc3Sq+w+HDYb9SB61XgmKMQyPFBnyQPEQ2rfgoD2uNxUWFAW5OcSaKBykIIXdJLLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.72) smtp.rcpttodomain=googlegroups.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LdnosxGUFQgEBaX9vr5zGL0uI5av0W6AnrVcH39Nh/w=; b=wSUAiEm8pzTirgqR60jpr+qOYVs/JzhtBWcUDIoyjwBfxk6Xch95Q7R4jB1sorV7RH2+vbLr07LY+xwmXci5XljTKnjbz8Px0oMpbV7RHFOCfyRtYq8QI7OBSvdCck1iXKuzeHlWrYbYubHGQg2xQPQuu15SJgiv3Fy0ipYs/q1Br+wagrB5lfZEWOsQgwLclmiNAtGN7UL+k4P8XSH5gDUzWzWXDMRGl71juWlns91hKuw2491GmJ7VIXz/qDmV1Eo+xES4Gfdga8kOMUd40hZvwvUk2vNL2bDDFbknL8qIz71fRdRkvewl6dBtWJFiVzt17ifwS1dFprOs6dL15g== Received: from DB3PR08CA0013.eurprd08.prod.outlook.com (2603:10a6:8::26) by DB8PR10MB3513.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:140::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Thu, 27 Jan 2022 09:28:54 +0000 Received: from DB5EUR01FT033.eop-EUR01.prod.protection.outlook.com (2603:10a6:8:0:cafe::b) by DB3PR08CA0013.outlook.office365.com (2603:10a6:8::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15 via Frontend Transport; Thu, 27 Jan 2022 09:28:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.72) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.72 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.72; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.72) by DB5EUR01FT033.mail.protection.outlook.com (10.152.4.248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4930.15 via Frontend Transport; Thu, 27 Jan 2022 09:28:54 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SMA.ad011.siemens.net (194.138.21.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Thu, 27 Jan 2022 10:28:54 +0100 Received: from [167.87.73.11] (167.87.73.11) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Thu, 27 Jan 2022 10:28:53 +0100 Message-ID: <189b5510-ecdc-62a7-fc43-aec2a7d66866@siemens.com> Date: Thu, 27 Jan 2022 10:28:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 2/3] refactor linux-custom.inc to use ISAR's DEB_BUILD_PROFILES support Content-Language: en-US To: Felix Moessbauer , CC: References: <20220112143949.3456842-1-felix.moessbauer@siemens.com> <20220112143949.3456842-3-felix.moessbauer@siemens.com> From: Jan Kiszka In-Reply-To: <20220112143949.3456842-3-felix.moessbauer@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [167.87.73.11] X-ClientProxiedBy: DEMCHDC89YA.ad011.siemens.net (139.25.226.104) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 339dac66-34ca-427a-0a29-08d9e177701e X-MS-TrafficTypeDiagnostic: DB8PR10MB3513:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EMXICA00VpkFjoCB6fc8jhtpyfhyved4t7M3Tt5/Iy5t+qy1Mp3F7njIGltyHSCUheZpxpCXPIXiqPHzdUMu4hr1WYpPZQwCXxNFWE9FKNZu/m+RogcZi3uiDmk9mB1j4ZpCTb9EMS+W/opbHSkv+6r9EgKadAwI1b5ID87T7h0PSUiFlHNsd8AuDr5bEOF4PdMZims8A9xAa5Dpk0nwIhw6OFyDBMapVI40ApEqGX8j/9OiWJmIdzzeK3DrefslonfV9B59k0jmwZQ/qblnUoEFQfSwzMWmW2NVBU1E318D7zKjt1cvSEjG1awvMNbC7lBUz/2XL+DYntSzbtboX0Fih0iek+K05SWIxF/RLhvAFM9jTM8B2Jpr8l2Mfy2UXTNF9Dby5Wp8lZ61jp2pbEfUi3/ERInHJdobOvynMxfGCuH2WJbE8c5zb2Hr5TpDCmmYauCtvcD8gIoLhRu7qRNcYpOvls1Ve5926sb0/vVlohJsAs76X9+0awz/jGqyywvZBBIPmCnbDry3ZueJtQ4LxaVxJ3kurPA6VssfzyyDfia6F4C9NQKnK7P+JdsTdlMW+iJTPpIQ1SFKR3nYAqcTChoU5nL8O4wxw8faoZ0VGfdnNRPxrEt8m/E15dg9uguT8rwh2pgnpeMXfL7jzn89b6/ighcOG+ksQ7i/goqp3yW8E6Fczv9+9m+W6MMsmHOuLSPU5IT7/zriRG4MhtZeTP6s7gv42Ho1utf4WHxj6E7bU4WpFLMFgXesiHc5rjDqZCeWyiXVQgsMfnX+og== X-Forefront-Antispam-Report: CIP:194.138.21.72;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(6706004)(110136005)(36756003)(36860700001)(40460700003)(16526019)(2906002)(53546011)(31686004)(186003)(26005)(2616005)(956004)(316002)(16576012)(508600001)(86362001)(83380400001)(82310400004)(336012)(70206006)(70586007)(4326008)(8936002)(8676002)(31696002)(47076005)(81166007)(44832011)(5660300002)(356005)(82960400001)(3940600001)(43740500002)(36900700001)(20210929001);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 09:28:54.7229 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 339dac66-34ca-427a-0a29-08d9e177701e X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.72];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR01FT033.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3513 X-TUID: cA6Zf4J5C9jz On 12.01.22 15:39, Felix Moessbauer wrote: > This patch replaces the manual setup of the DEB_BUILD_PROFILES > environment variable in the linux-custom.inc recipe. > Instead, the recently introduced DEB_BUILD_PROFILES infrastructure > of ISAR is used. > > Signed-off-by: Felix Moessbauer > --- > meta/recipes-kernel/linux/linux-custom.inc | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc > index ed89aa09..59d42c84 100644 > --- a/meta/recipes-kernel/linux/linux-custom.inc > +++ b/meta/recipes-kernel/linux/linux-custom.inc > @@ -117,6 +117,14 @@ def config_fragments(d): > fragments.append(local) > return fragments > > +def get_additional_build_profiles(d): > + profiles = d.getVar('BASE_DISTRO', True) > + if d.getVar('KERNEL_LIBC_DEV_DEPLOY', True) != '1': > + profiles += ' nolibcdev' > + return profiles > + > +DEB_BUILD_PROFILES += "${@get_additional_build_profiles(d)}" > + > do_prepare_build_prepend() { > # copy meta-data over to source tree > rm -rf ${S}/debian > @@ -176,10 +184,5 @@ dpkg_configure_kernel() { > } > > dpkg_runbuild_prepend() { > - profiles="${BASE_DISTRO}" > - if [ "${KERNEL_LIBC_DEV_DEPLOY}" != "1" ]; then > - profiles="${profiles} nolibcdev" > - fi > - export DEB_BUILD_PROFILES="${profiles}" > dpkg_configure_kernel > } After local experiments, it looks like this patch must be folded into patch 1 in order to avoid that linux-libc-dev gets built accidentally when it shouldn't. Jan -- Siemens AG, Technology Competence Center Embedded Linux